Allowed vulps, tajaran, felinids, humans and dwarfs to wag their tail on command #858
No reviewers
Labels
No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Byrd-Station/Byrd!858
Loading…
Reference in a new issue
No description provided.
Delete branch ":species/tailwag"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Short description
Cherry pick of https://github.com/ProjectOmu/OmuStation/pull/1438
Wag wag wag
Why we need to add this
Having a button for wagging the tail is pawsome
Technical details
Renamed and disabled all of the animated states and added the wagging component to the all the base mobs.
Additionally, I've updated the wagging system to only show the button when the equipped tail has a wagging animation.
Media (Video/Screenshots)
Checklist
Ingame Changelog
🆑 Quill
species/tailwagto Allowed vulps, tajaran, felinids, humans and dwarfs to wag their tail on command - #1438Allowed vulps, tajaran, felinids, humans and dwarfs to wag their tail on command - #1438to Allowed vulps, tajaran, felinids, humans and dwarfs to wag their tail on commandAllowed vulps, tajaran, felinids, humans and dwarfs to wag their tail on commandto WIP: Allowed vulps, tajaran, felinids, humans and dwarfs to wag their tail on commandFound a bug one secondWIP: Allowed vulps, tajaran, felinids, humans and dwarfs to wag their tail on commandto Allowed vulps, tajaran, felinids, humans and dwarfs to wag their tail on command@ -0,0 +85,4 @@else{newMarkingId = currentMarkingId;Log.Warning($"Unable to revert wagging for {currentMarkingId}");I don't think this needs to give a warning, feels like bloating logs in my opinion. Some species (humans) can have multiple tails and they are not required to be animated. So this should be expected and normal.
This if branch is only reached when they're already wagging (Note the
wagging.Wagging = !wagging.Wagging;assignment before the loop). This means the revert fails to the non animated version, not when a human or whoever doesn't have a wagging animation for the specified marking.This method is basically 1:1 copied from the upstream wizden wagging system:
ee4263026b/Content.Server/Wagging/WaggingSystem.csTransition to wagging can fail as well.
Try a human character with
Demon Tail 1andVulpkanin (Animated)markings.It's nice for debugging, but I don't think it's important enough to be in production. This can be left as is I guess.
@ -9,3 +9,3 @@- type: markingid: dogTailWagid: dogTailAnimated # Omu - TailwagdogTailis animated but the loc string was not updated to reflect this.@ -0,0 +1,43 @@# Tajaran Head/Face- type: markingid: TajaranHeadTuxedoThis doesn't have a loc string
@ -0,0 +12,4 @@# Tajaran Torso- type: markingid: TajaranTorsoTuxedoThis doesn't have a loc string
LGTM. Thank you for your contribution!
(this was done before commit
73d59962a5even though it doesn't look like it was)LGTM.
(There is another log, but this is good enough)