Byrd-Station/Byrd
Byrd-Station/Byrd
Watch
4
5
Fork
You've already forked Byrd
 22
Code Issues 33 Pull requests 35 Projects 1 Wiki Activity Actions 37

Rama #938

Merged
EchoOfNothing merged 3 commits from :species/shadowkin/rama into master 2026-09-20 15:40:34 +00:00
Conversation 4 Commits 3 Files changed 6 +71
QuillTheCreature commented 2026-09-18 21:37:38 +00:00
Member

Short description

Re-added the rama feature to shadowkins from EE.

It just makes them fall asleep, nothing else.

Why we need to add this

It's funny when a kin hits the fall asleep button.

Help

There's a million different ways to add an action, so please tell me if this is the "correct" way of doing it.

Media (Video/Screenshots)

Checklist

Ingame Changelog

🆑 Quill

  • add: Shadowkins can now Rama.
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Re-added the rama feature to shadowkins from EE. It just makes them fall asleep, nothing else. ## Why we need to add this It's funny when a kin hits the fall asleep button. ## Help There's a million different ways to add an action, so please tell me if this is the "correct" way of doing it. ## Media (Video/Screenshots) <video src="/attachments/4b45efbb-7abd-44cf-aecf-950ac7b9b36a" title="Screencast_20260918_233135" controls></video> ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - add: Shadowkins can now Rama.
Screencast_20260918_233135.webm
671 KiB
Added a rama action to all shadowkins
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Labels: Size / size-label (pull_request_target) Failing after 4s
Details
Labels: PR / labeler (pull_request_target) Successful in 4s
Details
CRLF Check / CRLF Check (pull_request) Successful in 53s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 1m7s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m13s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m49s
Details
YAML Linter / YAML Linter (pull_request) Failing after 7m39s
Details
Test Packaging / Test Packaging (pull_request) Successful in 16m32s
Details
6fdc1ee285
QuillTheCreature reviewed 2026-09-18 21:46:54 +00:00
Content.Shared/_Byrd/Actions/RamaSystem.cs Outdated
@ -0,0 +19,4 @@
private void OnComponentInit(EntityUid uid, RamaComponent component, ComponentInit args)
{
if (component.RamaAction == null)
QuillTheCreature commented 2026-09-18 21:37:53 +00:00
Author
Member

Pretty confident that this check is uselss, but some components did it so 🤷

Pretty confident that this check is uselss, but some components did it so 🤷
EchoOfNothing commented 2026-09-20 11:58:39 +00:00
Owner

Yeah, it does nothing. I don't like code that does nothing so I prefer if it was removed.

Yeah, it does nothing. I don't like code that does nothing so I prefer if it was removed.
👍 1
QuillTheCreature marked this conversation as resolved
QuillTheCreature reviewed 2026-09-18 21:47:24 +00:00
Content.Shared/_Byrd/Actions/RamaSystem.cs Outdated
@ -0,0 +13,4 @@
{
base.Initialize();
SubscribeLocalEvent<RamaComponent, ComponentInit>(OnComponentInit);
QuillTheCreature commented 2026-09-18 21:47:22 +00:00
Author
Member

Some do it on MapInit instead, I'm confused why that would be better.

Some do it on MapInit instead, I'm confused why that would be better.
EchoOfNothing commented 2026-09-20 12:00:27 +00:00
Owner

MapInit is only run once which is good for an action that won't change/update. ComponentInit can be called more than once in a component's lifetime and at any moment.

`MapInit` is only run once which is good for an action that won't change/update. `ComponentInit` can be called more than once in a component's lifetime and at any moment.
👍 1
QuillTheCreature marked this conversation as resolved
EchoOfNothing requested changes 2026-09-20 11:57:58 +00:00
Dismissed
Content.Shared/_Byrd/Actions/RamaComponent.cs Outdated
@ -0,0 +4,4 @@
public sealed partial class RamaComponent : Component
{
[DataField]
public EntityUid? RamaAction;
EchoOfNothing commented 2026-09-20 11:52:11 +00:00
Owner

For consistency, this should be RamaActionActionEntity and RamaActionId should be moved here from RamaSystem. You can check GhostComponent for reference.

For consistency, this should be `RamaActionActionEntity` and `RamaActionId` should be moved here from `RamaSystem`. You can check `GhostComponent` for reference.
👍 1
QuillTheCreature marked this conversation as resolved
Updated the rama system to move the action id over to the component and renamed the entity uid
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 4s
Details
Labels: Size / size-label (pull_request_target) Successful in 3s
Details
CRLF Check / CRLF Check (pull_request) Successful in 46s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m12s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 1m16s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 8m37s
Details
YAML Linter / YAML Linter (pull_request) Failing after 9m0s
Details
Test Packaging / Test Packaging (pull_request) Successful in 19m52s
Details
PR Changelogs / changelog (pull_request_target) Successful in 38s
Details
afad607952
EchoOfNothing approved these changes 2026-09-20 15:40:15 +00:00
EchoOfNothing left a comment

LGTM. Thank you for your contribution!

LGTM. Thank you for your contribution!
EchoOfNothing referenced this pull request from a commit 2026-09-20 15:40:35 +00:00
Rama (#938)
byrdbot referenced this pull request from a commit 2026-09-20 15:41:12 +00:00
Automatic changelog update (#938)
orangeAlligator referenced this pull request from a commit 2026-09-27 18:41:58 +00:00
Rama (#938)
Sign in to join this conversation.
Reviewers
No reviewers
EchoOfNothing
Labels
Clear labels   
Area/Accessibility
Area: Accessibility settings and features.

  
Area/Admin Tooling
Area: Admin tooling and moderation

  
Area/Art
Area: Art with no implications for other areas.

  
Area/Atmospherics
Area: Atmospherics

  
Area/Cargo
Area: Cargo department and related mechanics

  
Area/Character / Species
Area: Player characters and species features and content.

  
Area/Chat
Area: Chat-related features and changes, most likely technical.

  
Area/Combat
Area: Combat features, changes, balancing.

  
Area/Command
Area: Command department, where it isn't applicable to other departments.

  
Area/Database
Area: Changes to Database code.

  
Area/Engineering
Area: Engineering department, doesn't include Atmospherics.

  
Area/Graphics
Area: Changes to shaders or overlays.

  
Area/Guidebook
Area: Ingame guidebook, content or technical implementation.

  
Area/Mapping
Area: Maps, or tools used for mapping

  
Area/Medical
Area: Medical department, including Chemistr

  
Area/Preferences / Options
Area: Player preferences and options.

  
Area/Roleplay / Lore
Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics

  
Area/Roundflow / Antag
Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities.

  
Area/Rules
Area: Changes to Server rules, SoP, or Space Law.

  
Area/Salvage
Area: Salvage changes

  
Area/Science
Area: Science department, not including Silicons.

  
Area/Security
Area: Security department, including Detectives, HoS

  
Area/Service
Area: Service department, including cooking, botany, etc

  
Area/Silicons
Area: Relates to Silicon roles, including AI.

  
bug
This is in regards to a bug.

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
DON'T MERGE
This is under review, fixes, or needs significant changes.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
Note/Port
A port from another repository.

  
Note/Upstream
A PR from upstream.

  
Priority
Critical
 Critical priority task!!

  
Priority
High
 High priority task

  
Priority
Low
 Low priority task

  
Priority
Normal
 Normal priority task

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
State/Approved
This PR has been approved.

  
State/invalid
This doesn't seem right

  
State/Merge Conflict

   
State/Needs Changes
Changes/Concerns have been brought up and should be made before review.

  
State/Needs Discussion
Discussion needed for changes, talk about it.

  
State/Untriaged

   
Type/Balance Change
Changes something in the game related to balancing.

  
Type/Bugfix
Fixes a known issue/bug.

  
Type/Documentation
Makes changes to documentation in the repository. This includes attributions changes.

  
Type/Enhancement
New feature or request, change to game.

  
Type/Feature
Adds completely new stuff to the game.

  
Type/Question
Further information is requested.

  
wontfix
This will not be worked on

No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!938
No description provided.