Fixed suit sensor preferences not being serialized to the database #946

Merged

EchoOfNothing merged 1 commit from :systems/suitsensors into master 2026-09-26 13:27:34 +00:00

Conversation 1 Commits 1 Files changed 1 +1

QuillTheCreature commented 2026-09-21 20:41:45 +00:00

Member

• Copy link
• Copy Markdown

Short description

Currently the suit sensor preference is not saved to the database, so it's always set to "random" even when the client shows something else.

This fixes that by actually writing the value to the database.

Why we need to add this

Bugfix

Media (Video/Screenshots)

Before

After

Checklist

• I do not require assistance to complete the PR.
• I have verified that the changes work before posting/requesting review of my PR.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I have read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset.

Ingame Changelog

🆑 Quill

• fix: Suit sensors preferences now save properly.

<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Currently the suit sensor preference is not saved to the database, so it's always set to "random" even when the client shows something else. This fixes that by actually writing the value to the database. ## Why we need to add this Bugfix ## Media (Video/Screenshots) ### Before  ### After  ## Checklist - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - fix: Suit sensors preferences now save properly.

image.png

52 KiB

image.png

50 KiB

QuillTheCreature added 1 commit 2026-09-21 20:41:45 +00:00

Fixed suit sensor preferences not being serialized to the database 5839213adb

EchoOfNothing approved these changes 2026-09-26 13:27:09 +00:00

EchoOfNothing left a comment

• Copy link
• Copy Markdown

LGTM. Thank you for your contribution!

LGTM. Thank you for your contribution!

EchoOfNothing added the

size/XS

label 2026-09-26 13:27:14 +00:00

EchoOfNothing merged commit 1e749ee28f into master 2026-09-26 13:27:34 +00:00

EchoOfNothing referenced this pull request from a commit 2026-09-26 13:27:36 +00:00

Fixed suit sensor preferences not being serialized to the database (#946)

byrdbot referenced this pull request from a commit 2026-09-26 13:28:45 +00:00

Automatic changelog update (#946)

orangeAlligator referenced this pull request from a commit 2026-09-27 18:41:58 +00:00

Fixed suit sensor preferences not being serialized to the database (#946)

Sign in to join this conversation.

Reviewers

No reviewers

EchoOfNothing

Labels

Clear labels   

Area/Accessibility

Area: Accessibility settings and features.

  

Area/Admin Tooling

Area: Admin tooling and moderation

  

Area/Art

Area: Art with no implications for other areas.

  

Area/Atmospherics

Area: Atmospherics

  

Area/Cargo

Area: Cargo department and related mechanics

  

Area/Character / Species

Area: Player characters and species features and content.

  

Area/Chat

Area: Chat-related features and changes, most likely technical.

  

Area/Combat

Area: Combat features, changes, balancing.

  

Area/Command

Area: Command department, where it isn't applicable to other departments.

  

Area/Database

Area: Changes to Database code.

  

Area/Engineering

Area: Engineering department, doesn't include Atmospherics.

  

Area/Graphics

Area: Changes to shaders or overlays.

  

Area/Guidebook

Area: Ingame guidebook, content or technical implementation.

  

Area/Mapping

Area: Maps, or tools used for mapping

  

Area/Medical

Area: Medical department, including Chemistr

  

Area/Preferences / Options

Area: Player preferences and options.

  

Area/Roleplay / Lore

Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics

  

Area/Roundflow / Antag

Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities.

  

Area/Rules

Area: Changes to Server rules, SoP, or Space Law.

  

Area/Salvage

Area: Salvage changes

  

Area/Science

Area: Science department, not including Silicons.

  

Area/Security

Area: Security department, including Detectives, HoS

  

Area/Service

Area: Service department, including cooking, botany, etc

  

Area/Silicons

Area: Relates to Silicon roles, including AI.

  

bug

This is in regards to a bug.

  

Changes: Audio

  

Changes: Map

  

Changes: No C#

  

Changes: Sprites

  

Changes: UI

  

documentation

Improvements or additions to documentation

  

DON'T MERGE

This is under review, fixes, or needs significant changes.

  

duplicate

This issue or pull request already exists

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

holding to vote

This is currently being voted for by the Byrds.

  

Note/Port

A port from another repository.

  

Note/Upstream

A PR from upstream.

  

Priority

Critical

Critical priority task!!

  

Priority

High

High priority task

  

Priority

Low

Low priority task

  

Priority

Normal

Normal priority task

  

size/L

  

size/M

  

size/S

  

size/XL

  

size/XS

  

State/Approved

This PR has been approved.

  

State/invalid

This doesn't seem right

  

State/Merge Conflict

  

State/Needs Changes

Changes/Concerns have been brought up and should be made before review.

  

State/Needs Discussion

Discussion needed for changes, talk about it.

  

State/Untriaged

  

Type/Balance Change

Changes something in the game related to balancing.

  

Type/Bugfix

Fixes a known issue/bug.

  

Type/Documentation

Makes changes to documentation in the repository. This includes attributions changes.

  

Type/Enhancement

New feature or request, change to game.

  

Type/Feature

Adds completely new stuff to the game.

  

Type/Question

Further information is requested.

  

wontfix

This will not be worked on

No labels

Area/Accessibility

Area/Admin Tooling

Area/Art

Area/Atmospherics

Area/Cargo

Area/Character / Species

Area/Chat

Area/Combat

Area/Command

Area/Database

Area/Engineering

Area/Graphics

Area/Guidebook

Area/Mapping

Area/Medical

Area/Preferences / Options

Area/Roleplay / Lore

Area/Roundflow / Antag

Area/Rules

Area/Salvage

Area/Science

Area/Security

Area/Service

Area/Silicons

bug

Changes: Audio

Changes: Map

Changes: No C#

Changes: Sprites

Changes: UI

documentation

DON'T MERGE

duplicate

good first issue

help wanted

holding to vote

Note/Port

Note/Upstream

Priority

Critical

Priority

High

Priority

Low

Priority

Normal

size/L

size/M

size/S

size/XL

size/XS

State/Approved

State/invalid

State/Merge Conflict

State/Needs Changes

State/Needs Discussion

State/Untriaged

Type/Balance Change

Type/Bugfix

Type/Documentation

Type/Enhancement

Type/Feature

Type/Question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Byrd-Station/Byrd!946

No description provided.