Flash vulnerability only triggers when the character uses its own night vision instead of an item with night vision. #947

Merged
EchoOfNothing merged 2 commits from :systems/flashvuln/onlywhennv into master 2026-09-26 18:19:46 +00:00
Member

Short description

This PR changes Shadowkins to only be flash vulnerable when they're currently using their own night vision.

If they don't have it turned on then they don't have flash vulnerability.

Additionally, like any other species, they now can equip night vision goggles and also don't have flash vulnerability.

Why we need to add this

This is a slight mald pr but for others, I didn't really mind it but some were irritated by it.

Personally I think downsides should only be downsides when actually using the upside? So for me it didn't make a lot of sense that Shadowkins for example were always flash vulnerable even when they don't use their night vision.

Media (Video/Screenshots)

Checklist

Ingame Changelog

🆑 Quill

  • tweak: Shadowkins don't suffer from Flash Vulnerability anymore when their own Night Vision is not active.
  • tweak: Shadowkins can now equip Night Vision Goggles, turn those on and don't get Flash Vulnerability anymore.
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description This PR changes Shadowkins to only be flash vulnerable when they're currently using their own night vision. If they don't have it turned on then they don't have flash vulnerability. Additionally, like any other species, they now can equip night vision goggles and also don't have flash vulnerability. ## Why we need to add this This is a slight mald pr but for others, I didn't really mind it but some were irritated by it. Personally I think downsides should only be downsides when actually using the upside? So for me it didn't make a lot of sense that Shadowkins for example were always flash vulnerable even when they don't use their night vision. ## Media (Video/Screenshots) <video src="/attachments/b797b55f-fd20-41e2-a7f8-16cc4e488898" title="Screencast_20260922_154319" controls></video> ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - tweak: Shadowkins don't suffer from Flash Vulnerability anymore when their own Night Vision is not active. - tweak: Shadowkins can now equip Night Vision Goggles, turn those on and don't get Flash Vulnerability anymore.
Added a second mode to flash vulnerability which only triggers when the character uses its own night vision instead of an item with night vision.
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 1m10s
Labels: Size / size-label (pull_request_target) Failing after 1m10s
CRLF Check / CRLF Check (pull_request) Successful in 1m43s
RSI Validator / Validate RSIs (pull_request) Successful in 1m14s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m35s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m43s
YAML Linter / YAML Linter (pull_request) Successful in 7m32s
Test Packaging / Test Packaging (pull_request) Successful in 16m53s
dbf6ebe6aa
Contributor

peak

peak
EchoOfNothing requested changes 2026-09-26 13:38:17 +00:00
Dismissed
Lines 49-61
@ -18,0 +46,16 @@
return false;
}
private bool CheckForNightVisionItemsInInventory(Entity<FlashVulnerableComponent> ent)
{
if (!_inventory.TryGetContainerSlotEnumerator(ent.Owner, out var enumerator))
return false;
while (enumerator.NextItem(out var item, out _))
{
if (_entityManager.HasComponent<NightVisionComponent>(item))
return true;
}
return false;
}
Owner

Having night vision goggles in a pocket also protects you. Which I think shouldn't happen.

Having night vision goggles in a pocket also protects you. Which I think shouldn't happen.
Author
Member

Oh yeah that checks out.

Should I just change it to do a eyes check?

My initial thought has been to check all clothes just in case there's something else (eg a helmet) which gives night vision.

Oh yeah that checks out. Should I just change it to do a eyes check? My initial thought has been to check all clothes just in case there's something else (eg a helmet) which gives night vision.
QuillTheCreature marked this conversation as resolved
Switched to only allowing eyes for checking night vision
All checks were successful
Labels: PR / labeler (pull_request_target) Successful in 1m3s
Labels: Size / size-label (pull_request_target) Successful in 1m3s
CRLF Check / CRLF Check (pull_request) Successful in 1m41s
RSI Validator / Validate RSIs (pull_request) Successful in 1m6s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m22s
YAML Linter / YAML Linter (pull_request) Successful in 7m0s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m46s
Test Packaging / Test Packaging (pull_request) Successful in 16m3s
PR Changelogs / changelog (pull_request_target) Successful in 42s
f48bad715b
EchoOfNothing left a comment

LGTM. Thank you for your contribution!

LGTM. Thank you for your contribution!
byrdbot referenced this pull request from a commit 2026-09-26 18:20:28 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!947
No description provided.