Byrd-Station/Byrd
Byrd-Station/Byrd
Watch
4
5
Fork
You've already forked Byrd
 22
Code Issues 33 Pull requests 35 Projects 1 Wiki Activity Actions 37

Added a graphics option to toggle rendering of players and borgs in the round end summary window. #986

Closed
QuillTheCreature wants to merge 5 commits from (deleted):ui/roundendsummary/renderplayerstoggle into master
pull from: (deleted):ui/roundendsummary/renderplayerstoggle
merge into: Byrd-Station:master
Conversation 4 Commits 5 Files changed 5 +30 -10
QuillTheCreature commented 2026-10-03 16:31:42 +00:00
Member

Short description

I added a graphics option to toggle rendering of players and borgs in the round end summary window.

It's now by default off but it can be enabled anytime in the options if you want to see all of the player sprites again.

Why we need to add this

Some players on discord express lower fps in cc and expect this to be the issue.

Media (Video/Screenshots)

image

Off On
Screenshot_20261003_181736 Screenshot_20261003_182318
image Screenshot_20261003_182321

Checklist

Ingame Changelog

🆑 Quill

  • tweak: Players and cyborgs don't render in the round end summary window anymore by default.
  • add: Added a toggle in the graphics options to toggle player and cyborg rendering in the round end summary window.
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description I added a graphics option to toggle rendering of players and borgs in the round end summary window. It's now by default off but it can be enabled anytime in the options if you want to see all of the player sprites again. ## Why we need to add this Some players on discord express lower fps in cc and expect this to be the issue. ## Media (Video/Screenshots) ![image](/attachments/e2e55acd-2d35-4249-842f-9c3dace2b2ec) | Off | On | | --- | --- | | ![Screenshot_20261003_181736](/attachments/272d9ce4-7a70-48e6-9703-8559fd753b95) | ![Screenshot_20261003_182318](/attachments/c633d7ff-a6ea-459c-accb-202d13ed0897) | | ![image](/attachments/b33238e2-2aca-4dc0-a6cc-25b0ee4efb4a) | ![Screenshot_20261003_182321](/attachments/7ffe70eb-6d94-431c-b618-5084e2f2f0da) | ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - tweak: Players and cyborgs don't render in the round end summary window anymore by default. - add: Added a toggle in the graphics options to toggle player and cyborg rendering in the round end summary window.
Screenshot_20261003_182318.png
13 KiB
Screenshot_20261003_182321.png
25 KiB
image.png
77 KiB
Screenshot_20261003_181736.png
19 KiB
image.png
26 KiB
Screenshot_20261003_182321.png
25 KiB
Screenshot_20261003_182321.png
Added a graphics option to toggle rendering of players and borgs in the round end summary window.
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Labels: PR / labeler (pull_request_target) Successful in 10s
Details
Labels: Size / size-label (pull_request_target) Failing after 6s
Details
CRLF Check / CRLF Check (pull_request) Successful in 1m12s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m28s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 1m35s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 9m30s
Details
YAML Linter / YAML Linter (pull_request) Successful in 11m2s
Details
Test Packaging / Test Packaging (pull_request) Successful in 27m7s
Details
4818fbfcd8
EchoOfNothing reviewed 2026-10-06 19:54:49 +00:00
Content.Client/RoundEnd/RoundEndSummaryWindow.cs Outdated
@ -20,3 +22,4 @@
{
public sealed class RoundEndSummaryWindow : DefaultWindow
{
[Dependency] private readonly INetConfigurationManager _netConfig = default!; // Byrd
EchoOfNothing commented 2026-10-06 19:49:05 +00:00
Owner

Since we don't have a reason to replicate RenderEntitiesInEorSummaryWindow, might as well switch to IConfigurationManager

Since we don't have a reason to replicate `RenderEntitiesInEorSummaryWindow`, might as well switch to `IConfigurationManager`
👍 1
QuillTheCreature marked this conversation as resolved
Content.Shared/CCVar/CCVars.Byrd.cs Outdated
@ -85,0 +87,4 @@
/// Whenever to render players and borgs in the round end summary window.
/// </summary>
public static readonly CVarDef<bool> RenderEntitiesInEorSummaryWindow =
CVarDef.Create("byrd.renderentitiesinroundendsummarywindow", false, CVar.CLIENT | CVar.REPLICATED | CVar.ARCHIVE);
EchoOfNothing commented 2026-10-06 19:48:03 +00:00
Owner

Server doesn't care about this cvar, meaning this should be CVar.CLIENTONLY | CVar.ARCHIVE.
Also this is a pretty hard to read name, maybe add some underscores in there to make it easier to read.

Server doesn't care about this cvar, meaning this should be `CVar.CLIENTONLY | CVar.ARCHIVE`. Also this is a pretty hard to read name, maybe add some underscores in there to make it easier to read.
👍 1
QuillTheCreature marked this conversation as resolved
Updated the render entities in round end summary window cvar
Some checks failed
Labels: PR / labeler (pull_request_target) Has been cancelled
Details
Labels: Size / size-label (pull_request_target) Has been cancelled
Details
CRLF Check / CRLF Check (pull_request) Has been cancelled
Details
Test Packaging / Test Packaging (pull_request) Has been cancelled
Details
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
Details
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Details
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
Details
YAML Linter / YAML Linter (pull_request) Has been cancelled
Details
d11f9d5a69
Switched over to the local config manager in the round end summary window
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 5s
Details
Labels: Size / size-label (pull_request_target) Successful in 4s
Details
CRLF Check / CRLF Check (pull_request) Successful in 1m31s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m22s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 1m39s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 9m1s
Details
YAML Linter / YAML Linter (pull_request) Successful in 9m26s
Details
Test Packaging / Test Packaging (pull_request) Successful in 25m27s
Details
46cb2d66f4
EchoOfNothing requested changes 2026-10-07 16:05:44 +00:00
Dismissed
Content.Client/RoundEnd/RoundEndSummaryWindow.cs Outdated
@ -20,3 +22,4 @@
{
public sealed class RoundEndSummaryWindow : DefaultWindow
{
[Dependency] private readonly IConfigurationManager _netConfig = default!; // Byrd
EchoOfNothing commented 2026-10-07 16:03:00 +00:00
Owner

It's no longer INetConfigManager, but the field is still called _**net**Config

It's no longer `INetConfigManager`, but the field is still called `_**net**Config`
😕 1
QuillTheCreature marked this conversation as resolved
Content.Shared/CCVar/CCVars.Byrd.cs Outdated
@ -85,0 +87,4 @@
/// Whenever to render players and borgs in the round end summary window.
/// </summary>
public static readonly CVarDef<bool> RenderEntitiesInEorSummaryWindow =
CVarDef.Create("byrd.render_entities_in_round_end_summary_window", false, CVar.CLIENT | CVar.ARCHIVE);
EchoOfNothing commented 2026-10-07 16:04:37 +00:00
Owner

This cvar is never used on the server (and I don't see a reason for it to ever be used there) so it should be CVar.CLIENTONLY

This cvar is never used on the server (and I don't see a reason for it to ever be used there) so it should be `CVar.CLIENTONLY`
QuillTheCreature marked this conversation as resolved
Renamed the local config manager to _config
Some checks failed
Labels: PR / labeler (pull_request_target) Has been cancelled
Details
Labels: Size / size-label (pull_request_target) Has been cancelled
Details
CRLF Check / CRLF Check (pull_request) Has been cancelled
Details
Test Packaging / Test Packaging (pull_request) Has been cancelled
Details
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
Details
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Details
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
Details
YAML Linter / YAML Linter (pull_request) Has been cancelled
Details
76429a521b
Switched the render entities in res window to clientonly
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
PR Changelogs / changelog (pull_request_target) Has been skipped
Details
Labels: PR / labeler (pull_request_target) Successful in 9s
Details
Labels: Size / size-label (pull_request_target) Failing after 4s
Details
CRLF Check / CRLF Check (pull_request) Successful in 34s
Details
Test Packaging / Test Packaging (pull_request) Successful in 13m10s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 40s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 43s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m17s
Details
YAML Linter / YAML Linter (pull_request) Successful in 4m53s
Details
9f9e29b558
EchoOfNothing approved these changes 2026-10-07 20:13:52 +00:00
EchoOfNothing left a comment

LGTM. Thank you for your contribution!

LGTM. Thank you for your contribution!
EchoOfNothing commented 2026-10-08 19:36:28 +00:00
Owner

@QuillTheCreature
This pull request is broken due to missing fork information.

@QuillTheCreature `This pull request is broken due to missing fork information.`
QuillTheCreature closed this pull request 2026-10-08 19:54:08 +00:00
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
PR Changelogs / changelog (pull_request_target) Has been skipped
Details
Labels: PR / labeler (pull_request_target) Successful in 9s
Details
Labels: Size / size-label (pull_request_target) Failing after 4s
Details
CRLF Check / CRLF Check (pull_request) Successful in 34s
Details
Test Packaging / Test Packaging (pull_request) Successful in 13m10s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 40s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 43s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m17s
Details
YAML Linter / YAML Linter (pull_request) Successful in 4m53s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
EchoOfNothing
Labels
Clear labels   
Area/Accessibility
Area: Accessibility settings and features.

  
Area/Admin Tooling
Area: Admin tooling and moderation

  
Area/Art
Area: Art with no implications for other areas.

  
Area/Atmospherics
Area: Atmospherics

  
Area/Cargo
Area: Cargo department and related mechanics

  
Area/Character / Species
Area: Player characters and species features and content.

  
Area/Chat
Area: Chat-related features and changes, most likely technical.

  
Area/Combat
Area: Combat features, changes, balancing.

  
Area/Command
Area: Command department, where it isn't applicable to other departments.

  
Area/Database
Area: Changes to Database code.

  
Area/Engineering
Area: Engineering department, doesn't include Atmospherics.

  
Area/Graphics
Area: Changes to shaders or overlays.

  
Area/Guidebook
Area: Ingame guidebook, content or technical implementation.

  
Area/Mapping
Area: Maps, or tools used for mapping

  
Area/Medical
Area: Medical department, including Chemistr

  
Area/Preferences / Options
Area: Player preferences and options.

  
Area/Roleplay / Lore
Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics

  
Area/Roundflow / Antag
Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities.

  
Area/Rules
Area: Changes to Server rules, SoP, or Space Law.

  
Area/Salvage
Area: Salvage changes

  
Area/Science
Area: Science department, not including Silicons.

  
Area/Security
Area: Security department, including Detectives, HoS

  
Area/Service
Area: Service department, including cooking, botany, etc

  
Area/Silicons
Area: Relates to Silicon roles, including AI.

  
bug
This is in regards to a bug.

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
DON'T MERGE
This is under review, fixes, or needs significant changes.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
Note/Port
A port from another repository.

  
Note/Upstream
A PR from upstream.

  
Priority
Critical
 Critical priority task!!

  
Priority
High
 High priority task

  
Priority
Low
 Low priority task

  
Priority
Normal
 Normal priority task

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
State/Approved
This PR has been approved.

  
State/invalid
This doesn't seem right

  
State/Merge Conflict

   
State/Needs Changes
Changes/Concerns have been brought up and should be made before review.

  
State/Needs Discussion
Discussion needed for changes, talk about it.

  
State/Untriaged

   
Type/Balance Change
Changes something in the game related to balancing.

  
Type/Bugfix
Fixes a known issue/bug.

  
Type/Documentation
Makes changes to documentation in the repository. This includes attributions changes.

  
Type/Enhancement
New feature or request, change to game.

  
Type/Feature
Adds completely new stuff to the game.

  
Type/Question
Further information is requested.

  
wontfix
This will not be worked on

No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!986
No description provided.