Fixed reagent pressure threshold not working #1009

Merged

EchoOfNothing merged 1 commit from QuillTheCreature/Byrd:systems/reagents/pressurethreshold into master

2026-10-11 11:24:51 +00:00

QuillTheCreature commented

2026-10-08 19:22:40 +00:00

Member

Short description

Lux pen wasn't working since the pressure threshold effect was setup wrongly.

There was a Shared system which always returned false; meaning the class inside the server module never ran.

I updated it to use the EventEntityEffectCondition system which sends out a local event, meaning the server class can react to it properly.

On top of that this also fixes the actual condition and allows only one bounds to be set at once. So for example for the lux pen, only a maximum pressure is set, in the old system the condition would always return false as min is null.

Why we need to add this

Bugfix

Media (Video/Screenshots)

Checklist

I do not require assistance to complete the PR.
I have verified that the changes work before posting/requesting review of my PR.
I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
I have read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset.

Ingame Changelog

🆑 Quill

fix: Fixed pressure threshold effects not working, meaning luxury medipens finally work properly.

[guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Lux pen wasn't working since the pressure threshold effect was setup wrongly. There was a Shared system which always `returned false;` meaning the class inside the server module never ran. I updated it to use the `EventEntityEffectCondition` system which sends out a local event, meaning the server class can react to it properly. On top of that this also fixes the actual condition and allows only one bounds to be set at once. So for example for the lux pen, only a maximum pressure is set, in the old system the condition would always return false as min is null. ## Why we need to add this Bugfix ## Media (Video/Screenshots) <video src="/attachments/22350247-48f2-4e67-95a0-8ef8f567e2c4" title="Screencast_20261008_211557" controls></video> ## Checklist  - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - fix: Fixed pressure threshold effects not working, meaning luxury medipens finally work properly.

Screencast_20261008_211557.webm

2.9 MiB

QuillTheCreature added 1 commit

2026-10-08 19:22:40 +00:00