Fixed death rattles #1046

QuillTheCreature · 2026-10-09T20:58:40Z

QuillTheCreature commented

2026-10-09 20:58:40 +00:00

Short description

Fixed death rattles:

Made lavaland death rattle work
Fixed the post position flag actually doing anything
Added soft crits to the default crit state check

Why we need to add this

Bugfixes

Media (Video/Screenshots)

Checklist

I do not require assistance to complete the PR.
I have verified that the changes work before posting/requesting review of my PR.
I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
I have read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset.

Ingame Changelog

🆑 Quill

fix: Fixed Deathrattles which have crit state notifications from not showing those properly.
fix: Fixed the Lavaland Deathrattle from not working.
fix: Fixed the Lavaland Deathrattle from not showing coordinates.

[guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Fixed death rattles: * Made lavaland death rattle work * Fixed the post position flag actually doing anything * Added soft crits to the default crit state check ## Why we need to add this Bugfixes ## Media (Video/Screenshots) ![image](/attachments/228dce24-f81a-4b06-a5a8-f3926991378f) ## Checklist  - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - fix: Fixed Deathrattles which have crit state notifications from not showing those properly. - fix: Fixed the Lavaland Deathrattle from not working. - fix: Fixed the Lavaland Deathrattle from not showing coordinates.

image.png

21 KiB

QuillTheCreature added 4 commits

2026-10-09 20:58:40 +00:00

Fixed lavaland death rattle from not doing anything f554421264

Added soft crit to default death rattle critical states 31db6f2381

Fixed coordinates not showing for death rattles when required 2563f0903c

Added soft crit to death rattle when required

Close PRs on master / run (pull_request_target) Has been skipped

Details

Labels: PR / labeler (pull_request_target) Successful in 4s

Details

Labels: Size / size-label (pull_request_target) Failing after 3s

Details

CRLF Check / CRLF Check (pull_request) Successful in 35s

Details

Test Packaging / Test Packaging (pull_request) Successful in 13m54s

Details

RGA schema validator / YAML RGA schema validator (pull_request) Successful in 45s

Details

RSI Validator / Validate RSIs (pull_request) Successful in 44s

Details

Map file schema validator / YAML map schema validator (pull_request) Successful in 5m31s

Details

YAML Linter / YAML Linter (pull_request) Successful in 5m1s

Details

8520ada8c5

QuillTheCreature changed title from ~~entities/deathrattles/fixes~~ to Fixed death rattles

2026-10-10 14:25:27 +00:00

EchoOfNothing reviewed

2026-10-15 08:38:21 +00:00

Resources/Prototypes/Entities/Objects/Misc/subdermal_implants.yml Outdated

					
				@ -358,6 +358,7 @@

				    - type: MansusGraspBlockTrigger # Goobstation

				    - type: TriggerOnMobstateChange

				      mobState:

				      - SoftCritical # Byrd

HardCritical question from last time

`HardCritical` question from last time

Yeah I'm not sure if we want to have hard crits in there so I didn't add them yet.

Basically that would mean you'd usually get two crit notifications and a death one for a person which seems a bit weird?

But I can add it if you feel like that's ok!

Yeah I'm not sure if we want to have hard crits in there so I didn't add them yet. Basically that would mean you'd *usually* get two crit notifications and a death one for a person which seems a bit weird? But I can add it if you feel like that's ok!

@QuillTheCreature wrote in #1046 (comment):

Yeah I'm not sure if we want to have hard crits in there so I didn't add them yet.

Basically that would mean you'd usually get two crit notifications and a death one for a person which seems a bit weird?

But I can add it if you feel like that's ok!

I just feel that if you somehow manage to skip softcrit and implant doesn't say anything despite entering crit is not nice. But getting two notifications is a bit weird too.

@QuillTheCreature wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/1046#issuecomment-9133: > Yeah I'm not sure if we want to have hard crits in there so I didn't add them yet. > > Basically that would mean you'd _usually_ get two crit notifications and a death one for a person which seems a bit weird? > > But I can add it if you feel like that's ok! I just feel that if you somehow manage to skip softcrit and implant doesn't say anything despite entering crit is not nice. But getting two notifications is a bit weird too.

Yeah agree.

I can check where the rattle system is used elsewhere and if it's not anywhere else used them update it to hard code checks instead of relying on a list of states:

Alive -> soft/hard/normal crit
Soft/hard/normal crit -> dead
Alive -> dead

And then send the appropriate notification.

Yeah agree. I can check where the rattle system is used elsewhere and if it's not anywhere else used them update it to hard code checks instead of relying on a list of states: * Alive -> soft/hard/normal crit * Soft/hard/normal crit -> dead * Alive -> dead And then send the appropriate notification.