Crouch system adjustments Version 2 #1068

Open
QuillTheCreature wants to merge 2 commits from QuillTheCreature/Byrd:systems/crouch/twobuttons into master
Member

Short description

This closes #1014 and fixes #1067.

I added two things:

  • An alternative crawling button which by default lets you go prone instantly but drops items
  • A toggle to swap both crawling button modes
  • A toggle to disable the "get up instantly by pressing the crawling button twice"

Why we need to add this

The toggle to disable the get up by pressing the crawling button twice is a discord request.

The addition of the alternative crawling button is the result of a vote.

I kept the old cvar in to switch crawling mode, and made it so it inverts the buttons:

  • So if it's on Pressing "Toggle Crawling" would let you go prone instantly with dropping items and pressing "Alternative Crawling" would make you go prone in a second.
  • I've kept this toggle so players don't need to re-do their keybinds with this change, and also don't need to mess up keybinds for other servers.

Media (Video/Screenshots)

image

Checklist

Ingame Changelog

🆑 Quill

  • add: Added a controls toggle option to disable the "get up instantly by pressing the crawl button twice".
  • add: Added an alternative crawling mode keybind which allows you to go down instantly but drop held items.
  • add: Added a controls toggle to swap crawling mode keybinds (So normal is now alternative and alternative is now normal).
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description This closes #1014 and fixes #1067. I added two things: * An alternative crawling button which by default lets you go prone instantly but drops items * A toggle to swap both crawling button modes * A toggle to disable the "get up instantly by pressing the crawling button twice" ## Why we need to add this The toggle to disable the get up by pressing the crawling button twice is a discord request. The addition of the alternative crawling button is the result of a vote. I kept the old cvar in to switch crawling mode, and made it so it inverts the buttons: * So if it's on Pressing "Toggle Crawling" would let you go prone instantly with dropping items and pressing "Alternative Crawling" would make you go prone in a second. * I've kept this toggle so players don't need to re-do their keybinds with this change, and also don't need to mess up keybinds for other servers. ## Media (Video/Screenshots) ![image](/attachments/deabde52-e33a-479c-a1e5-76423b3150ba) ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - add: Added a controls toggle option to disable the "get up instantly by pressing the crawl button twice". - add: Added an alternative crawling mode keybind which allows you to go down instantly but drop held items. - add: Added a controls toggle to swap crawling mode keybinds (So normal is now alternative and alternative is now normal).
Added a second crawling hotkey to go down instantly and drop items
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Failing after 3s
CRLF Check / CRLF Check (pull_request) Successful in 34s
Test Packaging / Test Packaging (pull_request) Successful in 13m34s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 39s
RSI Validator / Validate RSIs (pull_request) Successful in 42s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m31s
YAML Linter / YAML Linter (pull_request) Failing after 4m55s
cc36f6db8b
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Failing after 3s
CRLF Check / CRLF Check (pull_request) Successful in 34s
Test Packaging / Test Packaging (pull_request) Successful in 13m34s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 39s
RSI Validator / Validate RSIs (pull_request) Successful in 42s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m31s
YAML Linter / YAML Linter (pull_request) Failing after 4m55s
This pull request has changes conflicting with the target branch.
  • Content.Shared/CCVar/CCVars.Byrd.cs
  • Resources/Locale/en-US/_Byrd/escape-menu/ui/options-menu.ftl
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u "systems/crouch/twobuttons:QuillTheCreature-systems/crouch/twobuttons"
git switch "QuillTheCreature-systems/crouch/twobuttons"
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!1068
No description provided.