German accent update #1084

Open
QuillTheCreature wants to merge 1 commit from QuillTheCreature/Byrd:systems/traits/germanrework into master
Member

Short description

Updated the word replacements for the German accent, containing more words commonly used during play and some corrections.

Also, removed the random umlauts because they don't make sense.

Cherry pick of https://github.com/ProjectOmu/OmuStation/pull/1358

Why we need to add this

The current word replacement list for German contains a lot of words that rarely come up in play, while also missing many words that are likely to come up. I think it's disappointing.

Media (Video/Screenshots)

image

Checklist

Ingame Changelog

🆑 Quill

  • add: Updated the word replacement list for the German accent; it now contains more common words.
  • remove: Removed random umlauts from the German accent.
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Updated the word replacements for the German accent, containing more words commonly used during play and some corrections. Also, removed the random umlauts because they don't make sense. Cherry pick of https://github.com/ProjectOmu/OmuStation/pull/1358 ## Why we need to add this The current word replacement list for German contains a lot of words that rarely come up in play, while also missing many words that are likely to come up. I think it's disappointing. ## Media (Video/Screenshots) ![image](/attachments/eead3b22-1ddf-4e7a-ad58-5bfcf6d5e2c7) ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - add: Updated the word replacement list for the German accent; it now contains more common words. - remove: Removed random umlauts from the German accent.
German accent update (#1358)
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Failing after 4s
CRLF Check / CRLF Check (pull_request) Successful in 36s
Test Packaging / Test Packaging (pull_request) Successful in 14m45s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 44s
RSI Validator / Validate RSIs (pull_request) Successful in 45s
Map file schema validator / YAML map schema validator (pull_request) Successful in 6m48s
YAML Linter / YAML Linter (pull_request) Successful in 5m34s
c13280fd21
* create new word replacement list, adjust word_replacements.yml

* replaced old file, corrected errors, more profanity

* add Omu comments to word_replacements.yml

* un-deleted the old german.ftl file, commented it all out instead

* reorganized word replacements, un-touched old file

* i said, un-touched old file

* second attempt

* the one Omu comment i missed

* get rid of the random umlauts

* Add Omu end comment

* missing Omu comment

---------

Co-authored-by: Phosphate <sansundertalefeet@gmail.com>
Co-authored-by: NotActuallyMarty <27968892+NotActuallyMarty@users.noreply.github.com>
Co-authored-by: feistyfedora <12000170+feistyfedora@users.noreply.github.com>

(cherry picked from commit bde0e0a05eff99df221db3f8d7dd3445d101de1a)
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Failing after 4s
CRLF Check / CRLF Check (pull_request) Successful in 36s
Test Packaging / Test Packaging (pull_request) Successful in 14m45s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 44s
RSI Validator / Validate RSIs (pull_request) Successful in 45s
Map file schema validator / YAML map schema validator (pull_request) Successful in 6m48s
YAML Linter / YAML Linter (pull_request) Successful in 5m34s
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u "systems/traits/germanrework:QuillTheCreature-systems/traits/germanrework"
git switch "QuillTheCreature-systems/traits/germanrework"
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!1084
No description provided.