Byrd-Station/Byrd

Watch

Fork 22

Lowercased time transfer command string to "allow uppercase" time units as well. #1085

Merged

EchoOfNothing merged 1 commit from QuillTheCreature/Byrd:systems/timetransfer/allowuppercaseletters into master

2026-10-24 12:24:37 +00:00

QuillTheCreature commented

2026-10-18 17:55:15 +00:00

Member

Short description

Allowed "uppercase" time units in the time transfer panel being properly parsed.

Why we need to add this

Some admins cough messed up by writing for example "10H 20M" into the time transfer panel which didn't work and gave that player 0 minutes in that role.

This fixes it by just lowercasing the time units string.

Checklist

I do not require assistance to complete the PR.
I have verified that the changes work before posting/requesting review of my PR.
I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
I have read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset.

Ingame Changelog

🆑 Quill
ADMIN:

tweak: Time transfers with uppercase time units are now supported. Now you can write "10H 20M" and it'll work.

[guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Allowed "uppercase" time units in the time transfer panel being properly parsed. ## Why we need to add this Some admins *cough* messed up by writing for example "10H 20M" into the time transfer panel which didn't work and gave that player 0 minutes in that role. This fixes it by just lowercasing the time units string. ## Checklist  - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill *ADMIN:* - tweak: Time transfers with uppercase time units are now supported. Now you can write "10H 20M" and it'll work.

QuillTheCreature added 1 commit

2026-10-18 17:55:15 +00:00

Lowercased time transfer command string to "allow uppercase" time units as well.

Close PRs on master / run (pull_request_target) Has been skipped

Details

Labels: PR / labeler (pull_request_target) Successful in 48s

Details

Labels: Size / size-label (pull_request_target) Failing after 4s

Details

CRLF Check / CRLF Check (pull_request) Successful in 40s

Details

Test Packaging / Test Packaging (pull_request) Successful in 15m43s

Details

RGA schema validator / YAML RGA schema validator (pull_request) Successful in 48s

Details

RSI Validator / Validate RSIs (pull_request) Successful in 51s

Details

Map file schema validator / YAML map schema validator (pull_request) Successful in 6m45s

Details

YAML Linter / YAML Linter (pull_request) Successful in 5m33s

Details

PR Changelogs / changelog (pull_request_target) Successful in 59s

Details

3f031448fd

QuillTheCreature added the

labels

2026-10-22 19:26:04 +00:00

EchoOfNothing commented

2026-10-24 10:09:05 +00:00

Owner

I think this change could use a change log entry in the *ADMIN:* category.

I think this change could use a change log entry in the `*ADMIN:*` category.

👍 1

QuillTheCreature commented

2026-10-24 12:17:20 +00:00

Author

Member

@EchoOfNothing wrote in #1085 (comment):

I think this change could use a change log entry in the *ADMIN:* category.

Alright, I did not know those work here, done.

@EchoOfNothing wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/1085#issuecomment-9604: > I think this change could use a change log entry in the `*ADMIN:*` category. Alright, I did not know those work here, done.

EchoOfNothing approved these changes

2026-10-24 12:24:15 +00:00

EchoOfNothing left a comment