Fixing brigs, atmos, and more across maps #1089

Open
orangeAlligator wants to merge 35 commits from orangeAlligator/Byrd:the-briggening into master
Contributor

Short description

A few things; one, making all brigs accessible via turnstile instead of airlock, in the wake of pen-screwdrivers. Two, going over some outdated atmos designs, and primping them up. Three, ensuring armories contain both contraband and implanter crates. Four, other random tiny bullshit, with a focus on security and engineering departments. Also removing cloning. It's a lot of things.

Why we need to add this

I hope these changes address a few pain points that have grown over time, and use more modern features on outdated maps (like actual prisoner lockers and inlet pressure regulators.) As a side effect, all maps in the pool at the time of this PR will be under _Byrd, picking up the last couple stragglers from _Omu and all. Except Gate. Gate's getting its own PR.

Media (Video/Screenshots)

Attached some of the more prominent brig changes! It would be silly to try and get screenshots of all the tiny adjustments, but a few things got resized/moved around enough to feel notable. (In order, Cluster, Atlas, Saltern, Leonid)

Checklist

Breaking changes

Ingame Changelog

🆑
Maps:

  • add: Lots of stations: Added electric ranges

  • add: Lots of stations: Departmental communications computers!

  • add: Lots of stations: Psychologist locker added

  • add: Amber: New washing machine in the washroom!

  • add: Oasis: Finally unpacked the service techfab, turns out we had it in the back the whole time

  • add: Omega: New smartfridge for chemistry

  • add: Flagship: Emergency lights, and a couple more drobes

  • fix: Lots of stations: The TEG has been improved for inlines + delta pressure, some pipes repainted, general atmos primping

  • fix: Kettle, Chloris: Botany's smartfridge is the correct prototype

  • fix: Amber: The CC room is powered now

  • fix: Box: CMO locker is the right one now

  • fix: Box: Directional buttons face the right way, and are labeled

  • fix: Core: Chefs no longer try to spawn inside the deep fryer

  • fix: Saltern: Viro's doors are the right access

  • fix: Glacier, Shoukou: HoS has all their appropriate lockers (you have your duty case back!)

  • fix: Northway: The cryotube is hooked up correctly

  • fix: Flagship: The mailing units are set up correctly

  • tweak: All stations: Armories and brigs are brought up to date, and now include a tracking + contraband crate

  • tweak: Lots of stations: More chemist lockers

  • tweak: Bagel, Oasis: The SM and TEG are disentangled

  • tweak: Bagel: The goat no longer spawns inside the freezer

  • tweak: Saltern, Glacier: Lighting improvements!

  • tweak: Glacier: Moved medical's smartfridge

  • tweak: Finch: Cleaner and dirtier at the same time (replaced dirty tiles with more actual dirt)

  • tweak: Shoukou: Made engi give the material silo back to cargo

  • remove: Lots of stations: No more mapped cloning

  • remove: Atlas, Shoukou: Departmental ID computers are gone

<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description A few things; one, making all brigs accessible via turnstile instead of airlock, in the wake of pen-screwdrivers. Two, going over some outdated atmos designs, and primping them up. Three, ensuring armories contain both contraband and implanter crates. Four, other random tiny bullshit, with a focus on security and engineering departments. Also removing cloning. It's a lot of things. ## Why we need to add this I hope these changes address a few pain points that have grown over time, and use more modern features on outdated maps (like actual prisoner lockers and inlet pressure regulators.) As a side effect, all maps in the pool at the time of this PR will be under `_Byrd`, picking up the last couple stragglers from `_Omu` and all. Except Gate. Gate's getting its own PR. ## Media (Video/Screenshots) Attached some of the more prominent brig changes! It would be silly to try and get screenshots of all the tiny adjustments, but a few things got resized/moved around enough to feel notable. (In order, Cluster, Atlas, Saltern, Leonid) ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] I have verified that the changes work before posting/requesting review of my PR. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> ### Ingame Changelog :cl: **Maps:** - add: Lots of stations: Added electric ranges - add: Lots of stations: Departmental communications computers! - add: Lots of stations: Psychologist locker added - add: Amber: New washing machine in the washroom! - add: Oasis: Finally unpacked the service techfab, turns out we had it in the back the whole time - add: Omega: New smartfridge for chemistry - add: Flagship: Emergency lights, and a couple more drobes - fix: Lots of stations: The TEG has been improved for inlines + delta pressure, some pipes repainted, general atmos primping - fix: Kettle, Chloris: Botany's smartfridge is the correct prototype - fix: Amber: The CC room is powered now - fix: Box: CMO locker is the right one now - fix: Box: Directional buttons face the right way, and are labeled - fix: Core: Chefs no longer try to spawn inside the deep fryer - fix: Saltern: Viro's doors are the right access - fix: Glacier, Shoukou: HoS has all their appropriate lockers (you have your duty case back!) - fix: Northway: The cryotube is hooked up correctly - fix: Flagship: The mailing units are set up correctly - tweak: All stations: Armories and brigs are brought up to date, and now include a tracking + contraband crate - tweak: Lots of stations: More chemist lockers - tweak: Bagel, Oasis: The SM and TEG are disentangled - tweak: Bagel: The goat no longer spawns inside the freezer - tweak: Saltern, Glacier: Lighting improvements! - tweak: Glacier: Moved medical's smartfridge - tweak: Finch: Cleaner and dirtier at the same time (replaced dirty tiles with more actual dirt) - tweak: Shoukou: Made engi give the material silo back to cargo - remove: Lots of stations: No more mapped cloning - remove: Atlas, Shoukou: Departmental ID computers are gone
amber laundry + teg fix added, bagel's briggening done
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 49s
Labels: Size / size-label (pull_request_target) Failing after 3s
RSI Validator / Validate RSIs (pull_request) Successful in 43s
fd11bdbfb1
more bagel lights + removed cloning
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 5s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 42s
25229a6fc5
atlas briggening, moves hos, rearranges armory, fixes teg, etc
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 52s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 44s
bd38d9f74e
box update real
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 46s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 43s
acc6aefb18
finishing cog oops (atmos edition)
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 5s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 1m8s
7b5cb345bf
fland all at once
Some checks failed
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Failing after 1m39s
b69454571a
marathon added
Some checks failed
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Has been cancelled
Labels: Size / size-label (pull_request_target) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
bf5cc39e4e
the loop commit
Some checks failed
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Has been cancelled
Labels: Size / size-label (pull_request_target) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
f895742784
commit that adds a bucket to meta's brig
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 38s
f530ad5cef
packed and saltern
Some checks failed
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Has been cancelled
Labels: Size / size-label (pull_request_target) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
7a16369aa1
Member

Changelog needs - on every line at the beginning.

You have:

🆑
Maps:
add: Amber: New washing machine in the washroom!
fix: Amber: The TEG has been improved for inlines + delta pressure
tweak: Amber: Slightly nicer brig

It should be:

🆑
Maps:

  • add: Amber: New washing machine in the washroom!
  • fix: Amber: The TEG has been improved for inlines + delta pressure
  • tweak: Amber: Slightly nicer brig
Changelog needs `- ` on every line at the beginning. You have: 🆑 Maps: add: Amber: New washing machine in the washroom! fix: Amber: The TEG has been improved for inlines + delta pressure tweak: Amber: Slightly nicer brig It should be: 🆑 Maps: - add: Amber: New washing machine in the washroom! - fix: Amber: The TEG has been improved for inlines + delta pressure - tweak: Amber: Slightly nicer brig
adds train
Some checks failed
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Has been cancelled
Labels: Size / size-label (pull_request_target) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
b286a1fe69
adds kettle + namespacing
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 7s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 42s
03bfcf73b8
leonid added
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 5s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 38s
9f8540beaa
Author
Contributor

thank you!!
would it be better to consolidate the whole list? instead of a bunch of entries for the same thing, smthn like

  • fix: amber, atlas, packed, leonid: shot the clown
thank you!! would it be better to consolidate the whole list? instead of a bunch of entries for the same thing, smthn like - fix: amber, atlas, packed, leonid: shot the clown
delta added
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 40s
0360bfd955
chloris added + namespace
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 52s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 40s
c8da2b1b52
Member

@orangeAlligator wrote in #1089 (comment):

thank you!! would it be better to consolidate the whole list? instead of a bunch of entries for the same thing, smthn like

* fix: amber, atlas, packed, leonid: shot the clown

Yes if you fix one thing in multiple stations write it on the same line like you suggested. You can also use "For many stations" or "For all stations" if it's too many: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html#map-changelog

@orangeAlligator wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/1089#issuecomment-9560: > thank you!! would it be better to consolidate the whole list? instead of a bunch of entries for the same thing, smthn like > > * fix: amber, atlas, packed, leonid: shot the clown Yes if you fix one thing in multiple stations write it on the same line like you suggested. You can also use "For many stations" or "For all stations" if it's too many: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html#map-changelog
adds finch
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 52s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 42s
968b40c1fe
adds shoukou
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 53s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 42s
1cf2fb3411
flagship added
All checks were successful
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 52s
Labels: Size / size-label (pull_request_target) Successful in 3s
RSI Validator / Validate RSIs (pull_request) Successful in 43s
ddc75aa486
orangeAlligator changed title from WIP: Fixing brigs, atmos, and more across maps to Fixing brigs, atmos, and more across maps 2026-10-23 21:24:46 +00:00
Author
Contributor

FUCK i tried to fix up shoukou so they'd match
time to regular fix it

FUCK i tried to fix up shoukou so they'd match time to regular fix it
no review yet i can keep adding things: omega has a smartfridge now
Some checks failed
Labels: PR / labeler (pull_request_target) Has been cancelled
Labels: Size / size-label (pull_request_target) Has been cancelled
CRLF Check / CRLF Check (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
f70a282b8e
giving shoukou botany a biogenerator
Some checks failed
Labels: PR / labeler (pull_request_target) Has been cancelled
Labels: Size / size-label (pull_request_target) Has been cancelled
CRLF Check / CRLF Check (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
81eb056f36
Some checks failed
Labels: PR / labeler (pull_request_target) Has been cancelled
Labels: Size / size-label (pull_request_target) Has been cancelled
CRLF Check / CRLF Check (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
This pull request has changes conflicting with the target branch.
  • Resources/Maps/_Byrd/shoukou.yml
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u "the-briggening:orangeAlligator-the-briggening"
git switch "orangeAlligator-the-briggening"
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!1089
No description provided.