Removing Ore Tag from Processed BS crystals #1091

Merged
QuillTheCreature merged 7 commits from Balenar/Byrd:BluespaceCrystalsAreNotAnOre into master 2026-10-27 19:05:31 +00:00
Contributor

Short description

removing the ore tag from processed Bluespace Crystals so they can no longer fit into ore bags as well as a nerf to unprocessed Bluespace teleporting

Why we need to add this

A ore bag of holding of bluespace crystals can make it exceptionally difficult to chase a troublemaker and a competent salvage can get HUNDREDS. restricting them to their normal bag size limits but doesn't fully remove this shenanigan and it's inconsistent to have a processed ingot go into ore bags anyway, then unprocessed teleportation is made substantially weaker to avoid using unprocessed crystals for the same purpose

Checklist

Ingame Changelog

🆑 Balenar

  • tweak: Processed Bluespace Crystals can no longer go into ore bags
  • tweak: Unprocessed Bluespace Crystal teleporting is weaker
  • tweak: Bluespace Crystals now have a 3 second cooldown on use and make noise when being crushed
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description <!-- What do you propose to change with your PR? --> removing the ore tag from processed Bluespace Crystals so they can no longer fit into ore bags as well as a nerf to unprocessed Bluespace teleporting ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> A ore bag of holding of bluespace crystals can make it exceptionally difficult to chase a troublemaker and a competent salvage can get HUNDREDS. restricting them to their normal bag size limits but doesn't fully remove this shenanigan and it's inconsistent to have a processed ingot go into ore bags anyway, then unprocessed teleportation is made substantially weaker to avoid using unprocessed crystals for the same purpose ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] I have verified that the changes work before posting/requesting review of my PR. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog <!--If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative.--> :cl: Balenar - tweak: Processed Bluespace Crystals can no longer go into ore bags - tweak: Unprocessed Bluespace Crystal teleporting is weaker - tweak: Bluespace Crystals now have a 3 second cooldown on use and make noise when being crushed
Merge remote-tracking branch 'origin/BluespaceCrystalsAreNotAnOre' into BluespaceCrystalsAreNotAnOre
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 46s
Labels: Size / size-label (pull_request_target) Failing after 3s
CRLF Check / CRLF Check (pull_request) Successful in 37s
Test Packaging / Test Packaging (pull_request) Successful in 13m41s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 51s
RSI Validator / Validate RSIs (pull_request) Successful in 44s
Map file schema validator / YAML map schema validator (pull_request) Successful in 6m12s
YAML Linter / YAML Linter (pull_request) Successful in 5m45s
9620ccf4ca
# Conflicts:
#	Resources/Prototypes/_Goobstation/Entities/Objects/Materials/materials.yml
Readding comments
All checks were successful
Labels: PR / labeler (pull_request_target) Successful in 5s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 34s
Test Packaging / Test Packaging (pull_request) Successful in 14m24s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 47s
RSI Validator / Validate RSIs (pull_request) Successful in 45s
Map file schema validator / YAML map schema validator (pull_request) Successful in 6m12s
YAML Linter / YAML Linter (pull_request) Successful in 5m3s
41a2dd7c7f
Member

--🆑 Balenar

Changelog line is messed up, please update it.

> --🆑 Balenar Changelog line is messed up, please update it.
QuillTheCreature left a comment

Looks good.

Looks good.
Author
Contributor

@QuillTheCreature wrote in #1091 (comment):

--🆑 Balenar

Changelog line is messed up, please update it.

Fixed! forgor removing the -- from the comment

@QuillTheCreature wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/1091#issuecomment-9297: > > --:cl: Balenar > > Changelog line is messed up, please update it. Fixed! forgor removing the -- from the comment
Member

Hey there!

Thank you for your contribution.

This passed staff vote, however please do two changes:

  • Change the teleport to min 1, max 2 on the unprocessed crystal.
  • Add a 5 3 second cooldown to both.
Hey there! Thank you for your contribution. This passed staff vote, however please do two changes: * Change the teleport to min 1, max 2 on the unprocessed crystal. * Add a ~~5~~ 3 second cooldown to both.
Author
Contributor

@QuillTheCreature wrote in #1091 (comment):

Hey there!

Thank you for your contribution.

This passed staff vote, however please do two changes:

* Change the teleport to min 1, max 2 on the unprocessed crystal.

* Add a 5 second cooldown to both.

I am MORE than happy to see about nerfing the bluespace crystals further! haven't touched cooldowns yet though so will take a second!

@QuillTheCreature wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/1091#issuecomment-9580: > Hey there! > > Thank you for your contribution. > > This passed staff vote, however please do two changes: > > * Change the teleport to min 1, max 2 on the unprocessed crystal. > > * Add a 5 second cooldown to both. I am MORE than happy to see about nerfing the bluespace crystals further! haven't touched cooldowns yet though so will take a second!
Author
Contributor

@QuillTheCreature wrote in #1091 (comment):

Hey there!

Thank you for your contribution.

This passed staff vote, however please do two changes:

* Change the teleport to min 1, max 2 on the unprocessed crystal.

* Add a ~5~ 3 second cooldown to both.

okay so, apparently "RandomTeleportOnUse" isn't the best coded and doesn't actually use the item for the purposes of UseDelay, so to get around that I'm also giving crushing the crystal a sound effect

@QuillTheCreature wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/1091#issuecomment-9580: > Hey there! > > Thank you for your contribution. > > This passed staff vote, however please do two changes: > > * Change the teleport to min 1, max 2 on the unprocessed crystal. > > * Add a ~5~ 3 second cooldown to both. okay so, apparently "RandomTeleportOnUse" isn't the best coded and doesn't actually use the item for the purposes of UseDelay, so to get around that I'm also giving crushing the crystal a sound effect
Adding a sound effect and cooldown to using a bluespace crystal
All checks were successful
Labels: PR / labeler (pull_request_target) Successful in 7s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 38s
Test Packaging / Test Packaging (pull_request) Successful in 15m17s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 38s
RSI Validator / Validate RSIs (pull_request) Successful in 39s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m58s
YAML Linter / YAML Linter (pull_request) Successful in 4m33s
PR Changelogs / changelog (pull_request_target) Successful in 58s
8b0bfeedad
Member

There's a debug error getting thrown when interacting with crystals in both hands, but that's present on master too so it's unrelated to this PR.

[FATL] unhandled: Robust.Shared.Utility.DebugAssertException: Exception of type 'Robust.Shared.Utility.DebugAssertException' was thrown.
   at Robust.Shared.Utility.DebugTools.Assert(Boolean condition) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/RobustToolbox/Robust.Shared/Utility/DebugTools.cs:line 37
   at Content.Shared.Interaction.SharedInteractionSystem.UseInHandInteraction(EntityUid user, EntityUid used, Boolean checkCanUse, Boolean checkCanInteract, Boolean checkUseDelay) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/Content.Shared/Interaction/SharedInteractionSystem.cs:line 1247
   at Content.Shared.Hands.EntitySystems.SharedHandsSystem.TryUseItemInHand(EntityUid uid, Boolean altInteract, HandsComponent handsComp, String handName) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/Content.Shared/Hands/EntitySystems/SharedHandsSystem.Interactions.cs:line 204
   at Content.Shared.Hands.EntitySystems.SharedHandsSystem.HandleUseItem(ICommonSession session) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/Content.Shared/Hands/EntitySystems/SharedHandsSystem.Interactions.cs:line 50
   at Robust.Shared.Input.Binding.InputCmdHandler.StateInputCmdHandler.Enabled(ICommonSession session) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/RobustToolbox/Robust.Shared/Input/Binding/InputCmdHandler.cs:line 52
   at Robust.Shared.Input.Binding.InputCmdHandler.StateInputCmdHandler.HandleCmdMessage(IEntityManager entManager, ICommonSession session, IFullInputCmdMessage message) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/RobustToolbox/Robust.Shared/Input/Binding/InputCmdHandler.cs:line 68
There's a debug error getting thrown when interacting with crystals in both hands, but that's present on master too so it's unrelated to this PR. ``` [FATL] unhandled: Robust.Shared.Utility.DebugAssertException: Exception of type 'Robust.Shared.Utility.DebugAssertException' was thrown. at Robust.Shared.Utility.DebugTools.Assert(Boolean condition) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/RobustToolbox/Robust.Shared/Utility/DebugTools.cs:line 37 at Content.Shared.Interaction.SharedInteractionSystem.UseInHandInteraction(EntityUid user, EntityUid used, Boolean checkCanUse, Boolean checkCanInteract, Boolean checkUseDelay) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/Content.Shared/Interaction/SharedInteractionSystem.cs:line 1247 at Content.Shared.Hands.EntitySystems.SharedHandsSystem.TryUseItemInHand(EntityUid uid, Boolean altInteract, HandsComponent handsComp, String handName) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/Content.Shared/Hands/EntitySystems/SharedHandsSystem.Interactions.cs:line 204 at Content.Shared.Hands.EntitySystems.SharedHandsSystem.HandleUseItem(ICommonSession session) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/Content.Shared/Hands/EntitySystems/SharedHandsSystem.Interactions.cs:line 50 at Robust.Shared.Input.Binding.InputCmdHandler.StateInputCmdHandler.Enabled(ICommonSession session) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/RobustToolbox/Robust.Shared/Input/Binding/InputCmdHandler.cs:line 52 at Robust.Shared.Input.Binding.InputCmdHandler.StateInputCmdHandler.HandleCmdMessage(IEntityManager entManager, ICommonSession session, IFullInputCmdMessage message) in /home/quill/Documents/Workspace/quill/SpaceStation14/ByrdStation/RobustToolbox/Robust.Shared/Input/Binding/InputCmdHandler.cs:line 68 ```
byrdbot referenced this pull request from a commit 2026-10-27 19:06:30 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!1091
No description provided.