Remove Sleeping Carp #1111

Open
cometvoid wants to merge 3 commits from cometvoid/Byrd:KillScarp into master
Contributor

Short description

Removes sleeping carp scroll from the uplink, the random syndie loot spawner entity, and the undetermined carp kit
The undetermined carp kit gets a carp caller to make up for the loss of the carp scroll

Why we need to add this

I have only heard complaints about martial arts, especially scarp as of late. So i commented it out.

Checklist

Breaking changes

Ingame Changelog

🆑

  • remove: Removed sleeping carp scroll from the uplink
  • tweak: Replaced sleeping carp scroll in the undetermined carp kit bundle with a carp caller.
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description <!-- What do you propose to change with your PR? --> Removes sleeping carp scroll from the uplink, the random syndie loot spawner entity, and the undetermined carp kit The undetermined carp kit gets a carp caller to make up for the loss of the carp scroll ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> I have only heard complaints about martial arts, especially scarp as of late. So i commented it out. ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [ x ] I do not require assistance to complete the PR. - [ x ] I have verified that the changes work before posting/requesting review of my PR. - [ x ] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [ x ] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> ### Ingame Changelog <!--If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative.--> <!--:cl: - add: Added fun! - remove: Removed fun! - tweak: Changed fun! - fix: Fixed fun!--> :cl: - remove: Removed sleeping carp scroll from the uplink - tweak: Replaced sleeping carp scroll in the undetermined carp kit bundle with a carp caller.
adds carp caller to carp set to make up for losing the carp scroll
All checks were successful
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 49s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 34s
Test Packaging / Test Packaging (pull_request) Successful in 12m29s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 43s
RSI Validator / Validate RSIs (pull_request) Successful in 40s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m11s
YAML Linter / YAML Linter (pull_request) Successful in 4m29s
94ec14df03
All checks were successful
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 49s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 34s
Test Packaging / Test Packaging (pull_request) Successful in 12m29s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 43s
RSI Validator / Validate RSIs (pull_request) Successful in 40s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m11s
YAML Linter / YAML Linter (pull_request) Successful in 4m29s
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u "KillScarp:cometvoid-KillScarp"
git switch "cometvoid-KillScarp"
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!1111
No description provided.