Winter Coats Resprite #1119

Open
Squirrelx3 wants to merge 3 commits from Squirrelx3/SquirrelByrd:master into master
First-time contributor

Coats resprite!!!

Short description

Recolor/resprite of some of the winter coats.

Why we need to add this

The default tan colors on the colored coats's trims and coloring of the other coats are visually displeasing and do not go well with other accessories. The SS13 winter coats sprites of some of the coats are also way better than the wizden sprites.

Media (Video/Screenshots)

image

Checklist

Breaking changes

Ingame Changelog

🆑

  • tweak: Changed trim color of colored, bartender, roboticist and syndicates winter coats aswell as the winter boots.
  • tweak: Changed the hop, qm, rd and base winter coats to their SS13 sprites.
Coats resprite!!! <!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Recolor/resprite of some of the winter coats. ## Why we need to add this The default tan colors on the colored coats's trims and coloring of the other coats are visually displeasing and do not go well with other accessories. The SS13 winter coats sprites of some of the coats are also way better than the wizden sprites. ## Media (Video/Screenshots) ![image](/attachments/dab07b64-5a45-42dc-a3aa-64313c770ef2) ## Checklist - [X] I do not require assistance to complete the PR. - [X] I have verified that the changes work before posting/requesting review of my PR. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> ### Ingame Changelog :cl: - tweak: Changed trim color of colored, bartender, roboticist and syndicates winter coats aswell as the winter boots. - tweak: Changed the hop, qm, rd and base winter coats to their SS13 sprites.
Mass Coats Resprite Bounty
Some checks failed
Close PRs on master / run (pull_request_target) Successful in 5s
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 36s
Diff RSIs / Diff (pull_request) Failing after 11s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 40s
RSI Validator / Validate RSIs (pull_request) Successful in 40s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m56s
YAML Linter / YAML Linter (pull_request) Failing after 1m11s
d7299cd5ab
Coats resprite!!!
QuillTheCreature left a comment

Hey there!
Thank you for your first time contribution!

Two things:

  • You committed a couple unrelated package.lock.json files, please remove those.
  • Please edit every rsi's meta.json file to include from where you got the sprites from. Giving proper credits is important. :)
Hey there! Thank you for your first time contribution! Two things: * You committed a couple unrelated `package.lock.json` files, please remove those. * Please edit every `rsi`'s `meta.json` file to include from where you got the sprites from. Giving proper credits is important. :)

Thank you for contributing to the Byrd Station repository. Unfortunately, it looks like you submitted your pull request from the master branch. We suggest you follow our git usage documentation

You can move your current work from the master branch to another branch by doing git branch <branch_name and resetting the master branch.

This pr won't be automatically closed. However, a maintainer may close it for this reason.

Thank you for contributing to the Byrd Station repository. Unfortunately, it looks like you submitted your pull request from the master branch. We suggest you follow [our git usage documentation](https://docs.spacestation14.com/en/general-development/setup/git-for-the-ss14-developer.html) You can move your current work from the master branch to another branch by doing `git branch <branch_name` and resetting the master branch. This pr won't be automatically closed. However, a maintainer may close it for this reason.
This reverts commit d7299cd5ab.
Winter Coats Commit Fix
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 5s
Labels: Size / size-label (pull_request_target) Successful in 2s
CRLF Check / CRLF Check (pull_request) Has been cancelled
Diff RSIs / Diff (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
261bf6fddc
- Removed the package.lock.json
- Added credits in the meta.json
Author
First-time contributor

@QuillTheCreature wrote in #1119 (comment):

Hey there! Thank you for your first time contribution!

Two things:

* You committed a couple unrelated `package.lock.json` files, please remove those.

* Please edit every `rsi`'s `meta.json` file to include from where you got the sprites from. Giving proper credits is important. :)

Done! Thank you for the feedback!

@QuillTheCreature wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/1119#issuecomment-9717: > Hey there! Thank you for your first time contribution! > > Two things: > > * You committed a couple unrelated `package.lock.json` files, please remove those. > > * Please edit every `rsi`'s `meta.json` file to include from where you got the sprites from. Giving proper credits is important. :) Done! Thank you for the feedback!
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 5s
Labels: Size / size-label (pull_request_target) Successful in 2s
CRLF Check / CRLF Check (pull_request) Has been cancelled
Diff RSIs / Diff (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u "master:Squirrelx3-master"
git switch "Squirrelx3-master"
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!1119
No description provided.