Make station radio sound global #233

Merged

LilithArson merged 5 commits from global-radio-20260519 into master 2026-05-19 19:31:36 +00:00

Conversation 2 Commits 5 Files changed 4 +151 -25

LilithArson commented 2026-05-19 09:55:48 +00:00

Owner

Copy link

PR Changes

The audio that the station radio plays is now global (like event music) - no more jittery audio when you use the volume slider!
Fixes #177, fixes #196

Reasons Behind Changes

Complaints of Radio volume being too loud to some users.

Code & Technical details

The previous volume system was a buggy mess, and the radio system even moreso.

Images; Sprites; Media

none

Checklist

• I read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset am following them.
• I have added media to this PR, or it does not require an ingame showcase.

Breaking changes

Ingame Changelog

🆑

• tweak: Station radio rig now plays sound globally on the station instead of being linked to the radio entities
• fix: Station radio volume slider now functions as it should

## PR Changes The audio that the station radio plays is now global (like event music) - no more jittery audio when you use the volume slider! Fixes #177, fixes #196 ## Reasons Behind Changes Complaints of Radio volume being too loud to some users. ## Code & Technical details The previous volume system was a buggy mess, and the radio system even moreso. ## Images; Sprites; Media none ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [x] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [x] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: - tweak: Station radio rig now plays sound globally on the station instead of being linked to the radio entities - fix: Station radio volume slider now functions as it should

LilithArson added 1 commit 2026-05-19 09:55:48 +00:00

Radio sound is now global, no more fucky audio when you use the volume slider :) a756cfbc36

forgejo-actions added the

size/M

label 2026-05-19 09:55:52 +00:00

byrdbot added 1 commit 2026-05-19 09:56:49 +00:00

chore: Automatically update REUSE headers 7dc3c7dd20

LilithArson added 1 commit 2026-05-19 09:56:51 +00:00

Remove debug logging calls b54410630c

LilithArson added 1 commit 2026-05-19 10:12:45 +00:00

Namespacing + don't filter events ... dac3db4091

Let lavaland players hear the radio, why not
Also, otherwise it won't stop the audio for players outside the station or start for players who just entered it

LukeZurg22 changed title from Make station radio sound global to WIP: Make station radio sound global 2026-05-19 10:18:22 +00:00

LukeZurg22 added the

invalid

Changes: Audio

labels 2026-05-19 10:18:22 +00:00

LukeZurg22 commented 2026-05-19 10:19:04 +00:00

Contributor

Copy link

Don't merge this yet. I would rather go through the codebase and attempt an implementation that doesn't feel as rushed and low quality as this one.

Don't merge this yet. I would rather go through the codebase and attempt an implementation that doesn't feel as rushed and low quality as this one.

LukeZurg22 requested review from LukeZurg22 2026-05-19 10:21:23 +00:00

LukeZurg22 self-assigned this 2026-05-19 10:21:31 +00:00

LilithArson added 1 commit 2026-05-19 10:53:41 +00:00

Remove dead code, only start playing for players on station. 1169ad4971

LilithArson removed the

invalid

Changes: Audio

labels 2026-05-19 13:54:06 +00:00

LilithArson changed title from WIP: Make station radio sound global to Make station radio sound global 2026-05-19 19:30:54 +00:00

LilithArson commented 2026-05-19 19:31:24 +00:00

Author

Owner

Copy link

Merging this for now pending further rework, this system is still infinitely better than what's currently available.

Merging this for now pending further rework, this system is still infinitely better than what's currently available.

LilithArson merged commit 29e11c21aa into master 2026-05-19 19:31:36 +00:00

LilithArson deleted branch global-radio-20260519 2026-05-19 19:31:37 +00:00

LilithArson referenced this pull request from a commit 2026-05-19 19:31:37 +00:00

Make station radio sound global (#233)

byrdbot referenced this pull request from a commit 2026-05-19 19:31:56 +00:00

Automatic changelog update (#233)

LilithArson referenced this pull request from a commit 2026-05-22 20:47:31 +00:00

Make station radio sound global (#233)

LilithArson referenced this pull request from a commit 2026-05-22 20:47:31 +00:00

Automatic changelog update (#233)

LilithArson referenced this pull request from a commit 2026-07-08 23:01:29 +00:00

Revert "Make station radio sound global (#233)"

LukeZurg22 referenced this pull request from a commit 2026-07-11 07:57:11 +00:00

Revert "Make station radio sound global (#233)"

LukeZurg22 referenced this pull request from a commit 2026-07-11 11:00:59 +00:00

Revert "Revert "Make station radio sound global (#233)""

Sign in to join this conversation.

Reviewers

No reviewers

LukeZurg22

Labels

Clear labels   

bug

This is in regards to a bug.

  

Changes: Audio

  

Changes: Map

  

Changes: No C#

  

Changes: Sprites

  

Changes: UI

  

documentation

Improvements or additions to documentation

  

DON'T MERGE

This is under review, fixes, or needs significant changes.

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

holding to vote

This is currently being voted for by the Byrds.

  

invalid

This doesn't seem right

  

question

Further information is requested

  

size/L

  

size/M

  

size/S

  

size/XL

  

size/XS

  

S: Merge Conflict

  

S: Untriaged

  

wontfix

This will not be worked on

No labels

bug

Changes: Audio

Changes: Map

Changes: No C#

Changes: Sprites

Changes: UI

documentation

DON'T MERGE

duplicate

enhancement

good first issue

help wanted

holding to vote

invalid

question

size/L

size/M

size/S

size/XL

size/XS

S: Merge Conflict

S: Untriaged

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

LukeZurg22

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Byrd-Station/Byrd!233

No description provided.