Byrd-Station/Byrd
Byrd-Station/Byrd
Watch
4
5
Fork
You've already forked Byrd
 22
Code Issues 33 Pull requests 35 Projects 1 Wiki Activity Actions 37

Make station radio sound global #233

Merged
LilithArson merged 5 commits from global-radio-20260519 into master 2026-05-19 19:31:36 +00:00
Conversation 2 Commits 5 Files changed 4 +151 -25
LilithArson commented 2026-05-19 09:55:48 +00:00
Owner

PR Changes

The audio that the station radio plays is now global (like event music) - no more jittery audio when you use the volume slider!
Fixes #177, fixes #196

Reasons Behind Changes

Complaints of Radio volume being too loud to some users.

Code & Technical details

The previous volume system was a buggy mess, and the radio system even moreso.

Images; Sprites; Media

none

Checklist

Breaking changes

Ingame Changelog

🆑

  • tweak: Station radio rig now plays sound globally on the station instead of being linked to the radio entities
  • fix: Station radio volume slider now functions as it should
## PR Changes The audio that the station radio plays is now global (like event music) - no more jittery audio when you use the volume slider! Fixes #177, fixes #196 ## Reasons Behind Changes Complaints of Radio volume being too loud to some users. ## Code & Technical details The previous volume system was a buggy mess, and the radio system even moreso. ## Images; Sprites; Media none ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [x] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [x] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: - tweak: Station radio rig now plays sound globally on the station instead of being linked to the radio entities - fix: Station radio volume slider now functions as it should
Radio sound is now global, no more fucky audio when you use the volume slider :)
Some checks failed
RSI Validator / Validate RSIs (pull_request) Waiting to run
Details
Map file schema validator / YAML map schema validator (pull_request) Waiting to run
Details
YAML Linter / YAML Linter (pull_request) Waiting to run
Details
Close PRs on master / run (pull_request_target) Has been skipped
Details
Labels: Size / size-label (pull_request_target) Successful in 4s
Details
Labels: PR / labeler (pull_request_target) Successful in 4s
Details
Labels: Untriaged / add_label (pull_request_target) Failing after 3s
Details
soft-repoban check / check-author (pull_request) Successful in 3s
Details
Check Merge Conflicts / label (pull_request_target) Successful in 16s
Details
CRLF Check / CRLF Check (pull_request) Successful in 17s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been cancelled
Details
Test Packaging / Test Packaging (pull_request) Has been cancelled
Details
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
Details
Update REUSE Headers / update_headers (pull_request_target) Has been cancelled
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been cancelled
Details
a756cfbc36
chore: Automatically update REUSE headers
Some checks are pending
Check Merge Conflicts / label (pull_request_target) Waiting to run
Details
Labels: PR / labeler (pull_request_target) Waiting to run
Details
Labels: Size / size-label (pull_request_target) Waiting to run
Details
Update REUSE Headers / update_headers (pull_request_target) Waiting to run
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Waiting to run
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Blocked by required conditions
Details
CRLF Check / CRLF Check (pull_request) Waiting to run
Details
Test Packaging / Test Packaging (pull_request) Waiting to run
Details
RGA schema validator / YAML RGA schema validator (pull_request) Waiting to run
Details
RSI Validator / Validate RSIs (pull_request) Waiting to run
Details
Map file schema validator / YAML map schema validator (pull_request) Waiting to run
Details
YAML Linter / YAML Linter (pull_request) Waiting to run
Details
7dc3c7dd20
Remove debug logging calls
All checks were successful
Labels: PR / labeler (pull_request_target) Successful in 2s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Check Merge Conflicts / label (pull_request_target) Successful in 17s
Details
CRLF Check / CRLF Check (pull_request) Successful in 17s
Details
Update REUSE Headers / update_headers (pull_request_target) Successful in 56s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 51s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 44s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 3m28s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 3s
Details
YAML Linter / YAML Linter (pull_request) Successful in 3m54s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m41s
Details
Test Packaging / Test Packaging (pull_request) Successful in 9m16s
Details
b54410630c
Namespacing + don't filter events
All checks were successful
Labels: Size / size-label (pull_request_target) Successful in 4s
Details
Labels: PR / labeler (pull_request_target) Successful in 4s
Details
Check Merge Conflicts / label (pull_request_target) Successful in 17s
Details
CRLF Check / CRLF Check (pull_request) Successful in 17s
Details
Update REUSE Headers / update_headers (pull_request_target) Successful in 49s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 40s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 38s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 3m38s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 4s
Details
YAML Linter / YAML Linter (pull_request) Successful in 3m34s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m21s
Details
Test Packaging / Test Packaging (pull_request) Successful in 8m1s
Details
dac3db4091
 
Let lavaland players hear the radio, why not
Also, otherwise it won't stop the audio for players outside the station or start for players who just entered it
LukeZurg22 changed title from Make station radio sound global to WIP: Make station radio sound global 2026-05-19 10:18:22 +00:00
LukeZurg22 commented 2026-05-19 10:19:04 +00:00
Contributor

Don't merge this yet. I would rather go through the codebase and attempt an implementation that doesn't feel as rushed and low quality as this one.

Don't merge this yet. I would rather go through the codebase and attempt an implementation that doesn't feel as rushed and low quality as this one.
Remove dead code, only start playing for players on station.
All checks were successful
Check Merge Conflicts / label (pull_request_target) Has been skipped
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been skipped
Details
Labels: Size / size-label (pull_request_target) Successful in 3s
Details
Labels: PR / labeler (pull_request_target) Successful in 3s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been skipped
Details
CRLF Check / CRLF Check (pull_request) Has been skipped
Details
Test Packaging / Test Packaging (pull_request) Has been skipped
Details
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
Details
YAML Linter / YAML Linter (pull_request) Has been skipped
Details
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
Details
RSI Validator / Validate RSIs (pull_request) Successful in 24s
Details
Update REUSE Headers / update_headers (pull_request_target) Successful in 43s
Details
PR Changelogs / changelog (pull_request_target) Successful in 21s
Details
1169ad4971
LilithArson changed title from WIP: Make station radio sound global to Make station radio sound global 2026-05-19 19:30:54 +00:00
LilithArson commented 2026-05-19 19:31:24 +00:00
Author
Owner

Merging this for now pending further rework, this system is still infinitely better than what's currently available.

Merging this for now pending further rework, this system is still infinitely better than what's currently available.
LilithArson deleted branch global-radio-20260519 2026-05-19 19:31:37 +00:00
byrdbot referenced this pull request from a commit 2026-05-19 19:31:56 +00:00
Automatic changelog update (#233)
LilithArson referenced this pull request from a commit 2026-05-22 20:47:31 +00:00
Automatic changelog update (#233)
Sign in to join this conversation.
Reviewers
No reviewers
LukeZurg22
Labels
Clear labels   
Area/Accessibility
Area: Accessibility settings and features.

  
Area/Admin Tooling
Area: Admin tooling and moderation

  
Area/Art
Area: Art with no implications for other areas.

  
Area/Atmospherics
Area: Atmospherics

  
Area/Cargo
Area: Cargo department and related mechanics

  
Area/Character / Species
Area: Player characters and species features and content.

  
Area/Chat
Area: Chat-related features and changes, most likely technical.

  
Area/Combat
Area: Combat features, changes, balancing.

  
Area/Command
Area: Command department, where it isn't applicable to other departments.

  
Area/Database
Area: Changes to Database code.

  
Area/Engineering
Area: Engineering department, doesn't include Atmospherics.

  
Area/Graphics
Area: Changes to shaders or overlays.

  
Area/Guidebook
Area: Ingame guidebook, content or technical implementation.

  
Area/Mapping
Area: Maps, or tools used for mapping

  
Area/Medical
Area: Medical department, including Chemistr

  
Area/Preferences / Options
Area: Player preferences and options.

  
Area/Roleplay / Lore
Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics

  
Area/Roundflow / Antag
Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities.

  
Area/Rules
Area: Changes to Server rules, SoP, or Space Law.

  
Area/Salvage
Area: Salvage changes

  
Area/Science
Area: Science department, not including Silicons.

  
Area/Security
Area: Security department, including Detectives, HoS

  
Area/Service
Area: Service department, including cooking, botany, etc

  
Area/Silicons
Area: Relates to Silicon roles, including AI.

  
bug
This is in regards to a bug.

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
DON'T MERGE
This is under review, fixes, or needs significant changes.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
Note/Port
A port from another repository.

  
Note/Upstream
A PR from upstream.

  
Priority
Critical
 Critical priority task!!

  
Priority
High
 High priority task

  
Priority
Low
 Low priority task

  
Priority
Normal
 Normal priority task

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
State/Approved
This PR has been approved.

  
State/invalid
This doesn't seem right

  
State/Merge Conflict

   
State/Needs Changes
Changes/Concerns have been brought up and should be made before review.

  
State/Needs Discussion
Discussion needed for changes, talk about it.

  
State/Untriaged

   
Type/Balance Change
Changes something in the game related to balancing.

  
Type/Bugfix
Fixes a known issue/bug.

  
Type/Documentation
Makes changes to documentation in the repository. This includes attributions changes.

  
Type/Enhancement
New feature or request, change to game.

  
Type/Feature
Adds completely new stuff to the game.

  
Type/Question
Further information is requested.

  
wontfix
This will not be worked on

No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
LukeZurg22
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!233
No description provided.