Byrd-Station/Byrd
5
3
Fork 17
Code Issues 33 Pull requests 5 Projects 2 Wiki Activity Actions 6

WIP: Removed Polyglot Trait & Set Language Traits to use Globalpoints #269

Draft
cometvoid wants to merge 3 commits from cometvoid/Byrd:languageTraitTweak into master
pull from: cometvoid/Byrd:languageTraitTweak
merge into: Byrd-Station:master
Conversation 4 Commits 3 Files changed 4 +30 -29
cometvoid commented 2026-05-22 21:25:14 +00:00
Contributor
Copy link

PR Changes

Comments out polyglot and makes languages use global points instead

Reasons Behind Changes

it makes more sense than being limited to an arbitrary amount of languages. also polyglot doesnt work anyways

Code & Technical details

yamlslop

Images; Sprites; Media

none

Checklist

Breaking changes

Ingame Changelog

🆑

  • remove: Removed polyglot
  • tweak: languages use global points and the amount you can have are no longer limited
## PR Changes Comments out polyglot and makes languages use global points instead ## Reasons Behind Changes it makes more sense than being limited to an arbitrary amount of languages. also polyglot doesnt work anyways ## Code & Technical details yamlslop ## Images; Sprites; Media none ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [X] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [x] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** :cl: - remove: Removed polyglot - tweak: languages use global points and the amount you can have are no longer limited
removes maxtraitpoints because we dont use them
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Check Merge Conflicts / label (pull_request_target) Failing after 12s
Details
Labels: PR / labeler (pull_request_target) Failing after 2s
Details
Labels: Size / size-label (pull_request_target) Failing after 1s
Details
Labels: Untriaged / add_label (pull_request_target) Failing after 1s
Details
Update REUSE Headers / update_headers (pull_request_target) Successful in 37s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m21s
Details
soft-repoban check / check-author (pull_request) Successful in 2s
Details
CRLF Check / CRLF Check (pull_request) Successful in 13s
Details
Test Packaging / Test Packaging (pull_request) Successful in 6m42s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 20s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 21s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 3m27s
Details
YAML Linter / YAML Linter (pull_request) Successful in 2m26s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 1s
Details
47e70abe2e
LukeZurg22 commented 2026-05-23 21:06:56 +00:00
Owner
Copy link

Didn't a number of people outright disagree with this in the discord, myself included, on the grounds this doesn't fix anything but instead makes languages way more costly than they used to be?

Didn't a number of people outright _disagree_ with this in the discord, myself included, on the grounds this doesn't fix anything but instead makes languages way more costly than they used to be?
LukeZurg22 changed title from 'Fixes' polyglot by taking it out back and using globalpoints for languages to Removed Polyglot Trait & Set Language Traits to use Globalpoints 2026-05-23 21:07:17 +00:00
LukeZurg22 commented 2026-05-23 21:08:01 +00:00
Owner
Copy link

I also fixed your PR title, which didn't succinctly describe the changes. Looking at them, it feels most certainly antithetical to a major principle for this repository.

I also fixed your PR title, which didn't succinctly describe the changes. Looking at them, it feels most certainly antithetical to a major principle for this repository.
LukeZurg22 stopped working 2026-05-24 01:51:53 +00:00
4 seconds
LukeZurg22 changed title from Removed Polyglot Trait & Set Language Traits to use Globalpoints to WIP: Removed Polyglot Trait & Set Language Traits to use Globalpoints 2026-05-24 01:52:23 +00:00
cometvoid commented 2026-05-24 21:14:53 +00:00
Author
Contributor
Copy link

No.

It does fix things, and it doesn't make languages more expensive. Both of which I described in the discord.
https://discord.com/channels/1366946931892424778/1492237841575575552/1507437670442340443 also you agreed to it

No. It does fix things, and it doesn't make languages more expensive. Both of which I described in the discord. https://discord.com/channels/1366946931892424778/1492237841575575552/1507437670442340443 also you agreed to it
forgejo-actions commented 2026-06-08 00:00:56 +00:00
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our development discord.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

This pull request has been automatically marked as stale because it has not had any activity for 14 days. It will be closed in another 14 days if no further activity occurs. Thank you for your contributions. You can always ask for help on our development [discord](https://discord.gg/RYNBE6fUW2/). If you'd like to keep this open, just leave any comment, and the stale label will be removed.
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Check Merge Conflicts / label (pull_request_target) Failing after 12s
Details
Labels: PR / labeler (pull_request_target) Failing after 2s
Details
Labels: Size / size-label (pull_request_target) Failing after 1s
Details
Labels: Untriaged / add_label (pull_request_target) Failing after 1s
Details
Update REUSE Headers / update_headers (pull_request_target) Successful in 37s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m21s
Details
soft-repoban check / check-author (pull_request) Successful in 2s
Details
CRLF Check / CRLF Check (pull_request) Successful in 13s
Details
Test Packaging / Test Packaging (pull_request) Successful in 6m42s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 20s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 21s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 3m27s
Details
YAML Linter / YAML Linter (pull_request) Successful in 2m26s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 1s
Details
This pull request has changes conflicting with the target branch.
  • Resources/Prototypes/_EinsteinEngines/Traits/languages.yml
  • Resources/Prototypes/_Omu/Traits/languages.yml
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u languageTraitTweak:cometvoid-languageTraitTweak
git switch cometvoid-languageTraitTweak
Sign in to join this conversation.
Reviewers
No reviewers
LukeZurg22
Labels
Clear labels   
bug
Something isn't working

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
invalid
This doesn't seem right

  
question
Further information is requested

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
S: Merge Conflict

   
S: Untriaged

   
wontfix
This will not be worked on

No labels
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
duplicate
enhancement
good first issue
help wanted
holding to vote
invalid
question
size/L
size/M
size/S
size/XL
size/XS
S: Merge Conflict
S: Untriaged
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
LukeZurg22
3 participants
Notifications
Total time spent: 4 seconds
LukeZurg22
4 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Byrd-Station/Byrd!269
No description provided.