Byrd-Station/Byrd
5
3
Fork 17
Code Issues 33 Pull requests 4 Projects 2 Wiki Activity Actions

Make Healthbars Account for Shitmed and Softcrit #330

Merged
LilithArson merged 1 commit from healthbar-fix-again-20260530 into master 2026-05-29 23:42:15 +00:00
Conversation 0 Commits 1 Files changed 1 +4 -3
LilithArson commented 2026-05-29 23:22:13 +00:00
Owner
Copy link

PR Changes

Healthbars did not properly account for Shitmed after Softcrit integration

Reasons Behind Changes

see above

Code & Technical details

Adjusted how total damage is calculated in the overlay, no known conflicts with codebase as-is

Images; Sprites; Media

none

Checklist

Breaking changes

Ingame Changelog

🆑

  • fix: Made health bars (observer/medhud/etc) use vital damage instead of total damage
## PR Changes Healthbars did not properly account for Shitmed after Softcrit integration ## Reasons Behind Changes see above ## Code & Technical details Adjusted how total damage is calculated in the overlay, no known conflicts with codebase as-is ## Images; Sprites; Media none ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [x] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [x] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: - fix: Made health bars (observer/medhud/etc) use vital damage instead of total damage
Make healthbars account for shitmed again as well as softcrit
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Check Merge Conflicts / label (pull_request_target) Successful in 13s
Details
Labels: PR / labeler (pull_request_target) Successful in 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m22s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Labels: Untriaged / add_label (pull_request_target) Failing after 2s
Details
soft-repoban check / check-author (pull_request) Successful in 2s
Details
CRLF Check / CRLF Check (pull_request) Successful in 14s
Details
Test Packaging / Test Packaging (pull_request) Successful in 6m22s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 25s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 22s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 3m34s
Details
YAML Linter / YAML Linter (pull_request) Successful in 2m30s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 2s
Details
PR Changelogs / changelog (pull_request_target) Successful in 17s
Details
618d0bfb49
LukeZurg22 changed title from Make healthbars account for shitmed again as well as softcrit to Make Healthbars Again Account for Shitmed and Softcrit 2026-05-29 23:25:26 +00:00
LilithArson changed title from Make Healthbars Again Account for Shitmed and Softcrit to Make healthbars account for both shitmed and softcrit 2026-05-29 23:29:24 +00:00
LukeZurg22 changed title from Make healthbars account for both shitmed and softcrit to Make Healthbars Account for Shitmed and Softcrit 2026-05-29 23:33:04 +00:00
LilithArson deleted branch healthbar-fix-again-20260530 2026-05-29 23:42:15 +00:00
byrdbot referenced this pull request from a commit 2026-05-29 23:42:36 +00:00
Automatic changelog update (#330)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
invalid
This doesn't seem right

  
question
Further information is requested

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
S: Merge Conflict

   
S: Untriaged

   
wontfix
This will not be worked on

No labels
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
duplicate
enhancement
good first issue
help wanted
holding to vote
invalid
question
size/L
size/M
size/S
size/XL
size/XS
S: Merge Conflict
S: Untriaged
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Byrd-Station/Byrd!330
No description provided.