WIP: Ported Library Scavenger Hunt #346

Draft

LukeZurg22 wants to merge 9 commits from scavenger-hunt into master

pull from: scavenger-hunt

merge into: Byrd-Station:master

Byrd-Station:master

Byrd-Station:fishing

Byrd-Station:plushies-for-a-special-someone

Byrd-Station:high-command-20260508

Byrd-Station:botlightning

Byrd-Station:anomalocarids

Byrd-Station:resomi

Byrd-Station:suit-sensor-selector-20260603

Byrd-Station:retexture-20260602

Byrd-Station:automated-upstream-branch

Conversation 1 Commits 9 Files changed 45 +1075 -165

LukeZurg22 commented 2026-06-04 00:29:41 +00:00

Owner

Copy link

PR Changes

Ported Changes from Wizden #43353 with some minor adjustments, such as the exclusion of Bael and transfer of the Legend of Nar'sie book to book contraband.

Reasons Behind Changes

I feel as if the bael familiar was rushed and not necessary. Further improving existing "contraband" books felt highest in my priorities atm.

Code & Technical details

The ported system & component (as of 20260603) is not going to compile, as the entity effect changes from Wizden are not ported here, yet. Note: This description will be changed later, however as of current this is barred from merging until the compiler errors can be fixed, which require the merging of Wizden's EntityEffect changes!

Images; Sprites; Media

Quite a lot, really. Mainly a new set of book sprites. (See changes)

Checklist

• I read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset am following them.
• I have added media to this PR, or it does not require an ingame showcase.

Breaking changes

Ingame Changelog

🆑

• add: Ported Librarian Gameplay / Book Hunt Changes

## PR Changes Ported Changes from Wizden [#43353]( https://github.com/space-wizards/space-station-14/pull/43353) with some minor adjustments, such as the exclusion of Bael and transfer of the Legend of Nar'sie book to book contraband. ## Reasons Behind Changes I feel as if the bael familiar was rushed and not necessary. Further improving existing "contraband" books felt highest in my priorities atm. ## Code & Technical details The ported system & component (as of 20260603) is not going to compile, as the entity effect changes from Wizden are not ported here, yet. **Note: This description will be changed later, however as of current this is barred from merging until the compiler errors can be fixed, which require the merging of Wizden's EntityEffect changes!** ## Images; Sprites; Media Quite a lot, really. Mainly a new set of book sprites. (See changes) ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [X] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [ ] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: - add: Ported Librarian Gameplay / Book Hunt Changes

LukeZurg22 added the

help wanted

enhancement

Changes: Sprites

size/S

labels 2026-06-04 00:29:41 +00:00

LukeZurg22 self-assigned this 2026-06-04 00:29:41 +00:00

LilithArson was assigned by LukeZurg22 2026-06-04 00:29:41 +00:00

LukeZurg22 added 5 commits 2026-06-04 00:29:41 +00:00

Added Illegal Books d193ea3544

Added Banned Books Prototypes, Code Still in Work 63a63e9b35

Added RestoreAll field to RechargeBasicEntityAmmoComponent.cs 1b55c9302e

IDE Refuses to accept the removal of this Newline Character. In it goes. 07db5f9dde

Pushed Unfinished / Broken Classes. ... dabfc80165

Note: SpawnEntityListEntityEffect.cs and SpawnEntityListEntityEffectSystem.cs

LukeZurg22 added this to the Lilith's Todo List project 2026-06-04 00:29:42 +00:00

forgejo-actions added

size/M

and removed

size/S

labels 2026-06-04 00:33:00 +00:00

LukeZurg22 added 2 commits 2026-06-04 00:37:04 +00:00

Cleaned RechargeBasicEntityAmmoSystem.cs 6e5647cbee

Corrected Typo in NPCCombatSystem.Ranged.cs b032c266c6

LukeZurg22 requested review from Maintainer 2026-06-04 00:38:48 +00:00

LukeZurg22 commented 2026-06-04 01:04:01 +00:00

Author

Owner

Copy link

@LilithArson What would you like me to do when it comes to the EntityEffectBase and so forth, the ones that we don't have from Wizden?

It's possible to retrofit this into what we have now and I did a little bit of that, but just making sure.

@LilithArson What would you like me to do when it comes to the EntityEffectBase and so forth, the ones that we don't have from Wizden? It's possible to retrofit this into what we have now and I did a little bit of that, but just making sure.

LukeZurg22 added 2 commits 2026-06-04 01:19:04 +00:00

Minor Edits Everywhere in EntityEffectSystem.cs 7ad6675abe

SpawnEntityListEntityEffectSystem.cs Adjustment 4b87288e33

LukeZurg22 changed title from WIP: Ported Library Scavenger Hunt to WIP: Ported Library Scavenger Hunt (Awaiting Ent.Eff. from Wizden) 2026-06-04 01:21:46 +00:00

LukeZurg22 changed title from WIP: Ported Library Scavenger Hunt (Awaiting Ent.Eff. from Wizden) to WIP: Ported Library Scavenger Hunt 2026-06-04 05:27:57 +00:00

Some checks failed

Hide all checks

Check Merge Conflicts / label (pull_request_target) Has been skipped

Details

Labels: PR / labeler (pull_request_target) Successful in 2s

Details

Labels: Size / size-label (pull_request_target) Successful in 2s

Details

Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been skipped

Details

Build & Test Map Renderer / Build & Test Debug (pull_request) Has been skipped

Details

CRLF Check / CRLF Check (pull_request) Has been skipped

Details

Test Packaging / Test Packaging (pull_request) Has been skipped

Details

RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped

Details

RSI Validator / Validate RSIs (pull_request) Failing after 22s

Details

Map file schema validator / YAML map schema validator (pull_request) Has been skipped

Details

YAML Linter / YAML Linter (pull_request) Has been skipped

Details

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin scavenger-hunt:scavenger-hunt

git switch scavenger-hunt

Sign in to join this conversation.

Reviewers

No reviewers

Byrd-Station/Maintainer

Labels

Clear labels   

bug

Something isn't working

  

Changes: Audio

  

Changes: Map

  

Changes: No C#

  

Changes: Sprites

  

Changes: UI

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

holding to vote

This is currently being voted for by the Byrds.

  

invalid

This doesn't seem right

  

question

Further information is requested

  

size/L

  

size/M

  

size/S

  

size/XL

  

size/XS

  

S: Merge Conflict

  

S: Untriaged

  

wontfix

This will not be worked on

No labels

bug

Changes: Audio

Changes: Map

Changes: No C#

Changes: Sprites

Changes: UI

documentation

duplicate

enhancement

good first issue

help wanted

holding to vote

invalid

question

size/L

size/M

size/S

size/XL

size/XS

S: Merge Conflict

S: Untriaged

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Lilith's Todo List

Assignees

Clear assignees

No assignees

LukeZurg22

LilithArson

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Byrd-Station/Byrd!346

No description provided.