Byrd-Station/Byrd
Byrd-Station/Byrd
3
1
Fork 32
Code Issues 11 Pull requests 3 Projects 2 Wiki Activity Actions

Lark Fixes & OOC Name-Obfuscation Trait Fix #402

Merged
LukeZurg22 merged 4 commits from budgie into master 2026-06-12 01:36:13 +00:00
Conversation 1 Commits 4 Files changed 3 +2044 -653
LukeZurg22 commented 2026-06-12 01:04:34 +00:00
Contributor
Copy link

PR Changes

  • Fixed Lark atmos.
  • Fixed OOC-Name Obfuscator Trait
  • Lark Engineering improved.

Reasons Behind Changes

Larks fixes were a result of feedback and flaws in the map itself. (fixgridatmos! agh!)

The OOC Name Meta-trait was not working.

Code & Technical details

The PVSOverride CVar was the problem, however rather than config a CVar which is on by default, i just removed the check to it. Now it works! Will this cause issues? Not performance ones, that's for sure! I added some comments explaining my rationale; it should be good to go.

Images; Sprites; Media

image

Checklist

Breaking changes

Ingame Changelog

🆑

  • fix: Fixed Lark atmos.
  • fix: OOC-Name Obfuscator Trait
  • tweak: Lark Engineering improved.
## PR Changes - Fixed Lark atmos. - Fixed OOC-Name Obfuscator Trait - Lark Engineering improved. ## Reasons Behind Changes Larks fixes were a result of feedback and flaws in the map itself. (fixgridatmos! agh!) The OOC Name Meta-trait was not working. ## Code & Technical details The PVSOverride CVar was the problem, however rather than config a CVar which is on by default, i just removed the check to it. Now it works! Will this cause issues? Not performance ones, that's for sure! I added some comments explaining my rationale; it should be good to go. ## Images; Sprites; Media ![image](/attachments/0ad6b82d-82c9-49bf-8cda-291e8f165e1e) ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [X] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [ ] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: - fix: Fixed Lark atmos. - fix: OOC-Name Obfuscator Trait - tweak: Lark Engineering improved.
image.png
7.6 KiB
Fix Lark Atmospherics & Engi. APC, Tweaked Engineering
Some checks failed
CRLF Check / CRLF Check (pull_request) Waiting to run
Details
Test Packaging / Test Packaging (pull_request) Waiting to run
Details
RGA schema validator / YAML RGA schema validator (pull_request) Waiting to run
Details
RSI Validator / Validate RSIs (pull_request) Waiting to run
Details
Map file schema validator / YAML map schema validator (pull_request) Waiting to run
Details
YAML Linter / YAML Linter (pull_request) Waiting to run
Details
Close PRs on master / run (pull_request_target) Has been skipped
Details
Check Merge Conflicts / label (pull_request_target) Failing after 52s
Details
Labels: PR / labeler (pull_request_target) Successful in 2s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Labels: Untriaged / add_label (pull_request_target) Failing after 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been cancelled
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been cancelled
Details
soft-repoban check / check-author (pull_request) Successful in 2s
Details
21b8f28d40
Indentation Cleanup, Warning Cleanup, and OOC Name-Obf. Trait Fix in GameTicker.RoundFlow.cs
Some checks failed
RGA schema validator / YAML RGA schema validator (pull_request) Waiting to run
Details
RSI Validator / Validate RSIs (pull_request) Waiting to run
Details
Map file schema validator / YAML map schema validator (pull_request) Waiting to run
Details
YAML Linter / YAML Linter (pull_request) Waiting to run
Details
Check Merge Conflicts / label (pull_request_target) Failing after 52s
Details
Labels: PR / labeler (pull_request_target) Successful in 2s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m26s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Waiting to run
Details
CRLF Check / CRLF Check (pull_request) Successful in 16s
Details
Test Packaging / Test Packaging (pull_request) Has been cancelled
Details
212f6d642a
Merge branch 'master' of https://git.byrdstation.space/Byrd-Station/Byrd into budgie
Some checks failed
Check Merge Conflicts / label (pull_request_target) Successful in 54s
Details
Labels: PR / labeler (pull_request_target) Successful in 2s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m29s
Details
CRLF Check / CRLF Check (pull_request) Successful in 16s
Details
Test Packaging / Test Packaging (pull_request) Successful in 6m50s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 27s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 21s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 3m47s
Details
YAML Linter / YAML Linter (pull_request) Successful in 2m35s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 2s
Details
PR Changelogs / changelog (pull_request_target) Successful in 18s
Details
22108db751 
# Conflicts:
#	Resources/Maps/_Byrd/lark.yml
LukeZurg22 commented 2026-06-12 01:17:14 +00:00
Author
Contributor
Copy link

Sorry to Lilith in advance for the sheer amount of commits that'll show up in the git log. That's cause of a merger, and I had a moment of weakness. Forgive me 😭

Sorry to Lilith in advance for the sheer amount of commits that'll show up in the git log. That's cause of a merger, and I had a moment of weakness. Forgive me 😭
LukeZurg22 deleted branch budgie 2026-06-12 01:36:13 +00:00
byrdbot referenced this pull request from a commit 2026-06-12 01:42:55 +00:00
Automatic changelog update (#402)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
This is in regards to a bug.

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
DON'T MERGE
This is under review, fixes, or needs significant changes.

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
invalid
This doesn't seem right

  
question
Further information is requested

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
S: Merge Conflict

   
S: Untriaged

   
wontfix
This will not be worked on

No labels
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
enhancement
good first issue
help wanted
holding to vote
invalid
question
size/L
size/M
size/S
size/XL
size/XS
S: Merge Conflict
S: Untriaged
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Byrd-Station/Byrd!402
No description provided.