Byrd-Station/Byrd
Byrd-Station/Byrd
Watch
4
5
Fork
You've already forked Byrd
 22
Code Issues 33 Pull requests 35 Projects 1 Wiki Activity Actions 37

Lark Fixes & OOC Name-Obfuscation Trait Fix #402

Merged
LukeZurg22 merged 4 commits from budgie into master 2026-06-12 01:36:13 +00:00
Conversation 1 Commits 4 Files changed 3 +2044 -653
LukeZurg22 commented 2026-06-12 01:04:34 +00:00
Contributor

PR Changes

  • Fixed Lark atmos.
  • Fixed OOC-Name Obfuscator Trait
  • Lark Engineering improved.

Reasons Behind Changes

Larks fixes were a result of feedback and flaws in the map itself. (fixgridatmos! agh!)

The OOC Name Meta-trait was not working.

Code & Technical details

The PVSOverride CVar was the problem, however rather than config a CVar which is on by default, i just removed the check to it. Now it works! Will this cause issues? Not performance ones, that's for sure! I added some comments explaining my rationale; it should be good to go.

Images; Sprites; Media

image

Checklist

Breaking changes

Ingame Changelog

🆑

  • fix: Fixed Lark atmos.
  • fix: OOC-Name Obfuscator Trait
  • tweak: Lark Engineering improved.
## PR Changes - Fixed Lark atmos. - Fixed OOC-Name Obfuscator Trait - Lark Engineering improved. ## Reasons Behind Changes Larks fixes were a result of feedback and flaws in the map itself. (fixgridatmos! agh!) The OOC Name Meta-trait was not working. ## Code & Technical details The PVSOverride CVar was the problem, however rather than config a CVar which is on by default, i just removed the check to it. Now it works! Will this cause issues? Not performance ones, that's for sure! I added some comments explaining my rationale; it should be good to go. ## Images; Sprites; Media ![image](/attachments/0ad6b82d-82c9-49bf-8cda-291e8f165e1e) ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [X] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [ ] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: - fix: Fixed Lark atmos. - fix: OOC-Name Obfuscator Trait - tweak: Lark Engineering improved.
image.png
7.6 KiB
Fix Lark Atmospherics & Engi. APC, Tweaked Engineering
Some checks failed
CRLF Check / CRLF Check (pull_request) Waiting to run
Details
Test Packaging / Test Packaging (pull_request) Waiting to run
Details
RGA schema validator / YAML RGA schema validator (pull_request) Waiting to run
Details
RSI Validator / Validate RSIs (pull_request) Waiting to run
Details
Map file schema validator / YAML map schema validator (pull_request) Waiting to run
Details
YAML Linter / YAML Linter (pull_request) Waiting to run
Details
Close PRs on master / run (pull_request_target) Has been skipped
Details
Check Merge Conflicts / label (pull_request_target) Failing after 52s
Details
Labels: PR / labeler (pull_request_target) Successful in 2s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Labels: Untriaged / add_label (pull_request_target) Failing after 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been cancelled
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been cancelled
Details
soft-repoban check / check-author (pull_request) Successful in 2s
Details
21b8f28d40
Indentation Cleanup, Warning Cleanup, and OOC Name-Obf. Trait Fix in GameTicker.RoundFlow.cs
Some checks failed
RGA schema validator / YAML RGA schema validator (pull_request) Waiting to run
Details
RSI Validator / Validate RSIs (pull_request) Waiting to run
Details
Map file schema validator / YAML map schema validator (pull_request) Waiting to run
Details
YAML Linter / YAML Linter (pull_request) Waiting to run
Details
Check Merge Conflicts / label (pull_request_target) Failing after 52s
Details
Labels: PR / labeler (pull_request_target) Successful in 2s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m26s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Waiting to run
Details
CRLF Check / CRLF Check (pull_request) Successful in 16s
Details
Test Packaging / Test Packaging (pull_request) Has been cancelled
Details
212f6d642a
Merge branch 'master' of https://git.byrdstation.space/Byrd-Station/Byrd into budgie
Some checks failed
Check Merge Conflicts / label (pull_request_target) Successful in 54s
Details
Labels: PR / labeler (pull_request_target) Successful in 2s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m29s
Details
CRLF Check / CRLF Check (pull_request) Successful in 16s
Details
Test Packaging / Test Packaging (pull_request) Successful in 6m50s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 27s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 21s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 3m47s
Details
YAML Linter / YAML Linter (pull_request) Successful in 2m35s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 2s
Details
PR Changelogs / changelog (pull_request_target) Successful in 18s
Details
22108db751 
# Conflicts:
#	Resources/Maps/_Byrd/lark.yml
LukeZurg22 commented 2026-06-12 01:17:14 +00:00
Author
Contributor

Sorry to Lilith in advance for the sheer amount of commits that'll show up in the git log. That's cause of a merger, and I had a moment of weakness. Forgive me 😭

Sorry to Lilith in advance for the sheer amount of commits that'll show up in the git log. That's cause of a merger, and I had a moment of weakness. Forgive me 😭
LukeZurg22 deleted branch budgie 2026-06-12 01:36:13 +00:00
byrdbot referenced this pull request from a commit 2026-06-12 01:42:55 +00:00
Automatic changelog update (#402)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Area/Accessibility
Area: Accessibility settings and features.

  
Area/Admin Tooling
Area: Admin tooling and moderation

  
Area/Art
Area: Art with no implications for other areas.

  
Area/Atmospherics
Area: Atmospherics

  
Area/Cargo
Area: Cargo department and related mechanics

  
Area/Character / Species
Area: Player characters and species features and content.

  
Area/Chat
Area: Chat-related features and changes, most likely technical.

  
Area/Combat
Area: Combat features, changes, balancing.

  
Area/Command
Area: Command department, where it isn't applicable to other departments.

  
Area/Database
Area: Changes to Database code.

  
Area/Engineering
Area: Engineering department, doesn't include Atmospherics.

  
Area/Graphics
Area: Changes to shaders or overlays.

  
Area/Guidebook
Area: Ingame guidebook, content or technical implementation.

  
Area/Mapping
Area: Maps, or tools used for mapping

  
Area/Medical
Area: Medical department, including Chemistr

  
Area/Preferences / Options
Area: Player preferences and options.

  
Area/Roleplay / Lore
Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics

  
Area/Roundflow / Antag
Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities.

  
Area/Rules
Area: Changes to Server rules, SoP, or Space Law.

  
Area/Salvage
Area: Salvage changes

  
Area/Science
Area: Science department, not including Silicons.

  
Area/Security
Area: Security department, including Detectives, HoS

  
Area/Service
Area: Service department, including cooking, botany, etc

  
Area/Silicons
Area: Relates to Silicon roles, including AI.

  
bug
This is in regards to a bug.

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
DON'T MERGE
This is under review, fixes, or needs significant changes.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
Note/Port
A port from another repository.

  
Note/Upstream
A PR from upstream.

  
Priority
Critical
 Critical priority task!!

  
Priority
High
 High priority task

  
Priority
Low
 Low priority task

  
Priority
Normal
 Normal priority task

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
State/Approved
This PR has been approved.

  
State/invalid
This doesn't seem right

  
State/Merge Conflict

   
State/Needs Changes
Changes/Concerns have been brought up and should be made before review.

  
State/Needs Discussion
Discussion needed for changes, talk about it.

  
State/Untriaged

   
Type/Balance Change
Changes something in the game related to balancing.

  
Type/Bugfix
Fixes a known issue/bug.

  
Type/Documentation
Makes changes to documentation in the repository. This includes attributions changes.

  
Type/Enhancement
New feature or request, change to game.

  
Type/Feature
Adds completely new stuff to the game.

  
Type/Question
Further information is requested.

  
wontfix
This will not be worked on

No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!402
No description provided.