Byrd-Station/Byrd
5
3
Fork 17
Code Issues 33 Pull requests 4 Projects 2 Wiki Activity Actions

Finch Fixes & Criminal Records Code Cleanup #419

Merged
LukeZurg22 merged 5 commits from finch-fixes-20260612221 into master 2026-06-14 09:56:31 +00:00
Conversation 2 Commits 5 Files changed 3 +1194 -527
LukeZurg22 commented 2026-06-14 09:46:41 +00:00
Owner
Copy link

PR Changes

A lot of fixes for Finch. Minor stuff.

Cleaned up code in a criminal records class.

Reasons Behind Changes

Omitting the code cleanup in the changelog, because nobody is gonna see a difference.

Code & Technical details

Logic that had redundant checks was cleaned out from a criminal records computer class. I would've neglected to mention it here, but I feel as if it might come up later if an issue arises from my IDE analyzer being faulty.

Images; Sprites; Media

none

Checklist

Breaking changes

Ingame Changelog

🆑 Zurgs Finch Fixes

  • tweak: Finch Added Cryo to Medical
  • tweak: Finch Added Intercomms.
  • tweak: Finch Replaced Syndie Juice w. Norm. ChemVend
  • tweak: Finch Added Missing Mining Console.
  • tweak: Finch Cleaned up Botany
  • tweak: Finch Fix QM, Salv., & Psych. Job Slots
## PR Changes A lot of fixes for Finch. Minor stuff. Cleaned up code in a criminal records class. ## Reasons Behind Changes Omitting the code cleanup in the changelog, because nobody is gonna see a difference. ## Code & Technical details Logic that had redundant checks was cleaned out from a criminal records computer class. I would've neglected to mention it here, but I feel as if it might come up later if an issue arises from my IDE analyzer being faulty. ## Images; Sprites; Media none ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [X] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [x] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: Zurgs Finch Fixes - tweak: Finch Added Cryo to Medical - tweak: Finch Added Intercomms. - tweak: Finch Replaced Syndie Juice w. Norm. ChemVend - tweak: Finch Added Missing Mining Console. - tweak: Finch Cleaned up Botany - tweak: Finch Fix QM, Salv., & Psych. Job Slots
Finch Fixes
Some checks failed
Check Merge Conflicts / label (pull_request_target) Waiting to run
Details
Labels: PR / labeler (pull_request_target) Waiting to run
Details
Labels: Size / size-label (pull_request_target) Waiting to run
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Waiting to run
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Blocked by required conditions
Details
CRLF Check / CRLF Check (pull_request) Waiting to run
Details
Test Packaging / Test Packaging (pull_request) Waiting to run
Details
RGA schema validator / YAML RGA schema validator (pull_request) Waiting to run
Details
RSI Validator / Validate RSIs (pull_request) Waiting to run
Details
Map file schema validator / YAML map schema validator (pull_request) Waiting to run
Details
YAML Linter / YAML Linter (pull_request) Waiting to run
Details
Labels: Untriaged / add_label (pull_request_target) Failing after 2s
Details
soft-repoban check / check-author (pull_request) Successful in 2s
Details
Close PRs on master / run (pull_request_target) Has been skipped
Details
ffb7da0c57
Added QM & Psych. Role Spawns to Finch, Increased Salv. Slot by 1
Some checks failed
YAML Linter / YAML Linter (pull_request) Waiting to run
Details
CRLF Check / CRLF Check (pull_request) Waiting to run
Details
Test Packaging / Test Packaging (pull_request) Waiting to run
Details
RGA schema validator / YAML RGA schema validator (pull_request) Waiting to run
Details
RSI Validator / Validate RSIs (pull_request) Waiting to run
Details
Map file schema validator / YAML map schema validator (pull_request) Waiting to run
Details
Check Merge Conflicts / label (pull_request_target) Failing after 55s
Details
Labels: PR / labeler (pull_request_target) Successful in 3s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been cancelled
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been cancelled
Details
242a7f1c00
LukeZurg22 commented 2026-06-14 09:51:43 +00:00
Author
Owner
Copy link

Merging now. Surely there will be no problems.

Merging now. Surely there will be no problems.
LukeZurg22 commented 2026-06-14 09:51:57 +00:00
Author
Owner
Copy link

Crap, gitignore.

Crap, gitignore.
Merge branch 'master' into finch-fixes-20260612221
All checks were successful
Check Merge Conflicts / label (pull_request_target) Successful in 56s
Details
Labels: PR / labeler (pull_request_target) Successful in 3s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m33s
Details
CRLF Check / CRLF Check (pull_request) Successful in 18s
Details
Test Packaging / Test Packaging (pull_request) Successful in 6m39s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 30s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 24s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 3m50s
Details
YAML Linter / YAML Linter (pull_request) Successful in 2m38s
Details
PR Changelogs / changelog (pull_request_target) Successful in 21s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 2s
Details
8c3c9526d4 
# Conflicts:
#	.gitignore
LukeZurg22 deleted branch finch-fixes-20260612221 2026-06-14 09:56:32 +00:00
byrdbot referenced this pull request from a commit 2026-06-14 10:14:15 +00:00
Automatic changelog update (#419)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
invalid
This doesn't seem right

  
question
Further information is requested

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
S: Merge Conflict

   
S: Untriaged

   
wontfix
This will not be worked on

No labels
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
duplicate
enhancement
good first issue
help wanted
holding to vote
invalid
question
size/L
size/M
size/S
size/XL
size/XS
S: Merge Conflict
S: Untriaged
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Byrd-Station/Byrd!419
No description provided.