Byrd-Station/Byrd
5
3
Fork 17
Code Issues 33 Pull requests 4 Projects 2 Wiki Activity Actions

Fishing #444

Merged
LilithArson merged 5 commits from fishing into master 2026-06-17 07:54:27 +00:00
Conversation 0 Commits 5 Files changed 28 +14426 -14204
LilithArson commented 2026-06-17 07:18:42 +00:00
Owner
Copy link

PR Changes

Ports the Fishing Vendor (and more) from DV#4862

Reasons Behind Changes

fih

Code & Technical details

moved FishComponent to Content.Shared (same namespace, just for access purposes)

Checklist

Ingame Changelog

🆑

  • add: Ported fishing vendor from DeltaV
  • tweak: Updated saltern
## PR Changes Ports the Fishing Vendor (and more) from [DV#4862](https://github.com/DeltaV-Station/Delta-v/pull/4862) ## Reasons Behind Changes fih ## Code & Technical details moved FishComponent to Content.Shared (same namespace, just for access purposes) ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [x] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [x] I have added media to this PR, or it does not require an ingame showcase. **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: - add: Ported fishing vendor from DeltaV - tweak: Updated saltern
The Salterning
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Check Merge Conflicts / label (pull_request_target) Successful in 16s
Details
Labels: PR / labeler (pull_request_target) Successful in 3s
Details
Labels: Size / size-label (pull_request_target) Successful in 3s
Details
Labels: Untriaged / add_label (pull_request_target) Failing after 2s
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 2m26s
Details
soft-repoban check / check-author (pull_request) Successful in 3s
Details
CRLF Check / CRLF Check (pull_request) Successful in 16s
Details
Test Packaging / Test Packaging (pull_request) Successful in 6m34s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 31s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 23s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 3m56s
Details
YAML Linter / YAML Linter (pull_request) Successful in 2m34s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 3s
Details
2d7b0bd613
remove unused
Some checks failed
Check Merge Conflicts / label (pull_request_target) Successful in 16s
Details
Labels: PR / labeler (pull_request_target) Successful in 3s
Details
Labels: Size / size-label (pull_request_target) Successful in 2s
Details
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been cancelled
Details
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been cancelled
Details
Test Packaging / Test Packaging (pull_request) Has been cancelled
Details
YAML Linter / YAML Linter (pull_request) Has been cancelled
Details
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
Details
CRLF Check / CRLF Check (pull_request) Successful in 16s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 31s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 23s
Details
PR Changelogs / changelog (pull_request_target) Successful in 20s
Details
ab5c64e627
LilithArson deleted branch fishing 2026-06-17 07:54:28 +00:00
LilithArson referenced this pull request from a commit 2026-06-17 07:54:28 +00:00
Fishing (#444)
byrdbot referenced this pull request from a commit 2026-06-17 07:54:48 +00:00
Automatic changelog update (#444)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
invalid
This doesn't seem right

  
question
Further information is requested

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
S: Merge Conflict

   
S: Untriaged

   
wontfix
This will not be worked on

No labels
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
duplicate
enhancement
good first issue
help wanted
holding to vote
invalid
question
size/L
size/M
size/S
size/XL
size/XS
S: Merge Conflict
S: Untriaged
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Byrd-Station/Byrd!444
No description provided.