Wall Implementation Reversion for Corrections #593

Merged

LukeZurg22 merged 5 commits from 20270711-walls-corrections into master 2026-07-12 05:05:46 +00:00

Conversation 1 Commits 5 Files changed 222 +92 -944

LukeZurg22 commented 2026-07-11 20:07:45 +00:00

Contributor

Copy link

PR Changes

Reverted the previous two pull requests and re-added Lilith's RMC changes to isolate the wall and window sprite adjustments. Reason being that the previous Pull Request was hastily merged and with additional out-of-scope changes despite being marked Invalid and having a Bug (see label description for details).

Reasons Behind Changes

Lilith rushed the last PR and I have to clean this up before folks get too angry.

Code & Technical details

none

Images; Sprites; Media

none

Checklist

• I read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset am following them.
• I have added media to this PR, or it does not require an ingame showcase.

Breaking changes

Ingame Changelog

🆑

• remove: Unfinished Wall Textures

## PR Changes Reverted the previous two pull requests and re-added Lilith's RMC changes to isolate the wall and window sprite adjustments. Reason being that the previous Pull Request was hastily merged and with additional out-of-scope changes despite being marked _Invalid_ and having a _Bug_ (see label description for details). ## Reasons Behind Changes Lilith rushed the last PR and I have to clean this up before folks get too angry. ## Code & Technical details none ## Images; Sprites; Media none ## Checklist <!--Understand that not following all Contributor rule standards may get your PR closed at a maintainer’s discretion. Failure to follow the Contributor's ruleset may lead to your removal as a contributor.--> <!-- Confirm by placing an X in the brackets [X]: --> - [X] I read the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html) and [Byrd Station's Contributor Ruleset](https://docs.google.com/document/d/1oxCSRBc_2IlrcykljB5SPt783uJX7rMHTT7cImxlKFM/edit?tab=t.0#heading=h.vigrxrnffwji) am following them. - [X] I have added media to this PR, or it does not require an ingame showcase. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Ingame Changelog** <!-- Add a Changelog entry to make players ingame aware of new changes that could affect gameplay.--> :cl: - remove: Unfinished Wall Textures

LukeZurg22 added 10 commits 2026-07-11 20:07:45 +00:00

Revert "Make station radio sound global (#233)" ... 569f543876

This reverts commit 29e11c21aa.

Revert "Semi-fix audio volume setting (#185)" ... 1fd2f1e310

This reverts commit eac4f465e2.

Revert "Fix* radio volume slider math (#181)" ... 62d04e44e2

This reverts commit 1a0c869659.

Revert "Station radio volume slider (#178)" ... 73e4bdafd0

This reverts commit 649c329b36.

Radio volume reimplementation pt. 1 dbcd9b1b1f

Current progress ... 4d53c9e077

Half-baked, not working as intended - barely working at all

Merge branch 'master' of https://git.byrdstation.space/Byrd-Station/Byrd 8cd9adeca4

Revert "desprite (#592)" ... 25d2fc130a

This reverts commit a51bf61ec0.

Revert "Ported Null Structure Textures, Lobby Screen, Rustic Window (#590)" ... 64747aa24e

This reverts commit c6d1a2c5a7.

Re-Picked Liliths RMC Changes + Others c3dc053159

forgejo-actions added the

Changes: Map

Changes: Sprites

Changes: UI

labels 2026-07-11 20:07:49 +00:00

LukeZurg22 added 1 commit 2026-07-11 20:10:12 +00:00

Re-Added RMC Content Changes ... e1c24ea92d

Signed-off-by: LukeZurg22 <11780262+LukeZurg22@users.noreply.github.com>

LilithArson force-pushed 20270711-walls-corrections from e1c24ea92d to 832a0f932b 2026-07-11 20:16:03 +00:00 Compare

LukeZurg22 commented 2026-07-11 21:21:32 +00:00

Author

Contributor

Copy link

@LilithArson I removed this branch from my local repository. You will need to cherry-pick the Alamo back.

@LilithArson I removed this branch from my local repository. You will need to cherry-pick the Alamo back.

LilithArson added 1 commit 2026-07-11 21:59:48 +00:00

alamo 250117337f

LukeZurg22 merged commit 7490c5aecf into master 2026-07-12 05:05:46 +00:00

LukeZurg22 referenced this pull request from a commit 2026-07-12 05:05:48 +00:00

Wall Implementation Reversion for Corrections (#593)

byrdbot referenced this pull request from a commit 2026-07-12 05:06:09 +00:00

Automatic changelog update (#593)

cometvoid referenced this pull request from a commit 2026-07-18 18:29:50 +00:00

Wall Implementation Reversion for Corrections (#593)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

This is in regards to a bug.

  

Changes: Audio

  

Changes: Map

  

Changes: No C#

  

Changes: Sprites

  

Changes: UI

  

documentation

Improvements or additions to documentation

  

DON'T MERGE

This is under review, fixes, or needs significant changes.

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

holding to vote

This is currently being voted for by the Byrds.

  

invalid

This doesn't seem right

  

question

Further information is requested

  

size/L

  

size/M

  

size/S

  

size/XL

  

size/XS

  

S: Merge Conflict

  

S: Untriaged

  

wontfix

This will not be worked on

No labels

bug

Changes: Audio

Changes: Map

Changes: No C#

Changes: Sprites

Changes: UI

documentation

DON'T MERGE

duplicate

enhancement

good first issue

help wanted

holding to vote

invalid

question

size/L

size/M

size/S

size/XL

size/XS

S: Merge Conflict

S: Untriaged

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Byrd-Station/Byrd!593

No description provided.