Cherrypick Gunplay Changes from RMC #74

Merged
ashley-graves merged 2 commits from ashley-graves/rmc-itemslots-20260430 into master 2026-04-30 20:37:55 +00:00
ashley-graves commented 2026-04-30 13:32:06 +00:00 (Migrated from github.com)

About the PR

Ported a lot of gunplay features from RMC (namely holstering)

Why / Balance

Technical details

Media

https://github.com/user-attachments/assets/a75660f4-2690-4dd7-adeb-a9097280b6c2

Requirements

Breaking changes

Changelog

🆑 LilithArson

  • add: Cherrypicked gunplay changes from RMC.
  • remove: Remove suitstorage quickstore keybind (broken mess)
<!-- SPDX-FileCopyrightText: 2021 Pieter-Jan Briers <pieterjan.briers+git@gmail.com> SPDX-FileCopyrightText: 2021 Swept <sweptwastaken@protonmail.com> SPDX-FileCopyrightText: 2021 mirrorcult <lunarautomaton6@gmail.com> SPDX-FileCopyrightText: 2022 AJCM-git <60196617+AJCM-git@users.noreply.github.com> SPDX-FileCopyrightText: 2022 Kara <lunarautomaton6@gmail.com> SPDX-FileCopyrightText: 2023 DrSmugleaf <DrSmugleaf@users.noreply.github.com> SPDX-FileCopyrightText: 2023 Kevin Zheng <kevinz5000@gmail.com> SPDX-FileCopyrightText: 2024 Vasilis <vasilis@pikachu.systems> SPDX-FileCopyrightText: 2024 lzk <124214523+lzk228@users.noreply.github.com> SPDX-FileCopyrightText: 2025 Aiden <28298836+Aidenkrz@users.noreply.github.com> SPDX-License-Identifier: AGPL-3.0-or-later --> <!-- Guidelines: https://docs.spacestation14.io/en/getting-started/pr-guideline --> <!-- NOTE: All code submitted to this repository is ALWAYS licensed under the AGPL-3.0-or-later license. The REUSE Specification headers or separate .license files indicate a secondary license (e.g., MPL or MIT) solely to facilitate integration for projects that do not use the AGPL license. This secondary license does not replace the fact that AGPL-3.0-or-later remains the primary and binding license. Uncomment and modify the following line if you wish to change the license from the default of AGPL.--> <!--- LICENSE: AGPL --> ## About the PR <!-- What did you change? --> Ported a lot of gunplay features from RMC (namely holstering) ## Why / Balance <!-- Discuss how this would affect game balance or explain why it was changed. Link any relevant discussions or issues. --> ## Technical details <!-- Summary of code changes for easier review. --> ## Media <!-- Attach media if the PR makes ingame changes (clothing, items, features, etc). Small fixes/refactors are exempt. Media may be used in SS14 progress reports with credit. --> https://github.com/user-attachments/assets/a75660f4-2690-4dd7-adeb-a9097280b6c2 ## Requirements <!-- Confirm the following by placing an X in the brackets [X]: --> - [x] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). - [x] I have added media to this PR or it does not require an ingame showcase. <!-- You should understand that not following the above may get your PR closed at maintainer’s discretion --> ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Changelog** <!-- Add a Changelog entry to make players aware of new features or changes that could affect gameplay. Make sure to read the guidelines and take this Changelog template out of the comment block in order for it to show up. Changelog must have a :cl: symbol, so the bot recognizes the changes and adds them to the game's changelog. --> :cl: LilithArson - add: Cherrypicked gunplay changes from RMC. - remove: Remove suitstorage quickstore keybind (broken mess)
Merge branch 'master' into ashley-graves/rmc-itemslots-20260430
Some checks failed
Check Merge Conflicts / Label (pull_request_target) Failing after 4s
Labels: Size / size-label (pull_request_target) Successful in 4s
Labels: PR / labeler (pull_request_target) Successful in 4s
CRLF Check / CRLF Check (pull_request) Successful in 20s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 25s
RSI Validator / Validate RSIs (pull_request) Successful in 27s
Update REUSE Headers / update_headers (pull_request_target) Successful in 44s
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
Build & Test Debug / build (ubuntu-latest) (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
Build & Test Debug / Build & Test Debug (pull_request) Has been cancelled
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been cancelled
bef6f96168
Owner

Merge conflicts are present!

Merge conflicts are present!
Merge branch 'master' into ashley-graves/rmc-itemslots-20260430
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 4s
Check Merge Conflicts / Label (pull_request_target) Failing after 6s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 15s
Update REUSE Headers / update_headers (pull_request_target) Successful in 40s
RSI Validator / Validate RSIs (pull_request) Successful in 49s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 58s
Build & Test Debug / build (ubuntu-latest) (pull_request) Has been cancelled
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
Build & Test Debug / Build & Test Debug (pull_request) Has been cancelled
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been cancelled
8ed07118fd
LilithArson force-pushed ashley-graves/rmc-itemslots-20260430 from 8ed07118fd
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 4s
Check Merge Conflicts / Label (pull_request_target) Failing after 6s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 15s
Update REUSE Headers / update_headers (pull_request_target) Successful in 40s
RSI Validator / Validate RSIs (pull_request) Successful in 49s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 58s
Build & Test Debug / build (ubuntu-latest) (pull_request) Has been cancelled
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
Build & Test Debug / Build & Test Debug (pull_request) Has been cancelled
Build & Test Map Renderer / Build & Test Debug (pull_request) Has been cancelled
to 26b7283ddd
Some checks failed
Check Merge Conflicts / Label (pull_request_target) Failing after 7s
Labels: PR / labeler (pull_request_target) Successful in 5s
Labels: Size / size-label (pull_request_target) Successful in 7s
Update REUSE Headers / update_headers (pull_request_target) Successful in 2m7s
CRLF Check / CRLF Check (pull_request) Successful in 41s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 59s
RSI Validator / Validate RSIs (pull_request) Successful in 36s
Build & Test Map Renderer / build (ubuntu-latest) (pull_request) Successful in 7m37s
Build & Test Map Renderer / Build & Test Debug (pull_request) Successful in 4s
Build & Test Debug / build (ubuntu-latest) (pull_request) Failing after 9m7s
Build & Test Debug / Build & Test Debug (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Failing after 4m59s
Map file schema validator / YAML map schema validator (pull_request) Successful in 6m1s
PR Changelogs / changelog (pull_request_target) Successful in 28s
Test Packaging / Test Packaging (pull_request) Successful in 12m31s
2026-04-30 20:23:11 +00:00
Compare
LukeZurg22 changed title from Cherrypick gunplay changes from RMC to Cherrypick Gunplay Changes from RMC 2026-04-30 20:23:52 +00:00
Owner

@LukeZurg22 wrote in #74 (comment):

Merge conflicts are present!

nuh uh

@LukeZurg22 wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/74#issuecomment-53: > Merge conflicts are present! nuh uh
byrdbot referenced this pull request from a commit 2026-04-30 20:38:22 +00:00
Sign in to join this conversation.
No description provided.