More drinks #839

Merged
LilithArson merged 5 commits from orangeAlligator/Byrd:dinks into master 2026-08-19 04:08:12 +00:00
Contributor

Short description

Adding some Imp/etc drinks. Probably the rest later, alongside fixing a couple recipes (currently changed to not require their imp/den/wherever ingredients that I didn't add) (i.e.: swapping hummingbird for orange juice bc no hummingbird yet)

Why we need to add this

Merge requested

Media (Video/Screenshots)

Attached.

Checklist

Breaking changes

Ingame Changelog

🆑

  • add: Added a few new drinks!
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Adding some Imp/etc drinks. Probably the rest later, alongside fixing a couple recipes (currently changed to not require their imp/den/wherever ingredients that I didn't add) (i.e.: swapping hummingbird for orange juice bc no hummingbird yet) ## Why we need to add this Merge requested ## Media (Video/Screenshots) Attached. ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [ ] I do not require assistance to complete the PR. - [X] I have verified that the changes work before posting/requesting review of my PR. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> ### Ingame Changelog :cl: - add: Added a few new drinks!
saltern tweak
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Failing after 3s
Labels: Size / size-label (pull_request_target) Failing after 4s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m41s
RSI Validator / Validate RSIs (pull_request) Successful in 2m22s
CRLF Check / CRLF Check (pull_request) Successful in 2m49s
YAML Linter / YAML Linter (pull_request) Successful in 9m30s
Map file schema validator / YAML map schema validator (pull_request) Successful in 10m37s
Test Packaging / Test Packaging (pull_request) Successful in 20m18s
PR Changelogs / changelog (pull_request_target) Successful in 26s
5dede98858
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
updat?
buncha imp drinks
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: Size / size-label (pull_request_target) Failing after 4s
Labels: PR / labeler (pull_request_target) Successful in 5s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 4m48s
CRLF Check / CRLF Check (pull_request) Successful in 5m36s
RSI Validator / Validate RSIs (pull_request) Successful in 4m38s
Build & Test Debug / build (ubuntu-latest) (pull_request) Failing after 12m2s
Map file schema validator / YAML map schema validator (pull_request) Successful in 10m44s
YAML Linter / YAML Linter (pull_request) Failing after 8m47s
Test Packaging / Test Packaging (pull_request) Successful in 22m52s
9793353423
Owner

bartender major (yaml linter fail real btw)

bartender major (yaml linter fail real btw)
@ -2,0 +2,4 @@
# SPDX-FileCopyrightText: 2025 Shaman
# SPDX-FileCopyrightText: 2025 pocl v
#
# SPDX-License-Identifier: AGPL-3.0-or-later
Member

Kill SPDX (#274)

Kill SPDX (#274)
@ -62,0 +66,4 @@
# SPDX-FileCopyrightText: 2025 pocl v
# SPDX-FileCopyrightText: 2025 portfiend
#
# SPDX-License-Identifier: AGPL-3.0-or-later
Member

Kill SPDX (#274)

Kill SPDX (#274)
@ -28,2 +28,4 @@
products:
FeverDream: 5
# SPDX-License-Identifier: AGPL-3.0-or-later
Member

Kill SPDX (#274)

Kill SPDX (#274)
@ -7,2 +4,3 @@
flavor-complex-thavenbad = like you need to pretend you like it
flavor-complex-allulalo = like hand sanitizer
flavor-base-drinkdrink = like dogshit
Member

flavor-base-drinkdrink seems to be unused

`flavor-base-drinkdrink` seems to be unused
@ -9,0 +8,4 @@
flavor-base-kingsoda = like you're a champion
flavor-complex-feverdream = like you're losing your mind
flavor-complex-genderfluid = transitional
flavor-complex-grease = tastes thick, slimy, and a bit bitter
Member

Lines 9-11 look unused.

Lines 9-11 look unused.
@ -3,0 +17,4 @@
reagent-desc-thumperdrink = A delicious blend of fruit juice and liquor, from the shelves of the Uthani homeworld to a bar counter near you.
reagent-name-moscowmule = moscow mule
reagent-desc-moscowmule = A fresh and sparkly cocktail, with just the right kick of ginger to wake you from your stupor. If it's not in copper, why even bother?
Member

reagent-name-moscowmule and reagent-desc-moscowmule are unused.

`reagent-name-moscowmule` and `reagent-desc-moscowmule` are unused.
@ -1,2 +1,9 @@
reagent-name-feverdream = fever dream
reagent-desc-feverdream = A creamy, hallucinogenic cocktail of exotic blood, absinthe, and champagne, topped with frothed egg whites. Unpalatable if mixed incorrectly, and traditionally served with a thaven good luck charm. Open your eyes.

Member

Invisible unicode character at the start of the file.

Invisible unicode character at the start of the file.
@ -0,0 +1,12 @@
Member

Small nitpick, but there is an empty line at the top of the file.

Small nitpick, but there is an empty line at the top of the file.
@ -3,0 +3,4 @@
reagent-physical-desc-evil = evil
reagent-physical-desc-thegrease = really greasy
Member

Both reagent-physical-desc-evil and reagent-physical-desc-thegrease are unused.

Both `reagent-physical-desc-evil` and `reagent-physical-desc-thegrease` are unused.
@ -30,0 +41,4 @@
- type: flavor
id: evil
flavorType: Base
description: flavor-base-evil
Member

This flavor seems to be unused.

This flavor seems to be unused.
@ -0,0 +55,4 @@
id: LiquidLunch
name: reagent-name-liquidlunch
parent: BaseDrink
slippery: false
Member

We don't have slippery field on reagents prototypes. We have slipData instead.
So to get a similar effect you can add slipData: null instead.

We don't have `slippery` field on reagents prototypes. We have `slipData` instead. So to get a similar effect you can add `slipData: null` instead.
Author
Contributor

Thanks! It's my first time trying to port in something from another fork, I knew I had to be missing a few loose ends. I'll get the rest of these cleaned up quick and ready to merge!

Thanks! It's my first time trying to port in something from another fork, I knew I had to be missing a few loose ends. I'll get the rest of these cleaned up quick and ready to merge!
cleaning up
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 4s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 2m59s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 4m20s
RSI Validator / Validate RSIs (pull_request) Successful in 3m19s
Build & Test Debug / build (ubuntu-latest) (pull_request) Failing after 12m40s
Map file schema validator / YAML map schema validator (pull_request) Successful in 10m27s
YAML Linter / YAML Linter (pull_request) Successful in 11m21s
Test Packaging / Test Packaging (pull_request) Successful in 23m34s
cd6f3219d1
Member

All comments have been addressed, except this comment about reagent-name-moscowmule

All comments have been addressed, except this [comment](https://git.byrdstation.space/Byrd-Station/Byrd/pulls/839#issuecomment-6935) about `reagent-name-moscowmule`
i think i had a dream that moscow mules were added and assumed they were there
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 1m2s
Labels: PR / labeler (pull_request_target) Successful in 1m2s
CRLF Check / CRLF Check (pull_request) Successful in 4m42s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 4m24s
RSI Validator / Validate RSIs (pull_request) Successful in 3m47s
Build & Test Debug / build (ubuntu-latest) (pull_request) Failing after 15m39s
Map file schema validator / YAML map schema validator (pull_request) Successful in 11m4s
YAML Linter / YAML Linter (pull_request) Successful in 9m40s
Test Packaging / Test Packaging (pull_request) Successful in 22m39s
PR Changelogs / changelog (pull_request_target) Successful in 1m4s
39aa780386
byrdbot referenced this pull request from a commit 2026-08-19 04:09:14 +00:00
Sign in to join this conversation.
No description provided.