Fixed some heretic crashes and them not getting knowledge points from sacs #901

Merged
EchoOfNothing merged 3 commits from QuillTheCreature/Byrd:entities/heretic/knowledgefix into master 2026-09-08 16:18:11 +00:00
Contributor

Short description

Ports of:

Why we need to add this

Bugfixes

Media (Video/Screenshots)

Before:
image

After:
image

Proof ascension working:
image

Checklist

Ingame Changelog

🆑 Quill

  • fix: Fixed heretics not getting knowledge points from sacrificing targets
  • fix: Prevented heretics from rolling an already sacrificed target
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Ports of: * https://github.com/ProjectOmu/OmuStation/pull/1602 - Fixed heretics re-rolling the same target multiple times * https://github.com/ProjectOmu/OmuStation/pull/1385 - Fixed heretics crashing the server when a null mind gets sacced * https://github.com/ProjectOmu/OmuStation/pull/1352 - Fixed heretics not getting knowledge points ## Why we need to add this Bugfixes ## Media (Video/Screenshots) Before: ![image](/attachments/d36d6fe7-df70-4cf3-98b4-fc3896dc9ee5) After: ![image](/attachments/732f6d04-ba4f-43cf-a6ed-72aff43384df) Proof ascension working: ![image](/attachments/2b555f5d-0ed4-4533-9b84-75d824b6833c) ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - fix: Fixed heretics not getting knowledge points from sacrificing targets - fix: Prevented heretics from rolling an already sacrificed target
Disallowed heretics from rolling an already sacced target again.
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 55s
Labels: Size / size-label (pull_request_target) Failing after 54s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 2m30s
CRLF Check / CRLF Check (pull_request) Successful in 4m1s
RSI Validator / Validate RSIs (pull_request) Successful in 3m34s
Map file schema validator / YAML map schema validator (pull_request) Successful in 10m18s
YAML Linter / YAML Linter (pull_request) Successful in 10m23s
Test Packaging / Test Packaging (pull_request) Successful in 19m33s
PR Changelogs / changelog (pull_request_target) Successful in 1m13s
c77c75f642
EchoOfNothing left a comment

LGTM. Thank you for your contribution!

LGTM. Thank you for your contribution!
byrdbot referenced this pull request from a commit 2026-09-08 16:19:24 +00:00
Sign in to join this conversation.
No description provided.