Ensure Cryopods work as effectively on species with temperature transfer values such as Vulps (#452) #944
No reviewers
Labels
No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Byrd-Station/Byrd!944
Loading…
Reference in a new issue
No description provided.
Delete branch ":entities/cryopods/vulpfix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Short description
Cherry pick of https://github.com/ProjectOmu/OmuStation/pull/452
This PR Fixes the issue with Cryopods not being able to effectively cool-down species with temperature transfer values such as Vulperians, Trajans due to them taking forever to be cooled down.
This PR checks if the temperature transfer is not the default value, if its not it stores the value we have and sets it to the default until we eject the body from the cryopod.
Why we need to add this
Crypods should be usable on all species with the same efficiency,
You are stuck inside a super heated/frozen liquid gel filled with air, no way your fur can protect you from that.
Media (Video/Screenshots)
Inside a pod
Out of a pod
Cold dork
Checklist
Ingame Changelog
🆑 Quill
@ -0,0 +10,23 @@/// Used to handle inserting species with temperature transfer thresholds,/// by setting their thresholds to the default/// </summary>private void OnInserted(EntityUid uid, CryoPodComponent cryoComp, EntInsertedIntoContainerMessage args){if (args.Container.ID != cryoComp.BodyContainer.ID)return;if (!TryComp<TemperatureComponent>(args.Entity, out var tempComp))return;// Ensure we have the component, it should be already on the Entity, but just in-case.EnsureComp<InsideCryoPodComponent>(args.Entity, out var insideComp);// Store the original threshold or mark it as null if it's already the defaultif (!MathHelper.CloseTo(tempComp.AtmosTemperatureTransferEfficiency, 0.1f, 0.01f)){insideComp.OriginalAtmosTemperatureTransferEfficiency = tempComp.AtmosTemperatureTransferEfficiency;tempComp.AtmosTemperatureTransferEfficiency = 0.1f;}elseinsideComp.OriginalAtmosTemperatureTransferEfficiency = null;}Doesn't work on tajaran.
Ah looks like this is yet another upstream bug, I'll fix that and then PR that to omu too I guess...
I've applied the same fix goob applied to vulps, instead of setting
TemperatureProtectionvalues they set theatmosTemperatureTransferEfficiencyvalue in theTemperaturecomponent.@ -14,3 +14,3 @@public EntityUid? SleepAction;}}Not a PR blocker, just a nitpik, but you don't really have to commit changes that change nothing like this.
Yeah that's from the initial PR: https://github.com/ProjectOmu/OmuStation/pull/452/files#diff-df9c147375d11807eb42334ef2481dfcdb3c5610ae4a86d821da252a62cc8d05
I think they added a new line to the end here. Some text editors do that automatically, I'll revert that change.
bc1ba9ccf60641bc5e0e0641bc5e0ea53d30d6a7a53d30d6a713cb8479fcLGTM. Thank you for your contribution!