Byrd-Station/Byrd
Byrd-Station/Byrd
Watch
4
5
Fork
You've already forked Byrd
 22
Code Issues 33 Pull requests 35 Projects 1 Wiki Activity Actions 37

sharkening #949

Open
ichthyoacanthotoxism wants to merge 2 commits from (deleted):sharkening into master
pull from: (deleted):sharkening
merge into: Byrd-Station:master
Conversation 4 Commits 2 Files changed 42 +624 -342
ichthyoacanthotoxism commented 2026-09-23 16:30:22 +00:00
First-time contributor

Short description

Adds several new markings to Feroxi:

  • Eight new body markings: Marbled, Encircled, Embraced, Centerpiece, Starry, Tailward, Harpoon, and Gills
  • Six new leg markings: Overside, Flank, Schism, Racing Stripe, Banded, and Underside
  • Three new foot markings: Claw, Stamped, Paw
  • Nine new tail markings: Saddle, Spatter, Speckle, Undertow, Crackle, Rimed, Spots, Banded, and Half-n-Half

Changes the Feroxi tail marking limitation from 10, up from 1.

Adds a base tail marking to the Feroxi species in order to permit layering of tail markings.

Due to the new capabilities for Feroxi tail marking layering, this update will remove the visible tail markings from most current Feroxi. As the affected markings have been changed to their own standalone pieces, it is still possible for an individual to reassemble these markings in the editor if they so desire.

Why we need to add this

Feroxi currently suffer from a lack of species-specific customization options, with most current markings being different mixtures of the same few individual patterns. This aims to fix this and give more versatility to the appearance of Feroxi.

Media (Video/Screenshots)

All new Feroxi markings.
image

Checklist

Breaking changes

Ingame Changelog

🆑

  • add: Twenty-six new Feroxi markings.
  • remove: Old Feroxi tail marking clutter.
  • tweak: Old Feroxi tail marking pieces are now available as standalone pieces.
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description <!-- What do you propose to change with your PR? --> Adds several new markings to Feroxi: - Eight new body markings: Marbled, Encircled, Embraced, Centerpiece, Starry, Tailward, Harpoon, and Gills - Six new leg markings: Overside, Flank, Schism, Racing Stripe, Banded, and Underside - Three new foot markings: Claw, Stamped, Paw - Nine new tail markings: Saddle, Spatter, Speckle, Undertow, Crackle, Rimed, Spots, Banded, and Half-n-Half Changes the Feroxi tail marking limitation from 10, up from 1. Adds a base tail marking to the Feroxi species in order to permit layering of tail markings. Due to the new capabilities for Feroxi tail marking layering, this update will remove the visible tail markings from most current Feroxi. As the affected markings have been changed to their own standalone pieces, it is still possible for an individual to reassemble these markings in the editor if they so desire. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Feroxi currently suffer from a lack of species-specific customization options, with most current markings being different mixtures of the same few individual patterns. This aims to fix this and give more versatility to the appearance of Feroxi. ## Media (Video/Screenshots) <!--If your PR contains in-game changes you must provide screenshots/videos of the changes.--> All new Feroxi markings. ![image](/attachments/a78c422f-0ecb-41e9-abaf-41c9dd12b9ce) ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> ### Ingame Changelog <!--If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative.--> <!--:cl: - add: Added fun! - remove: Removed fun! - tweak: Changed fun! - fix: Fixed fun!--> :cl: - add: Twenty-six new Feroxi markings. - remove: Old Feroxi tail marking clutter. - tweak: Old Feroxi tail marking pieces are now available as standalone pieces.
image.png
148 KiB
Added new Feroxi markings
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Labels: PR / labeler (pull_request_target) Successful in 7s
Details
Labels: Size / size-label (pull_request_target) Failing after 5s
Details
CRLF Check / CRLF Check (pull_request) Successful in 53s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 58s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 1m3s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m39s
Details
YAML Linter / YAML Linter (pull_request) Successful in 7m46s
Details
Test Packaging / Test Packaging (pull_request) Successful in 22m6s
Details
757b5e76d8
Kazuno commented 2026-09-23 19:33:38 +00:00
Contributor

YIPEE

YIPEE
GGdoggodude commented 2026-09-23 22:49:29 +00:00
Contributor

shonk

shonk
EchoOfNothing reviewed 2026-09-29 12:56:03 +00:00
Resources/Locale/en-US/_Byrd/markings/feroxi.ftl
@ -0,0 +21,4 @@
marking-FeroxiTailSpeckle-feroxi-tail-speckle = Speckle
marking-FeroxiTailSpots = Spots
marking-FeroxiTailSpots-feroxi-tail-Spots = Spots
EchoOfNothing commented 2026-09-29 12:38:04 +00:00
Owner

Lower case spots.

Lower case spots.
Resources/Locale/en-US/_Byrd/markings/feroxi.ftl
Lines 63-66
@ -0,0 +60,7 @@
marking-FeroxiRightLegOverside = Overside
marking-FeroxiRightLegOverside-feroxi-right-leg-overside = Overside
marking-FeroxiLeftLegRacingstripe = Racing Stripe
marking-FeroxiLeftLegRacingstripe-feroxi-left-leg-racingstripe = Racing Stripe
marking-FeroxiRightLegRacingstripe = Racing Stripe
marking-FeroxiRightLegRacingstripe-feroxi-right-leg-racingstripe = Racing Stripe
EchoOfNothing commented 2026-09-29 12:42:20 +00:00
Owner

FeroxiLeftLegRacingstripe related ftl strings are unused.

`FeroxiLeftLegRacingstripe` related ftl strings are unused.
Resources/Locale/en-US/_Byrd/markings/feroxi.ftl
@ -0,0 +83,4 @@
marking-FeroxiBodyEmbraced-feroxi-body-embraced = Embraced
marking-FeroxiBodyEncircled = Encircled
marking-FeroxiBodyEncircled-feroxi-body-centerpiece = Encircled
EchoOfNothing commented 2026-09-29 12:45:30 +00:00
Owner

encircled instead of centerpiece.

`encircled` instead of `centerpiece`.
Resources/Prototypes/_DV/Entities/Mobs/Customization/Markings/feroxi.yml
@ -594,4 +395,0 @@
- sprite: _Goobstation/Mobs/Customization/Feroxi/tail_markings.rsi
state: feroxi-dorsal
- sprite: _Goobstation/Mobs/Customization/Feroxi/tail_markings.rsi
state: feroxi-dorsal-tip
EchoOfNothing commented 2026-09-29 12:51:54 +00:00
Owner

Would be better if you comment them out.

Would be better if you comment them out.
Resources/Prototypes/_DV/Entities/Mobs/Customization/Markings/feroxi.yml
@ -302,4 +199,0 @@
- sprite: _Goobstation/Mobs/Customization/Feroxi/tail_markings.rsi #RedTerror Goob Resprite
state: feroxi-dorsal
- sprite: _Goobstation/Mobs/Customization/Feroxi/tail_markings.rsi #RedTerror Goob Resprite
state: feroxi-dorsal-tip
EchoOfNothing commented 2026-09-29 12:51:44 +00:00
Owner

Would be better if you comment them out.

Would be better if you comment them out.
Resources/Prototypes/_DV/Entities/Mobs/Customization/Markings/feroxi.yml
@ -108,0 +186,4 @@
speciesRestriction: [ Feroxi ]
sprites:
- sprite: _Goobstation/Mobs/Customization/Feroxi/tail_markings.rsi #RedTerror Goob Resprite
state: feroxi-tail-under
EchoOfNothing commented 2026-09-29 12:51:12 +00:00
Owner

Those are Byrd additions basically, so just put them under _Byrd.

Those are Byrd additions basically, so just put them under _Byrd.
Resources/Textures/_Byrd/Mobs/Customization/Feroxi/body_markings.rsi/meta.json
Lines 58-65
@ -0,0 +55,11 @@
"name": "feroxi-right-leg-overside",
"directions": 4
},
{
"name": "feroxi-left-leg-racingstripe",
"directions": 4
},
{
"name": "feroxi-right-leg-racingstripe",
"directions": 4
},
EchoOfNothing commented 2026-09-29 12:54:26 +00:00
Owner

leg-racingstripes are unused.

`leg-racingstripe`s are unused.
QuillTheCreature commented 2026-10-08 20:10:30 +00:00
Member

You need to re-create the PR since your repo got deleted.

Fork the repo again with the same name as before, do a git push, and then create a new PR.

You need to re-create the PR since your repo got deleted. Fork the repo again with the same name as before, do a `git push`, and then create a new PR.
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Labels: PR / labeler (pull_request_target) Successful in 7s
Details
Labels: Size / size-label (pull_request_target) Failing after 5s
Details
CRLF Check / CRLF Check (pull_request) Successful in 53s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 58s
Details
RSI Validator / Validate RSIs (pull_request) Successful in 1m3s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m39s
Details
YAML Linter / YAML Linter (pull_request) Successful in 7m46s
Details
Test Packaging / Test Packaging (pull_request) Successful in 22m6s
Details
This pull request is broken due to missing fork information.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Area/Accessibility
Area: Accessibility settings and features.

  
Area/Admin Tooling
Area: Admin tooling and moderation

  
Area/Art
Area: Art with no implications for other areas.

  
Area/Atmospherics
Area: Atmospherics

  
Area/Cargo
Area: Cargo department and related mechanics

  
Area/Character / Species
Area: Player characters and species features and content.

  
Area/Chat
Area: Chat-related features and changes, most likely technical.

  
Area/Combat
Area: Combat features, changes, balancing.

  
Area/Command
Area: Command department, where it isn't applicable to other departments.

  
Area/Database
Area: Changes to Database code.

  
Area/Engineering
Area: Engineering department, doesn't include Atmospherics.

  
Area/Graphics
Area: Changes to shaders or overlays.

  
Area/Guidebook
Area: Ingame guidebook, content or technical implementation.

  
Area/Mapping
Area: Maps, or tools used for mapping

  
Area/Medical
Area: Medical department, including Chemistr

  
Area/Preferences / Options
Area: Player preferences and options.

  
Area/Roleplay / Lore
Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics

  
Area/Roundflow / Antag
Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities.

  
Area/Rules
Area: Changes to Server rules, SoP, or Space Law.

  
Area/Salvage
Area: Salvage changes

  
Area/Science
Area: Science department, not including Silicons.

  
Area/Security
Area: Security department, including Detectives, HoS

  
Area/Service
Area: Service department, including cooking, botany, etc

  
Area/Silicons
Area: Relates to Silicon roles, including AI.

  
bug
This is in regards to a bug.

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
DON'T MERGE
This is under review, fixes, or needs significant changes.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
Note/Port
A port from another repository.

  
Note/Upstream
A PR from upstream.

  
Priority
Critical
 Critical priority task!!

  
Priority
High
 High priority task

  
Priority
Low
 Low priority task

  
Priority
Normal
 Normal priority task

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
State/Approved
This PR has been approved.

  
State/invalid
This doesn't seem right

  
State/Merge Conflict

   
State/Needs Changes
Changes/Concerns have been brought up and should be made before review.

  
State/Needs Discussion
Discussion needed for changes, talk about it.

  
State/Untriaged

   
Type/Balance Change
Changes something in the game related to balancing.

  
Type/Bugfix
Fixes a known issue/bug.

  
Type/Documentation
Makes changes to documentation in the repository. This includes attributions changes.

  
Type/Enhancement
New feature or request, change to game.

  
Type/Feature
Adds completely new stuff to the game.

  
Type/Question
Further information is requested.

  
wontfix
This will not be worked on

No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!949
No description provided.