ALTERNATE JOB TITLES #964
No reviewers
Labels
No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Byrd-Station/Byrd!964
Loading…
Reference in a new issue
No description provided.
Delete branch "nukies/alternate-job-titles"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Short description
porting alternate job titles from omu (from funky)
https://github.com/ProjectOmu/OmuStation/pull/1736
Why we need to add this
mmmmm... larp names
Media (Video/Screenshots)
see below
Checklist
almost finished with the port, spent 2 hours but ill make sure everythings 100% working after i sleep
158b7f3713e74b230871WIP: alternate job titlesto ALTERNATE JOB TITLESThat looks great, well done!
I think we should make sure that all old job titles via the PDA system are represented in the new system: For example passenger should get all of the other job titles too (off-duty, visitor, assistant, ...) and then also remove all the duplicate PDAs.
Here are a couple bugs I found with the two systems coexisting:
When selecting PDA with a custom job title it shows the character name as "Unknown" (Long standing bug but a good reason why we should make sure to replace it with the new job title system):

On top of that it overwrites the selected job title:

So in my opinion:
Also remember to add this hotfix so all job titles actually show up properly.
Inside the
[ic]section inResources/ConfigPresets/_Byrd/ByrdConfig.tomladd:And another small nitpick, it looks like right click -> debug -> set outfit doesn't set the job title properly:

@QuillTheCreature wrote in #964 (comment):
images dont load, and personally i dont want to really touch the rest of the systems just incase i break it, im quite shit at c# so its better if this gets merged & someone fixes it after myself
@QuillTheCreature wrote in #964 (comment):
will do this now
Hey hey! This has a merge conflict, please update the branch. Thank you :)
it still says to resolve it but i manually did it, dunno
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.