ALTERNATE JOB TITLES #964

Open
nukies wants to merge 11 commits from nukies/alternate-job-titles into master AGit
First-time contributor

Short description

porting alternate job titles from omu (from funky)

https://github.com/ProjectOmu/OmuStation/pull/1736

Why we need to add this

mmmmm... larp names

Media (Video/Screenshots)

see below

Checklist

  • I do not require assistance to complete the PR.
  • I have verified that the changes work before posting/requesting review of my PR.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I have read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset.
### Short description porting alternate job titles from omu (from funky) [https://github.com/ProjectOmu/OmuStation/pull/1736](https://github.com/ProjectOmu/OmuStation/pull/1736) ## Why we need to add this mmmmm... larp names ## Media (Video/Screenshots) see below ## Checklist - [X] I do not require assistance to complete the PR. - [X] I have verified that the changes work before posting/requesting review of my PR. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I have read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset.
2.png
256 KiB
WIP: alternate job titles
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 43s
Labels: Size / size-label (pull_request_target) Failing after 43s
CRLF Check / CRLF Check (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
158b7f3713
Author
First-time contributor

almost finished with the port, spent 2 hours but ill make sure everythings 100% working after i sleep

almost finished with the port, spent 2 hours but ill make sure everythings 100% working after i sleep
nukies force-pushed nukies/alternate-job-titles from 158b7f3713
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 43s
Labels: Size / size-label (pull_request_target) Failing after 43s
CRLF Check / CRLF Check (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
to e74b230871
All checks were successful
Labels: Size / size-label (pull_request_target) Successful in 45s
Labels: PR / labeler (pull_request_target) Successful in 45s
CRLF Check / CRLF Check (pull_request) Has been skipped
Test Packaging / Test Packaging (pull_request) Has been skipped
RGA schema validator / YAML RGA schema validator (pull_request) Has been skipped
RSI Validator / Validate RSIs (pull_request) Successful in 1m10s
Map file schema validator / YAML map schema validator (pull_request) Has been skipped
YAML Linter / YAML Linter (pull_request) Has been skipped
2026-09-30 15:37:31 +00:00
Compare
nukies changed title from WIP: alternate job titles to ALTERNATE JOB TITLES 2026-09-30 15:38:40 +00:00
Member

That looks great, well done!

I think we should make sure that all old job titles via the PDA system are represented in the new system: For example passenger should get all of the other job titles too (off-duty, visitor, assistant, ...) and then also remove all the duplicate PDAs.

Here are a couple bugs I found with the two systems coexisting:

When selecting PDA with a custom job title it shows the character name as "Unknown" (Long standing bug but a good reason why we should make sure to replace it with the new job title system):
image

On top of that it overwrites the selected job title:
image

So in my opinion:

  • The job title should only be set via the new system
  • Any PDA change should just be cosmetic and not alter the job title at all
That looks great, well done! I think we should make sure that all old job titles via the PDA system are represented in the new system: For example passenger should get all of the other job titles too (off-duty, visitor, assistant, ...) and then also remove all the duplicate PDAs. Here are a couple bugs I found with the two systems coexisting: When selecting PDA with a custom job title it shows the character name as "Unknown" (Long standing bug but a good reason why we should make sure to replace it with the new job title system): ![image](/attachments/839d83d2-474d-4d97-a7b3-244a7b6fda47) On top of that it overwrites the selected job title: ![image](/attachments/4ce50af0-ee6d-4e30-a713-ae8b0573061a) So in my opinion: * The job title should only be set via the new system * Any PDA change should just be **cosmetic** and not alter the job title at all
Member

Also remember to add this hotfix so all job titles actually show up properly.

Inside the [ic] section in Resources/ConfigPresets/_Byrd/ByrdConfig.toml add:

id_job_length = 36 # Raised from 30
Also remember to [add this hotfix](https://github.com/ProjectOmu/OmuStation/pull/1821/changes) so all job titles actually show up properly. Inside the `[ic]` section in `Resources/ConfigPresets/_Byrd/ByrdConfig.toml` add: ``` id_job_length = 36 # Raised from 30 ```
Member

And another small nitpick, it looks like right click -> debug -> set outfit doesn't set the job title properly:
image

And another small nitpick, it looks like right click -> debug -> set outfit doesn't set the job title properly: ![image](/attachments/15a1f7aa-9156-4936-8a2e-aa09e31d4c29)
Author
First-time contributor

@QuillTheCreature wrote in #964 (comment):

That looks great, well done!

I think we should make sure that all old job titles via the PDA system are represented in the new system: For example passenger should get all of the other job titles too (off-duty, visitor, assistant, ...) and then also remove all the duplicate PDAs.

Here are a couple bugs I found with the two systems coexisting:

When selecting PDA with a custom job title it shows the character name as "Unknown" (Long standing bug but a good reason why we should make sure to replace it with the new job title system): image

On top of that it overwrites the selected job title: image

So in my opinion:

* The job title should only be set via the new system

* Any PDA change should just be **cosmetic** and not alter the job title at all

images dont load, and personally i dont want to really touch the rest of the systems just incase i break it, im quite shit at c# so its better if this gets merged & someone fixes it after myself

@QuillTheCreature wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/964#issuecomment-8320: > That looks great, well done! > > I think we should make sure that all old job titles via the PDA system are represented in the new system: For example passenger should get all of the other job titles too (off-duty, visitor, assistant, ...) and then also remove all the duplicate PDAs. > > Here are a couple bugs I found with the two systems coexisting: > > When selecting PDA with a custom job title it shows the character name as "Unknown" (Long standing bug but a good reason why we should make sure to replace it with the new job title system): [![image](/attachments/839d83d2-474d-4d97-a7b3-244a7b6fda47)](/Byrd-Station/Byrd/attachments/839d83d2-474d-4d97-a7b3-244a7b6fda47) > > On top of that it overwrites the selected job title: [![image](/attachments/4ce50af0-ee6d-4e30-a713-ae8b0573061a)](/Byrd-Station/Byrd/attachments/4ce50af0-ee6d-4e30-a713-ae8b0573061a) > > So in my opinion: > > * The job title should only be set via the new system > > * Any PDA change should just be **cosmetic** and not alter the job title at all images dont load, and personally i dont want to really touch the rest of the systems just incase i break it, im quite shit at c# so its better if this gets merged & someone fixes it after myself
Author
First-time contributor

@QuillTheCreature wrote in #964 (comment):

Also remember to add this hotfix so all job titles actually show up properly.

Inside the [ic] section in Resources/ConfigPresets/_Byrd/ByrdConfig.toml add:

id_job_length = 36 # Raised from 30

will do this now

@QuillTheCreature wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/964#issuecomment-8321: > Also remember to [add this hotfix](https://github.com/ProjectOmu/OmuStation/pull/1821/changes) so all job titles actually show up properly. > > Inside the `[ic]` section in `Resources/ConfigPresets/_Byrd/ByrdConfig.toml` add: > > ```text > id_job_length = 36 # Raised from 30 > ``` will do this now
Raise job title length limit
All checks were successful
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Successful in 4s
CRLF Check / CRLF Check (pull_request) Successful in 36s
Test Packaging / Test Packaging (pull_request) Successful in 13m39s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 46s
RSI Validator / Validate RSIs (pull_request) Successful in 44s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m18s
YAML Linter / YAML Linter (pull_request) Successful in 5m5s
15a63a6f0b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member

Hey hey! This has a merge conflict, please update the branch. Thank you :)

Hey hey! This has a merge conflict, please update the branch. Thank you :)
resolve conflict
All checks were successful
Labels: PR / labeler (pull_request_target) Successful in 3s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 34s
Test Packaging / Test Packaging (pull_request) Successful in 13m9s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 42s
RSI Validator / Validate RSIs (pull_request) Successful in 38s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m15s
YAML Linter / YAML Linter (pull_request) Successful in 4m36s
76374c30c0
Author
First-time contributor

it still says to resolve it but i manually did it, dunno

it still says to resolve it but i manually did it, dunno
All checks were successful
Labels: PR / labeler (pull_request_target) Successful in 3s
Labels: Size / size-label (pull_request_target) Successful in 3s
CRLF Check / CRLF Check (pull_request) Successful in 34s
Test Packaging / Test Packaging (pull_request) Successful in 13m9s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 42s
RSI Validator / Validate RSIs (pull_request) Successful in 38s
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m15s
YAML Linter / YAML Linter (pull_request) Successful in 4m36s
This pull request has changes conflicting with the target branch.
  • Content.Omu.Common/CCVar/CCVars.Omu.cs
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin "+refs/pull/964/head:nukies/alternate-job-titles"
git switch "nukies/alternate-job-titles"
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!964
No description provided.