Adjusted the spawn system for EOR to always spawn in CC and allows the player to spawn with a proper job in CC. #967

Merged
EchoOfNothing merged 1 commit from :systems/spawning/ccspawnfix into master 2026-10-05 20:10:55 +00:00
Member

Other Ideas

We could argue to not disallow normal station spawns on EOR, this is up to Byrd maints what you all want.

I'm fine with both ways, but I personally wanted to allow the player to wear whatever swag they want in EOR in the last <10 minutes.

Short description

This PR basically does two small things:

  • Allows a player to spawn with their selected role in CC, this means a player can spawn in as CCI/CCJ (or even whatever normal station job) even when the round is already over.
  • And instead of randomly rolling what station to spawn the player on when it's EOR, the system forces a CC spawn now.

Why we need to add this

It's a bit silly that the EOR late join system randomly fails, randomly puts the player onto the station, and randomly onto CC.

Media (Video/Screenshots)

Checklist

Breaking changes

Ingame Changelog

<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Other Ideas We could argue to not disallow normal station spawns on EOR, this is up to Byrd maints what you all want. I'm fine with both ways, but I personally wanted to allow the player to wear whatever swag they want in EOR in the last <10 minutes. ## Short description This PR basically does two small things: * Allows a player to spawn with their selected role in CC, this means a player can spawn in as CCI/CCJ (or even whatever normal station job) even when the round is already over. * And instead of randomly rolling what station to spawn the player on when it's EOR, the system forces a CC spawn now. ## Why we need to add this It's a bit silly that the EOR late join system randomly fails, randomly puts the player onto the station, and randomly onto CC. ## Media (Video/Screenshots) <video src="/attachments/46750eb7-97da-418e-8284-2c9621112998" title="Screencast_20260929_140517" controls></video> ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> ### Ingame Changelog <!--If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative.--> <!--:cl: - add: Added fun! - remove: Removed fun! - tweak: Changed fun! - fix: Fixed fun!-->
Adjusted the spawn system for EOR to always spawn in CC and allows the player to spawn with a proper job in CC.
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: Size / size-label (pull_request_target) Failing after 59s
Labels: PR / labeler (pull_request_target) Successful in 59s
RSI Validator / Validate RSIs (pull_request) Successful in 8m10s
CRLF Check / CRLF Check (pull_request) Successful in 10m30s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 10m21s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m21s
YAML Linter / YAML Linter (pull_request) Successful in 7m6s
Test Packaging / Test Packaging (pull_request) Successful in 24m11s
PR Changelogs / changelog (pull_request_target) Successful in 1m25s
42f39165a8
EchoOfNothing left a comment

LGTM. Thank you for your contribution!

LGTM. Thank you for your contribution!
Author
Member

Ack no changelog!

Ack no changelog!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!967
No description provided.