Roundstart live injectors #979

Floidinee · 2026-10-02T10:28:06Z

Floidinee commented

2026-10-02 10:28:06 +00:00

Short description

Adds a pre-filled disease injector that can be used for mapping.

ViroDrobes now contain one of these if their manager wire is cut.

Also added an injector with a 10000 complexity disease for admin use.

Why we need to add this

Virology doesn't really have anything to do until the disease outbreak event happens which sometimes does not occur at all.

This ensures there is always a disease to work with roundstart.

Media (Video/Screenshots)

Checklist

I do not require assistance to complete the PR.
I have verified that the changes work before posting/requesting review of my PR.
I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
I have read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset.

Ingame Changelog

🆑

add: Added a live injector to ViroDrobe secret inventory
ADMIN:
add: Added a disease injector with a 10000 complexity disease

Note

This is my very first contribution to SS14 and I am still unfamiliar with the coding conventions. Please do give feedback!

[guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description  Adds a pre-filled disease injector that can be used for mapping. ViroDrobes now contain one of these if their manager wire is cut. Also added an injector with a 10000 complexity disease for admin use. ## Why we need to add this  Virology doesn't really have anything to do until the disease outbreak event happens which sometimes does not occur at all. This ensures there is always a disease to work with roundstart. ## Media (Video/Screenshots)  <video src="/attachments/f5b2d2fc-2fde-452a-9e7d-a7817078f39e" title="aeiou" controls></video> ## Checklist  - [X] I do not require assistance to complete the PR. - [X] I have verified that the changes work before posting/requesting review of my PR. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog  :cl: - add: Added a live injector to ViroDrobe secret inventory **ADMIN:** - add: Added a disease injector with a 10000 complexity disease ### Note This is my very first contribution to SS14 and I am still unfamiliar with the coding conventions. Please do give feedback!

aeiou.mp4

5.6 MiB

Floidinee added 9 commits

2026-10-02 10:28:06 +00:00

Automatic changelog update (#954 ) 4c436fdde6

add FilledLiveInjector 27b503532e

add FilledLiveInjector to virodrobe 48516b7bd3

small fix 6fa4301902

add uber cancer injector 6fddea2cd1

aeiou 86f4b8b35c

revert 4c436fdde6 bd1f12565f

revert Automatic changelog update (#954)

minor comment changes 04eaaad5ec

Merge branch 'filledliveinjectors' of https://git.byrdstation.space/Floidinee/Byrd-but-EVIL into filledliveinjectors

Close PRs on master / run (pull_request_target) Has been skipped

Details

Labels: Size / size-label (pull_request_target) Failing after 3s

Details

Labels: PR / labeler (pull_request_target) Successful in 3s

Details

CRLF Check / CRLF Check (pull_request) Successful in 1m22s

Details

Test Packaging / Test Packaging (pull_request) Successful in 13m15s

Details

RGA schema validator / YAML RGA schema validator (pull_request) Successful in 47s

Details

RSI Validator / Validate RSIs (pull_request) Failing after 45s

Details

Map file schema validator / YAML map schema validator (pull_request) Successful in 5m18s

Details

YAML Linter / YAML Linter (pull_request) Successful in 4m48s

Details

2c54f6bb20

EchoOfNothing reviewed

2026-10-07 15:57:53 +00:00

Content.Goobstation.Server/Disease/DiseaseSystem.cs Outdated

					
				@ -78,0 +80,4 @@

				            // Byrd begin

				            if (TryComp<DiseasePenComponent>(ent, out var diseasePenComp))

				            {

				                if (diseasePenComp.IsFilled == true)

You can merge those two if statements, if statement ladders are a little ugly in my opinion.
Also == true is kind of a redundant comparison, since it's implied if you have a boolean as a condition in a control structure.

You can merge those two if statements, if statement ladders are a little ugly in my opinion. Also `== true` is kind of a redundant comparison, since it's implied if you have a boolean as a condition in a control structure.

EchoOfNothing marked this conversation as resolved

Content.Goobstation.Server/Disease/DiseaseSystem.cs Outdated

					
				@ -78,0 +84,4 @@

				                {

				                    diseasePenComp.DiseaseUid = disease;

				                    diseasePenComp.Genotype = diseaseComp.Genotype;

				                    return;

There is no reason to have return here

There is no reason to have `return` here

return is actually needed here since l.90

if (!TryInfect(ent.Owner, disease.Value))
QueueDel(disease);

would delete the newly created disease as there is nothing to infect when spawning the pen (see screenshot)

`return` is actually needed here since l.90 `if (!TryInfect(ent.Owner, disease.Value))` ` QueueDel(disease);` would delete the newly created disease as there is nothing to infect when spawning the pen (see screenshot)

Screenshot 2026-10-08 165641.png

72 KiB

EchoOfNothing marked this conversation as resolved

Content.Goobstation.Shared/Virology/DiseasePenComponent.cs Outdated

					
				@ -26,1 +26,4 @@

				    public TimeSpan InjectTime = TimeSpan.FromSeconds(8);

				    [DataField]

				    public bool IsFilled = false;  // Byrd

Name IsFilled can be a little misleading in this case, so you should rename this to something like fillWithRandomDisease, it doesn't have to be exactly this name, you can try to find an even better one.

Name `IsFilled` can be a little misleading in this case, so you should rename this to something like `fillWithRandomDisease`, it doesn't have to be exactly this name, you can try to find an even better one.

EchoOfNothing marked this conversation as resolved

EchoOfNothing commented

2026-10-07 15:58:06 +00:00

@Floidinee
You can also use categories for change logs like so:

:cl:
- add: Added a live injector to ViroDrobe secret inventory
**ADMIN:**
- add: Added an injector with a 10000 complexity disease

@Floidinee You can also use categories for change logs like so: ``` :cl: - add: Added a live injector to ViroDrobe secret inventory **ADMIN:** - add: Added an injector with a 10000 complexity disease ```

EchoOfNothing reviewed

2026-10-07 16:08:17 +00:00

Resources/Prototypes/_Goobstation/Entities/Specific/Medical/disease.yml Outdated

Lines 29-31

					
				@ -24,0 +26,6 @@

				- type: entity

				  parent: LiveInjector

				  id: FilledLiveInjector

				  name: live injector

				  suffix: random disease

				  description: Injects people with a disease.

If you don't set name or description it will be inherited from the parent. And since you don't modify neither name nor description might as well inherit them.

If you don't set `name` or `description` it will be inherited from the parent. And since you don't modify neither `name` nor `description` might as well inherit them.

Floidinee added 1 commit

2026-10-08 14:59:13 +00:00

remove redundancies, rename IsFilled to ContainsRandomDisease

Labels: PR / labeler (pull_request_target) Failing after 51s

Details

Labels: Size / size-label (pull_request_target) Successful in 48s

Details

CRLF Check / CRLF Check (pull_request) Successful in 37s

Details

RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled

Details

RSI Validator / Validate RSIs (pull_request) Has been cancelled