Byrd-Station/Byrd
Byrd-Station/Byrd
Watch
4
5
Fork
You've already forked Byrd
 22
Code Issues 33 Pull requests 35 Projects 1 Wiki Activity Actions 37

WIP: Fixing Shadowkin default speeds + more #982

Draft
orangeAlligator wants to merge 3 commits from orangeAlligator/Byrd:leg-day into master
pull from: orangeAlligator/Byrd:leg-day
merge into: Byrd-Station:master
Conversation 8 Commits 3 Files changed 13 +60 -18
orangeAlligator commented 2026-10-02 23:06:31 +00:00
Contributor

Short description

Moves some values from MovementSpeedModifier to MovementBodyPartComponent, so shadowkin actually move at their intended walk and sprint speeds.

Why we need to add this

Fulfilling a task + closes #951 + also Closes: #1039

Media (Video/Screenshots)

Checklist

Breaking changes

Ingame Changelog

🆑

  • fix: Species get their speed + weightless values from their legs properly
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Moves some values from `MovementSpeedModifier` to `MovementBodyPartComponent`, so shadowkin actually move at their intended walk and sprint speeds. ## Why we need to add this Fulfilling a task + closes #951 + also Closes: #1039 ## Media (Video/Screenshots) ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [ ] I do not require assistance to complete the PR. - [X] I have verified that the changes work before posting/requesting review of my PR. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> ### Ingame Changelog :cl: - fix: Species get their speed + weightless values from their legs properly
shadowkin speed fixed
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Details
Labels: PR / labeler (pull_request_target) Successful in 8s
Details
Labels: Size / size-label (pull_request_target) Failing after 5s
Details
CRLF Check / CRLF Check (pull_request) Successful in 1m4s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m5s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 1m22s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m47s
Details
YAML Linter / YAML Linter (pull_request) Successful in 7m48s
Details
Test Packaging / Test Packaging (pull_request) Successful in 17m30s
Details
5915004f88
orangeAlligator changed title from Fixing Shadowkin and friends' default speeds to Fixing Shadowkin default speeds 2026-10-02 23:08:43 +00:00
QuillTheCreature commented 2026-10-03 13:51:55 +00:00
Member

Harpies have one too which don't get applied:

  - type: MovementSpeedModifier
    weightlessAcceleration: 2.5
    weightlessModifier: 1.12
Harpies have one too which don't get applied: ```yml - type: MovementSpeedModifier weightlessAcceleration: 2.5 weightlessModifier: 1.12 ```
EchoOfNothing commented 2026-10-04 09:41:31 +00:00
Owner

@orangeAlligator

tweak: Shadowkin now move at their intended speed (slightly faster.)

This should probably be a fix

Also add Closes: #951 under Why we need to add this.

@orangeAlligator > `tweak: Shadowkin now move at their intended speed (slightly faster.)` This should probably be a `fix` Also add `Closes: #951` under `Why we need to add this`.
👍 1
adds values for moths and harpies, tries to add more to the component but doesn't
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 1m23s
Details
Labels: Size / size-label (pull_request_target) Successful in 1m23s
Details
CRLF Check / CRLF Check (pull_request) Successful in 2m14s
Details
RSI Validator / Validate RSIs (pull_request) Failing after 1m41s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m58s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 8m2s
Details
YAML Linter / YAML Linter (pull_request) Successful in 7m38s
Details
Test Packaging / Test Packaging (pull_request) Successful in 17m18s
Details
86857bef21
it works! maybe?
Some checks failed
RSI Validator / Validate RSIs (pull_request) Failing after 9s
Details
Map file schema validator / YAML map schema validator (pull_request) Failing after 9s
Details
YAML Linter / YAML Linter (pull_request) Failing after 9s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Failing after 9s
Details
Test Packaging / Test Packaging (pull_request) Failing after 9s
Details
CRLF Check / CRLF Check (pull_request) Failing after 9s
Details
Labels: Size / size-label (pull_request_target) Failing after 9s
Details
Labels: PR / labeler (pull_request_target) Failing after 9s
Details
3944bfda36
orangeAlligator changed title from Fixing Shadowkin default speeds to Fixing Shadowkin default speeds + more 2026-10-12 00:07:13 +00:00
orangeAlligator commented 2026-10-12 00:18:39 +00:00
Author
Contributor

i'm sure every check failing is fine

i'm sure every check failing is fine
QuillTheCreature commented 2026-10-22 10:56:31 +00:00
Member

Here's what Omu is planning to do: https://github.com/ProjectOmu/OmuStation/pull/2052

Here's what Omu is planning to do: https://github.com/ProjectOmu/OmuStation/pull/2052
QuillTheCreature reviewed 2026-10-22 11:01:13 +00:00
Content.Shared/Movement/Systems/MovementSpeedModifierSystem.cs
@ -122,3 +122,3 @@
}
public void ChangeBaseSpeed(EntityUid uid, float baseWalkSpeed, float baseSprintSpeed, float acceleration, MovementSpeedModifierComponent? move = null)
public void ChangeBaseSpeed(EntityUid uid, float baseWalkSpeed, float baseSprintSpeed, float acceleration, float weightlessAcceleration, float weightlessFriction, float weightlessModifier, MovementSpeedModifierComponent? move = null)
QuillTheCreature commented 2026-10-22 11:01:13 +00:00
Member

This kind of warrants to add this to the break change list but I'm not sure how well the list is maintained in Byrd 🤷

This kind of warrants to add this to the break change list but I'm not sure how well the list is maintained in Byrd 🤷
orangeAlligator commented 2026-10-23 07:38:07 +00:00
Author
Contributor

@QuillTheCreature wrote in #982 (comment):

Here's what Omu is planning to do: https://github.com/ProjectOmu/OmuStation/pull/2052

honestly, if omu's putting in a more complete fix, i don't mind closing this up

@QuillTheCreature wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/982#issuecomment-9275: > Here's what Omu is planning to do: https://github.com/ProjectOmu/OmuStation/pull/2052 honestly, if omu's putting in a more complete fix, i don't mind closing this up
QuillTheCreature commented 2026-10-23 15:12:55 +00:00
Member

Yeah let's see what solution they're figuring out and wait until it's merged there, then discuss what we want to do here.

Yeah let's see what solution they're figuring out and wait until it's merged there, then discuss what we want to do here.
orangeAlligator changed title from Fixing Shadowkin default speeds + more to WIP: Fixing Shadowkin default speeds + more 2026-10-28 22:54:22 +00:00
QuillTheCreature commented 2026-10-28 22:55:12 +00:00
Member

Yeah i think this looks like a good way of doing it, let's just pull in the changes from upstream. I also like the other adjustments it did.

Yeah i think this looks like a good way of doing it, let's just pull in the changes from upstream. I also like the other adjustments it did.
Some checks failed
RSI Validator / Validate RSIs (pull_request) Failing after 9s
Details
Map file schema validator / YAML map schema validator (pull_request) Failing after 9s
Details
YAML Linter / YAML Linter (pull_request) Failing after 9s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Failing after 9s
Details
Test Packaging / Test Packaging (pull_request) Failing after 9s
Details
CRLF Check / CRLF Check (pull_request) Failing after 9s
Details
Labels: Size / size-label (pull_request_target) Failing after 9s
Details
Labels: PR / labeler (pull_request_target) Failing after 9s
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u "leg-day:orangeAlligator-leg-day"
git switch "orangeAlligator-leg-day"
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Area/Accessibility
Area: Accessibility settings and features.

  
Area/Admin Tooling
Area: Admin tooling and moderation

  
Area/Art
Area: Art with no implications for other areas.

  
Area/Atmospherics
Area: Atmospherics

  
Area/Cargo
Area: Cargo department and related mechanics

  
Area/Character / Species
Area: Player characters and species features and content.

  
Area/Chat
Area: Chat-related features and changes, most likely technical.

  
Area/Combat
Area: Combat features, changes, balancing.

  
Area/Command
Area: Command department, where it isn't applicable to other departments.

  
Area/Database
Area: Changes to Database code.

  
Area/Engineering
Area: Engineering department, doesn't include Atmospherics.

  
Area/Graphics
Area: Changes to shaders or overlays.

  
Area/Guidebook
Area: Ingame guidebook, content or technical implementation.

  
Area/Mapping
Area: Maps, or tools used for mapping

  
Area/Medical
Area: Medical department, including Chemistr

  
Area/Preferences / Options
Area: Player preferences and options.

  
Area/Roleplay / Lore
Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics

  
Area/Roundflow / Antag
Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities.

  
Area/Rules
Area: Changes to Server rules, SoP, or Space Law.

  
Area/Salvage
Area: Salvage changes

  
Area/Science
Area: Science department, not including Silicons.

  
Area/Security
Area: Security department, including Detectives, HoS

  
Area/Service
Area: Service department, including cooking, botany, etc

  
Area/Silicons
Area: Relates to Silicon roles, including AI.

  
bug
This is in regards to a bug.

  
Changes: Audio

   
Changes: Map

   
Changes: No C#

   
Changes: Sprites

   
Changes: UI

   
documentation
Improvements or additions to documentation

  
DON'T MERGE
This is under review, fixes, or needs significant changes.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
holding to vote
This is currently being voted for by the Byrds.

  
Note/Port
A port from another repository.

  
Note/Upstream
A PR from upstream.

  
Priority
Critical
 Critical priority task!!

  
Priority
High
 High priority task

  
Priority
Low
 Low priority task

  
Priority
Normal
 Normal priority task

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
State/Approved
This PR has been approved.

  
State/invalid
This doesn't seem right

  
State/Merge Conflict

   
State/Needs Changes
Changes/Concerns have been brought up and should be made before review.

  
State/Needs Discussion
Discussion needed for changes, talk about it.

  
State/Untriaged

   
Type/Balance Change
Changes something in the game related to balancing.

  
Type/Bugfix
Fixes a known issue/bug.

  
Type/Documentation
Makes changes to documentation in the repository. This includes attributions changes.

  
Type/Enhancement
New feature or request, change to game.

  
Type/Feature
Adds completely new stuff to the game.

  
Type/Question
Further information is requested.

  
wontfix
This will not be worked on

No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!982
No description provided.