Added more blood types to slaughter demons #992

Closed

QuillTheCreature wants to merge 0 commits from (deleted):entities/slaughterdemon/morebloodtypes into master

pull from: (deleted):entities/slaughterdemon/morebloodtypes

merge into: Byrd-Station:master

Byrd-Station:master

Byrd-Station:automated-upstream-branch

Byrd-Station:sens-pref-20260831

Byrd-Station:rsi-diff-20260815

Byrd-Station:resomi

Byrd-Station:radio-rework-20260708

Byrd-Station:scriphud

Byrd-Station:anomalocarids

Conversation 5 Commits - Files changed - +367 -357

QuillTheCreature commented 2026-10-04 11:57:32 +00:00

Member

• Copy link
• Copy Markdown

Short description

I added (I think) most other common blood types used for the slaughter demons jaunt.

This refactors how the reagent group field is done, now allowing a reagent to be in multiple groups.
Therefore, the SD just needs to specify a reagent group now (Blood) instead of needing to list every blood reagent multiple times.

Why we need to add this

Bugfix.

Media (Video/Screenshots)

Checklist

• I do not require assistance to complete the PR.
• I have verified that the changes work before posting/requesting review of my PR.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I have read the Pull Request and Changelog Guidelines and Byrd Station's Contributor Ruleset.

Ingame Changelog

🆑 Quill

• fix: Added most other blood types for the slaughter demon to jaunt on.

<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description I added (I think) most other common blood types used for the slaughter demons jaunt. This refactors how the reagent group field is done, now allowing a reagent to be in multiple groups. Therefore, the SD just needs to specify a reagent group now (Blood) instead of needing to list every blood reagent multiple times. ## Why we need to add this Bugfix. ## Media (Video/Screenshots) <video src="/attachments/5f19f674-56ca-4ccf-9e06-f6fcf91f580c" title="Screencast_20261004_135040" controls></video> ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - fix: Added most other blood types for the slaughter demon to jaunt on.

Screencast_20261004_135040.webm

2.3 MiB

QuillTheCreature added 1 commit 2026-10-04 11:57:32 +00:00

Added more blood types to slaughter demons cdc2cdcb1b

byrdbot added the

Changes: No C#

label 2026-10-04 11:57:37 +00:00

QuillTheCreature force-pushed entities/slaughterdemon/morebloodtypes from cdc2cdcb1b to 9d0868f248 2026-10-04 19:07:09 +00:00 Compare

byrdbot added the

Changes: UI

label 2026-10-04 19:08:21 +00:00

EchoOfNothing reviewed 2026-10-06 20:33:26 +00:00

EchoOfNothing left a comment

• Copy link
• Copy Markdown

Blood reagent doesn't have Blood group

`Blood` reagent doesn't have `Blood` group

😆 1

QuillTheCreature added 1 commit 2026-10-06 21:12:06 +00:00

It'd be great if blood would be in the blood group 55c96ee349

QuillTheCreature commented 2026-10-06 21:12:40 +00:00

Author

Member

• Copy link
• Copy Markdown

@EchoOfNothing wrote in #992 (comment):

Blood reagent doesn't have Blood group

Yeah you know, that'd be good.

@EchoOfNothing wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/992#issuecomment-8566: > `Blood` reagent doesn't have `Blood` group Yeah you know, that'd be good.

EchoOfNothing approved these changes 2026-10-07 20:15:54 +00:00

EchoOfNothing left a comment

• Copy link
• Copy Markdown

LGTM. Thank you for your contribution!

LGTM. Thank you for your contribution!

EchoOfNothing added the

size/M

label 2026-10-07 20:16:04 +00:00

QuillTheCreature added 1 commit 2026-10-07 23:03:41 +00:00

Fixed yaml linter by converting all reagent group to arrays d8026aa786

QuillTheCreature commented 2026-10-07 23:06:19 +00:00

Author

Member

• Copy link
• Copy Markdown

Fixed all yaml linter errors by writing a horrible piece of code.

For future references: Program

Fixed all yaml linter errors by writing a horrible piece of code. For future references: [Program](/attachments/453776f1-4517-473f-9948-06d22a642f41)

Program.txt

2.3 KiB

EchoOfNothing commented 2026-10-08 19:36:56 +00:00

Owner

• Copy link
• Copy Markdown

@QuillTheCreature
This pull request is broken due to missing fork information.

@QuillTheCreature `This pull request is broken due to missing fork information.`

QuillTheCreature referenced this pull request 2026-10-08 19:58:04 +00:00

Added more blood types to slaughter demons #1021

QuillTheCreature closed this pull request 2026-10-08 19:58:06 +00:00

Some checks failed

Hide checks

Close PRs on master / run (pull_request_target) Has been skipped

Details

PR Changelogs / changelog (pull_request_target) Has been skipped

Details

Labels: PR / labeler (pull_request_target) Successful in 5s

Details

Labels: Size / size-label (pull_request_target) Failing after 4s

Details

CRLF Check / CRLF Check (pull_request) Successful in 34s

Details

Test Packaging / Test Packaging (pull_request) Successful in 13m13s

Details

RGA schema validator / YAML RGA schema validator (pull_request) Successful in 41s

Details

RSI Validator / Validate RSIs (pull_request) Successful in 45s

Details

Map file schema validator / YAML map schema validator (pull_request) Successful in 5m15s

Details

YAML Linter / YAML Linter (pull_request) Successful in 4m56s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

EchoOfNothing

Labels

Clear labels   

Area/Accessibility

Area: Accessibility settings and features.

  

Area/Admin Tooling

Area: Admin tooling and moderation

  

Area/Art

Area: Art with no implications for other areas.

  

Area/Atmospherics

Area: Atmospherics

  

Area/Cargo

Area: Cargo department and related mechanics

  

Area/Character / Species

Area: Player characters and species features and content.

  

Area/Chat

Area: Chat-related features and changes, most likely technical.

  

Area/Combat

Area: Combat features, changes, balancing.

  

Area/Command

Area: Command department, where it isn't applicable to other departments.

  

Area/Database

Area: Changes to Database code.

  

Area/Engineering

Area: Engineering department, doesn't include Atmospherics.

  

Area/Graphics

Area: Changes to shaders or overlays.

  

Area/Guidebook

Area: Ingame guidebook, content or technical implementation.

  

Area/Mapping

Area: Maps, or tools used for mapping

  

Area/Medical

Area: Medical department, including Chemistr

  

Area/Preferences / Options

Area: Player preferences and options.

  

Area/Roleplay / Lore

Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics

  

Area/Roundflow / Antag

Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities.

  

Area/Rules

Area: Changes to Server rules, SoP, or Space Law.

  

Area/Salvage

Area: Salvage changes

  

Area/Science

Area: Science department, not including Silicons.

  

Area/Security

Area: Security department, including Detectives, HoS

  

Area/Service

Area: Service department, including cooking, botany, etc

  

Area/Silicons

Area: Relates to Silicon roles, including AI.

  

bug

This is in regards to a bug.

  

Changes: Audio

  

Changes: Map

  

Changes: No C#

  

Changes: Sprites

  

Changes: UI

  

documentation

Improvements or additions to documentation

  

DON'T MERGE

This is under review, fixes, or needs significant changes.

  

duplicate

This issue or pull request already exists

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

holding to vote

This is currently being voted for by the Byrds.

  

Note/Port

A port from another repository.

  

Note/Upstream

A PR from upstream.

  

Priority

Critical

Critical priority task!!

  

Priority

High

High priority task

  

Priority

Low

Low priority task

  

Priority

Normal

Normal priority task

  

size/L

  

size/M

  

size/S

  

size/XL

  

size/XS

  

State/Approved

This PR has been approved.

  

State/invalid

This doesn't seem right

  

State/Merge Conflict

  

State/Needs Changes

Changes/Concerns have been brought up and should be made before review.

  

State/Needs Discussion

Discussion needed for changes, talk about it.

  

State/Untriaged

  

Type/Balance Change

Changes something in the game related to balancing.

  

Type/Bugfix

Fixes a known issue/bug.

  

Type/Documentation

Makes changes to documentation in the repository. This includes attributions changes.

  

Type/Enhancement

New feature or request, change to game.

  

Type/Feature

Adds completely new stuff to the game.

  

Type/Question

Further information is requested.

  

wontfix

This will not be worked on

No labels

Area/Accessibility

Area/Admin Tooling

Area/Art

Area/Atmospherics

Area/Cargo

Area/Character / Species

Area/Chat

Area/Combat

Area/Command

Area/Database

Area/Engineering

Area/Graphics

Area/Guidebook

Area/Mapping

Area/Medical

Area/Preferences / Options

Area/Roleplay / Lore

Area/Roundflow / Antag

Area/Rules

Area/Salvage

Area/Science

Area/Security

Area/Service

Area/Silicons

bug

Changes: Audio

Changes: Map

Changes: No C#

Changes: Sprites

Changes: UI

documentation

DON'T MERGE

duplicate

good first issue

help wanted

holding to vote

Note/Port

Note/Upstream

Priority

Critical

Priority

High

Priority

Low

Priority

Normal

size/L

size/M

size/S

size/XL

size/XS

State/Approved

State/invalid

State/Merge Conflict

State/Needs Changes

State/Needs Discussion

State/Untriaged

Type/Balance Change

Type/Bugfix

Type/Documentation

Type/Enhancement

Type/Feature

Type/Question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Byrd-Station/Byrd!992

No description provided.