Pulled latest cyberbeast mantle changes from upstream #1061

Open
QuillTheCreature wants to merge 7 commits from QuillTheCreature/Byrd:species/cyberbeasts/mantlefixes into master
Member

Short description

Pulled in:

Why we need to add this

Upstream changes to cyberbeast mantles

Checklist

Ingame Changelog

🆑 Quill

  • add: Added a spaceproof sec/corpsman vulp mantle, craft it using a work mantle and a sec/medsec hud
  • fix: Mantles with flash protection now correctly protect your eyes from the experimental welding tool
  • add: Added the Roboticist roundstart mantle & Researchable Janitorial mantle (has cleanhud)
  • tweak: all mantles now have at least 10% Blunt/Slash/Pierce to help accommodate for the lack of wearing glasses and a face mask
  • fix: removed the ChamelonWhitelist tag for all mantles due to a bug with the eyes not being coloured correctly when worn
  • add: Added radiation protection to the engineering and atmospheric mantles.
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description Pulled in: * https://github.com/ProjectOmu/OmuStation/pull/1194 * https://github.com/ProjectOmu/OmuStation/pull/1371 * https://github.com/ProjectOmu/OmuStation/pull/1417 * https://github.com/ProjectOmu/OmuStation/pull/1613 ## Why we need to add this Upstream changes to cyberbeast mantles ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - add: Added a spaceproof sec/corpsman vulp mantle, craft it using a work mantle and a sec/medsec hud - fix: Mantles with flash protection now correctly protect your eyes from the experimental welding tool - add: Added the Roboticist roundstart mantle & Researchable Janitorial mantle (has cleanhud) - tweak: all mantles now have at least 10% Blunt/Slash/Pierce to help accommodate for the lack of wearing glasses and a face mask - fix: removed the ChamelonWhitelist tag for all mantles due to a bug with the eyes not being coloured correctly when worn - add: Added radiation protection to the engineering and atmospheric mantles.
* Add mantle textures for janitor and roboticist

* Added two mantles and contraband restrictions

Added fully functional roboticist & janitorial mantles. Jani mantle can be crafted at a service lathe after AdvancedCleaning has been researched (advanced mop and similar items)
Added BaseBartenderContraband in Resources\Prototypes\Entities\Objects\base_contraband.yml
Updated a lot of descriptions and added 10% slash/blunt/pierce to most variants.
Added contraband restrictions to most mantle variants
Commented out the WhitelistChameleon tag due to a bug with the eyes
Roboticist will now spawn with the appropriate mantle! (ROBOTICISTS REJOICE!)

* Requested changes

Changes requested by CliveOcelot

* indentation fix

* indentation fix?

* Update mantles.yml

fix to the tags

* Requested changes from @raincally & @Toaster-Box

[Removed the caps in names](https://github.com/ProjectOmu/OmuStation/pull/1371#discussion_r3739429015)
[moved 115 - 118 out of the component toggler](https://github.com/ProjectOmu/OmuStation/pull/1371#discussion_r3739645375)
[readded 176's comment](https://github.com/ProjectOmu/OmuStation/pull/1371#discussion_r3739218293)
[removed chemist's ShowHealthBars line at 496](https://github.com/ProjectOmu/OmuStation/pull/1371#discussion_r3739155931)
(removed all # Omu comments from the file since i'm working in the _omu namespace)[https://github.com/ProjectOmu/OmuStation/pull/1371#issuecomment-5222859319}

* YMLslop to the max

I honestly have no idea or consistent philosophy of what the fuck I did here. This is TRUE yml slop. Fixed https://github.com/ProjectOmu/OmuStation/pull/1371#pullrequestreview-4884092115

* removed duplicate BaseSecurityCommandContraband

YML Linter is a bitch :D

* Update Resources/Prototypes/_Omu/Entities/Clothing/Head/mantles.yml

Co-authored-by: CliveOcelot <165305605+CliveOcelot@users.noreply.github.com>

---------

Co-authored-by: CliveOcelot <165305605+CliveOcelot@users.noreply.github.com>

(cherry picked from commit 728db6783b04893b2cbb30f6a51a7333bd33b33a)
(cherry picked from commit 4de99a4133b8cd78f8cd4fa178213277241c5ea7)
* goopgoopgoopgoop

* crafting menu and corpsman mantle

* yall irritate me

(cherry picked from commit 69ae115bb43b6416615ad75726f3d9e6f33c5c84)
Revert "Added Veteran Sec Mantle for Sergeant #858"
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 26s
Labels: Size / size-label (pull_request_target) Failing after 21s
CRLF Check / CRLF Check (pull_request) Failing after 26s
Diff RSIs / Diff (pull_request) Failing after 13s
Test Packaging / Test Packaging (pull_request) Failing after 9m9s
RGA schema validator / YAML RGA schema validator (pull_request) Failing after 19s
RSI Validator / Validate RSIs (pull_request) Failing after 27s
Map file schema validator / YAML map schema validator (pull_request) Failing after 1m47s
YAML Linter / YAML Linter (pull_request) Failing after 33s
a2e6e6f97d
This reverts commit 1941fd48c3.
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 26s
Labels: Size / size-label (pull_request_target) Failing after 21s
CRLF Check / CRLF Check (pull_request) Failing after 26s
Diff RSIs / Diff (pull_request) Failing after 13s
Test Packaging / Test Packaging (pull_request) Failing after 9m9s
RGA schema validator / YAML RGA schema validator (pull_request) Failing after 19s
RSI Validator / Validate RSIs (pull_request) Failing after 27s
Map file schema validator / YAML map schema validator (pull_request) Failing after 1m47s
YAML Linter / YAML Linter (pull_request) Failing after 33s
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u "species/cyberbeasts/mantlefixes:QuillTheCreature-species/cyberbeasts/mantlefixes"
git switch "QuillTheCreature-species/cyberbeasts/mantlefixes"
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!1061
No description provided.