Stainable improvements #922

Merged
EchoOfNothing merged 36 commits from :features/stains/togglesandmorestates into master 2026-10-02 07:45:03 +00:00
Member

Short description

  • The stainable system can now work with clothes which have different equipped states.
  • Doubled the amount of liquid a clothing stain can hold.
  • Stains can now be cleaned with towels without needing to unequip the clothes.
  • Changed the cleanse delay to 2 seconds from 5 seconds.
  • Clothing stains are able to show different sprites based on how much of a solution is on the clothes.
  • Added 5 states ("0%", 25%, 50%, 75%, 100%) to every stain version.
  • Footprints now also use the shoes solution and therefore clean themselves after a while. This closes #925
  • Players can clean other players clothes with towels now too.
  • Added states for:
    • Cloaks
    • Mantles
    • Glasses
  • Updated states to fit the shape better:
    • Facemasks (Both up and down)
    • (Medical) breath masks
    • Bandanas
    • Hats
    • Berets
    • Boxer
    • Jumpsuits and skirts now have a folded state
  • Deleted states:
    • Gas mask when they're pulled down

Why we need to add this

Age old complaints about the stainable system and new sprites which fit better.

Additionally, the new towel feature is there so plasmamans don't need to die when they want to be clean.

Media (Video/Screenshots)

Shoe footprints

Stain severity system

Towel stain removal system

Towel stain removal on other players via the strip menu

Facemask

image

Facemask pulled down

image

Hats

image

Glasses

image

Bandanas

image

Mantles

image

Cloaks

image

Berets

image

Boxer

image

Gas Mask

Jumpsuit folded

image

Checklist

Ingame Changelog

🆑 Quill

  • add: Towels can now remove stains from your own clothes and from other players clothes via the strip menu.
  • add: Added clothing stains to cloaks, mantles, folded jumpsuits, folded jumpskirts, and pulled down masks.
  • add: Clothing stain severity now varies based on the amount of solution on clothing.
  • add: Shoes now clean themselves when leaving footprints behind.
  • tweak: Updated clothing stain appearance on face masks, breath masks, bandanas, hats, berets, and boxer shorts.
  • tweak: Reduced clothing stain cleanse delay from 5 seconds to 2 seconds.
  • tweak: Doubled the amount of units a clothing stain can hold.
  • fix: Stains now display correctly on face masks and gask masks when pulled down.
<!-- Link definitions, do not edit --> [guidelines]: https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html [ruleset]: https://rules.byrdstation.space/#h.vigrxrnffwji ## Short description * The stainable system can now work with clothes which have different equipped states. * Doubled the amount of liquid a clothing stain can hold. * Stains can now be cleaned with towels without needing to unequip the clothes. * Changed the cleanse delay to 2 seconds from 5 seconds. * Clothing stains are able to show different sprites based on how much of a solution is on the clothes. * Added 5 states ("0%", 25%, 50%, 75%, 100%) to every stain version. * Footprints now also use the shoes solution and therefore clean themselves after a while. This closes #925 * Players can clean other players clothes with towels now too. * Added states for: * Cloaks * Mantles * Glasses * Updated states to fit the shape better: * Facemasks (Both up and down) * (Medical) breath masks * Bandanas * Hats * Berets * Boxer * Jumpsuits and skirts now have a folded state * Deleted states: * Gas mask when they're pulled down ## Why we need to add this Age old complaints about the stainable system and new sprites which fit better. Additionally, the new towel feature is there so plasmamans don't need to die when they want to be clean. ## Media (Video/Screenshots) ### Shoe footprints <video src="/attachments/c737b0e4-6d3d-4daa-aa55-52cbc42f3bfe" title="Screencast_20260916_185530" controls></video> ### Stain severity system <video src="/attachments/a178aaf6-987d-4e07-800c-773b6e00ca92" title="Screencast_20260916_125236" controls></video> ### Towel stain removal system <video src="/attachments/6d0724f1-3e45-474a-8bdb-424a69a4c711" title="Screencast_20260915_225332" controls></video> ### Towel stain removal on other players via the strip menu <video src="/attachments/404012a2-48ce-4633-a30f-9210b422869d" title="Screencast_20260927_161444" controls></video> ### Facemask ![image](/attachments/456aeb72-c537-4931-a2eb-84560884ec1a) ### Facemask pulled down ![image](/attachments/ad852a64-d4d4-4051-bf18-f7d89a37dfd4) ### Hats ![image](/attachments/d5eae37f-c192-43f2-b5f6-a8d8e1a38abc) ### Glasses ![image](/attachments/e74ae7ac-60b7-4f76-b390-88f8277b5900) ### Bandanas ![image](/attachments/639ddc36-766f-44fb-89fb-6497db0194cb) ### Mantles ![image](/attachments/292deb4e-98ed-4c8a-a35e-2e60dd8cb898) ### Cloaks ![image](/attachments/c9967737-d2d1-452c-88d4-706c6905916a) ### Berets ![image](/attachments/a9c3165d-d482-48ab-a658-e7ad4b9f1fe7) ### Boxer ![image](/attachments/10446b7a-92e2-4ebe-8814-1b38d76c6ce4) ### Gas Mask <video src="/attachments/cd665d41-e262-416a-82af-d12b7bc5d0e5" title="Screencast_20260915_184458" controls></video> ### Jumpsuit folded ![image](/attachments/f8b0fc35-cc2f-4c3a-89f6-ce7684dabc66) ## Checklist <!-- Check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] I have verified that the changes work before posting/requesting review of my PR. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I have read the [Pull Request and Changelog Guidelines][guidelines] and [Byrd Station's Contributor Ruleset][ruleset]. ### Ingame Changelog :cl: Quill - add: Towels can now remove stains from your own clothes and from other players clothes via the strip menu. - add: Added clothing stains to cloaks, mantles, folded jumpsuits, folded jumpskirts, and pulled down masks. - add: Clothing stain severity now varies based on the amount of solution on clothing. - add: Shoes now clean themselves when leaving footprints behind. - tweak: Updated clothing stain appearance on face masks, breath masks, bandanas, hats, berets, and boxer shorts. - tweak: Reduced clothing stain cleanse delay from 5 seconds to 2 seconds. - tweak: Doubled the amount of units a clothing stain can hold. - fix: Stains now display correctly on face masks and gask masks when pulled down.
Adjusted the stainable mantle sprite
Some checks failed
Close PRs on master / run (pull_request_target) Has been skipped
Labels: PR / labeler (pull_request_target) Successful in 1m18s
Labels: Size / size-label (pull_request_target) Failing after 1m18s
CRLF Check / CRLF Check (pull_request) Successful in 2m3s
RSI Validator / Validate RSIs (pull_request) Successful in 1m8s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m36s
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
5e4a12b5db
Changed the cleanse delay from stains to 2 seconds
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 12s
Labels: Size / size-label (pull_request_target) Successful in 4s
CRLF Check / CRLF Check (pull_request) Successful in 35s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m0s
RSI Validator / Validate RSIs (pull_request) Successful in 1m10s
YAML Linter / YAML Linter (pull_request) Failing after 6m52s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m49s
Test Packaging / Test Packaging (pull_request) Successful in 15m11s
0190bb9ffe
Added stainable glasses sprites
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 3s
Labels: PR / labeler (pull_request_target) Successful in 4s
CRLF Check / CRLF Check (pull_request) Successful in 43s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 54s
RSI Validator / Validate RSIs (pull_request) Successful in 1m3s
YAML Linter / YAML Linter (pull_request) Failing after 6m51s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m24s
Test Packaging / Test Packaging (pull_request) Successful in 15m3s
ac94ff6f86
Added an empty stain sprite for gas masks when they're pulled down
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 1m1s
Labels: PR / labeler (pull_request_target) Successful in 1m1s
CRLF Check / CRLF Check (pull_request) Successful in 1m41s
RSI Validator / Validate RSIs (pull_request) Successful in 1m17s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m22s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m36s
YAML Linter / YAML Linter (pull_request) Failing after 7m3s
Test Packaging / Test Packaging (pull_request) Successful in 16m23s
f89f5fbc3e
Added stainable jumpsuit and skirt folded sprite states
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 4s
Labels: PR / labeler (pull_request_target) Successful in 4s
CRLF Check / CRLF Check (pull_request) Successful in 45s
RSI Validator / Validate RSIs (pull_request) Successful in 59s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m8s
YAML Linter / YAML Linter (pull_request) Failing after 7m5s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m34s
Test Packaging / Test Packaging (pull_request) Successful in 21m24s
25ccfa3cd3
Added a missing byrd begin/end to the gas mask stain
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 58s
Labels: PR / labeler (pull_request_target) Successful in 58s
CRLF Check / CRLF Check (pull_request) Successful in 1m40s
RSI Validator / Validate RSIs (pull_request) Successful in 1m14s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m25s
Map file schema validator / YAML map schema validator (pull_request) Successful in 10m12s
YAML Linter / YAML Linter (pull_request) Failing after 11m36s
Test Packaging / Test Packaging (pull_request) Successful in 23m33s
2e9c1379c6
Added a clickable stain remover system which cleans up stains from clothes with towels
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 57s
Labels: PR / labeler (pull_request_target) Successful in 57s
CRLF Check / CRLF Check (pull_request) Successful in 1m38s
RSI Validator / Validate RSIs (pull_request) Successful in 1m1s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m4s
YAML Linter / YAML Linter (pull_request) Failing after 7m6s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m41s
Test Packaging / Test Packaging (pull_request) Successful in 16m17s
c0c14869a2
Renamed the stain remover system
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 1m1s
Labels: Size / size-label (pull_request_target) Successful in 1m1s
CRLF Check / CRLF Check (pull_request) Successful in 1m39s
RSI Validator / Validate RSIs (pull_request) Successful in 1m7s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m16s
YAML Linter / YAML Linter (pull_request) Failing after 6m38s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m27s
Test Packaging / Test Packaging (pull_request) Successful in 15m57s
4c9c9911a0
Updated the stain remover doafter bar to be colored like the stain
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 4s
Labels: PR / labeler (pull_request_target) Successful in 4s
CRLF Check / CRLF Check (pull_request) Successful in 46s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 57s
RSI Validator / Validate RSIs (pull_request) Successful in 1m7s
YAML Linter / YAML Linter (pull_request) Failing after 6m49s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m13s
Test Packaging / Test Packaging (pull_request) Successful in 14m51s
bb3f313a75
Updated the stain system to support different sprites based on how stained clothes are
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 1m0s
Labels: PR / labeler (pull_request_target) Successful in 1m0s
CRLF Check / CRLF Check (pull_request) Successful in 1m41s
RSI Validator / Validate RSIs (pull_request) Successful in 1m5s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m20s
YAML Linter / YAML Linter (pull_request) Failing after 6m41s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m22s
Test Packaging / Test Packaging (pull_request) Successful in 16m1s
3763c6ecbc
Added different stain levels based on how much of the solution is on the clothes.
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 3s
Labels: PR / labeler (pull_request_target) Successful in 5s
CRLF Check / CRLF Check (pull_request) Successful in 42s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 47s
RSI Validator / Validate RSIs (pull_request) Successful in 55s
YAML Linter / YAML Linter (pull_request) Failing after 7m6s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m25s
Test Packaging / Test Packaging (pull_request) Successful in 15m19s
e10d501472
QuillTheCreature force-pushed features/stains/togglesandmorestates from 1ad554811f
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 58s
Labels: PR / labeler (pull_request_target) Successful in 58s
CRLF Check / CRLF Check (pull_request) Successful in 1m46s
YAML Linter / YAML Linter (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
to dffb640be1
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 3s
Labels: PR / labeler (pull_request_target) Successful in 11s
CRLF Check / CRLF Check (pull_request) Successful in 52s
RSI Validator / Validate RSIs (pull_request) Successful in 1m9s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m27s
YAML Linter / YAML Linter (pull_request) Failing after 6m50s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m28s
Test Packaging / Test Packaging (pull_request) Successful in 15m3s
2026-09-16 15:45:47 +00:00
Compare
Footprints now also grab solutions from the shoes on top of the usual way
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 57s
Labels: Size / size-label (pull_request_target) Successful in 56s
CRLF Check / CRLF Check (pull_request) Successful in 1m32s
RSI Validator / Validate RSIs (pull_request) Successful in 1m11s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m18s
YAML Linter / YAML Linter (pull_request) Failing after 6m45s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m28s
Test Packaging / Test Packaging (pull_request) Successful in 15m48s
fa94f0df49
Removed the aura cloak from the stain system
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 57s
Labels: PR / labeler (pull_request_target) Successful in 58s
CRLF Check / CRLF Check (pull_request) Successful in 1m40s
RSI Validator / Validate RSIs (pull_request) Successful in 1m7s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m16s
YAML Linter / YAML Linter (pull_request) Failing after 6m46s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m23s
Test Packaging / Test Packaging (pull_request) Successful in 15m49s
1366951bb4
Merge branch 'master' into features/stains/togglesandmorestates
All checks were successful
Labels: Size / size-label (pull_request_target) Successful in 1m2s
Labels: PR / labeler (pull_request_target) Successful in 1m2s
CRLF Check / CRLF Check (pull_request) Successful in 1m45s
RSI Validator / Validate RSIs (pull_request) Successful in 1m11s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m33s
YAML Linter / YAML Linter (pull_request) Successful in 7m20s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m56s
Test Packaging / Test Packaging (pull_request) Successful in 16m37s
ee558569b5
# Conflicts:
#	Resources/Prototypes/_Goobstation/Entities/Clothing/Head/hats.yml
Updated breath and medical breath masks stain sprites
All checks were successful
Labels: Size / size-label (pull_request_target) Successful in 3s
Labels: PR / labeler (pull_request_target) Successful in 5s
CRLF Check / CRLF Check (pull_request) Successful in 42s
RSI Validator / Validate RSIs (pull_request) Successful in 54s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m3s
YAML Linter / YAML Linter (pull_request) Successful in 7m21s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m45s
Test Packaging / Test Packaging (pull_request) Successful in 15m29s
6c08d961d0
Contributor

we have a separate pants type for boxer?

we have a separate pants type for boxer?
Author
Member

@Duuckie wrote in #922 (comment):

we have a separate pants type for boxer?

Discord request 🤷‍♂️

@Duuckie wrote in https://git.byrdstation.space/Byrd-Station/Byrd/pulls/922#issuecomment-8136: > we have a separate pants type for boxer? Discord request 🤷‍♂️
Allowed players to clean up other players clothes
All checks were successful
Labels: Size / size-label (pull_request_target) Successful in 56s
Labels: PR / labeler (pull_request_target) Successful in 56s
CRLF Check / CRLF Check (pull_request) Successful in 1m40s
RSI Validator / Validate RSIs (pull_request) Successful in 1m11s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m33s
YAML Linter / YAML Linter (pull_request) Successful in 7m3s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m47s
Test Packaging / Test Packaging (pull_request) Successful in 15m56s
ecd44ba786
Fixed stains not updating after cleaning them up with a towel
All checks were successful
Labels: Size / size-label (pull_request_target) Successful in 58s
Labels: PR / labeler (pull_request_target) Successful in 58s
CRLF Check / CRLF Check (pull_request) Successful in 1m36s
RSI Validator / Validate RSIs (pull_request) Successful in 1m9s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m23s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m32s
YAML Linter / YAML Linter (pull_request) Successful in 7m24s
Test Packaging / Test Packaging (pull_request) Successful in 16m36s
76e712d6b9
@ -63,3 +77,3 @@
return;
foreach (var (key, layer) in UpdateVisuals(ent, layers, args.Location))
foreach (var (key, layer) in UpdateVisuals(ent, layers, args.Location)) // Byrd
Owner

Byrd comments are supposed to mark changes that we made, but the only change here is the comment being added.

Byrd comments are supposed to mark changes that we made, but the only change here is the comment being added.
Author
Member

Seems to have been leftover comments from refactoring, thanks.

Seems to have been leftover comments from refactoring, thanks.
QuillTheCreature marked this conversation as resolved
@ -247,0 +283,4 @@
return;
var stainRemover = (stainRemoverEntity, stainRemoverComponent);
if (!_absorbentStainRemover.ValidateStainRemoval(args.User, stainRemover, args.Target, out _, out _, out _, out _, out _, out _, out _))
Owner

I feel like it shouldn't scream at you just because you right click on a clothing item while holding a towel.
This verb should only appear when the clothing item is dirty just like wring verb and scream at you after you try to clean without all the requirements passing.

I feel like it shouldn't scream at you just because you right click on a clothing item while holding a towel. This verb should only appear when the clothing item is dirty just like wring verb and scream at you after you try to clean without all the requirements passing.
Author
Member

Agree yeah

Agree yeah
QuillTheCreature marked this conversation as resolved
@ -0,0 +82,4 @@
if (TryGetNetEntity(target, out var netTarget) && _net.IsServer)
{
Logger.Info($"Updating: {MetaData(target).EntityName}");
Owner

Not really important enough to be logged.

Not really important enough to be logged.
QuillTheCreature marked this conversation as resolved
@ -24,0 +54,4 @@
iconVisuals:
- percent: 0
layers:
- sprite: _Byrd/Effects/blood/edits/helmetbloodicon.rsi
Owner

_Byrd/Effects/blood/edits/helmetbloodicon.rsi looks really weird on glasses.

`_Byrd/Effects/blood/edits/helmetbloodicon.rsi` looks really weird on glasses.
QuillTheCreature marked this conversation as resolved
@ -0,0 +30,4 @@
iconVisuals:
- percent: 0
layers:
- sprite: _Byrd/Effects/blood/edits/helmetbloodicon.rsi
Owner

_Byrd/Effects/blood/edits/helmetbloodicon.rsi looks a little weird on berets, but much better than glasses.

`_Byrd/Effects/blood/edits/helmetbloodicon.rsi` looks a little weird on berets, but much better than glasses.
QuillTheCreature marked this conversation as resolved
@ -0,0 +1,50 @@
- type: entity
parent: ClothingHeadBase
id: ClothingHeadHatStainable
Owner

ClothingHeadHatBeretWarden has ClothingHeadHatStainable instead of ClothingHeadBeretStainable because of inheritance.

`ClothingHeadHatBeretWarden` has `ClothingHeadHatStainable` instead of `ClothingHeadBeretStainable` because of inheritance.
QuillTheCreature marked this conversation as resolved
@ -0,0 +9,4 @@
head:
- percent: 0
layers:
- sprite: _Byrd/Effects/blood/hat.rsi
Owner

_Byrd/Effects/blood/hat.rsi looks slightly weird on ClothingHeadHatCaptain.

`_Byrd/Effects/blood/hat.rsi` looks slightly weird on `ClothingHeadHatCaptain`.
QuillTheCreature marked this conversation as resolved
@ -0,0 +30,4 @@
iconVisuals:
- percent: 0
layers:
- sprite: _Byrd/Effects/blood/edits/helmetbloodicon.rsi
Owner

_Byrd/Effects/blood/edits/helmetbloodicon.rsi looks weird on most hats.

`_Byrd/Effects/blood/edits/helmetbloodicon.rsi` looks weird on most hats.
QuillTheCreature marked this conversation as resolved
Owner

Also tweak: Clothing stains do no longer appears on your face when a gas mask is pulled down. should probably be a fix, there is a typo (no need for do) and it can probably be merged with fix: Stains now display correctly on face masks when pulled down. as face wear or something similar.

Also `tweak: Clothing stains do no longer appears on your face when a gas mask is pulled down.` should probably be a fix, there is a typo (no need for do) and it can probably be merged with `fix: Stains now display correctly on face masks when pulled down.` as face wear or something similar.
Removed leftover byrd comments
Some checks failed
Labels: PR / labeler (pull_request_target) Has been cancelled
Labels: Size / size-label (pull_request_target) Has been cancelled
CRLF Check / CRLF Check (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
a792600194
Adjusted the stain remover to not show popups when checking if we should show the verb
Some checks failed
Labels: PR / labeler (pull_request_target) Successful in 6s
Labels: Size / size-label (pull_request_target) Successful in 3s
Test Packaging / Test Packaging (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
CRLF Check / CRLF Check (pull_request) Has been cancelled
2001f4314a
Fixed wardens beret using the hat stainable
All checks were successful
Labels: Size / size-label (pull_request_target) Successful in 3s
Labels: PR / labeler (pull_request_target) Successful in 9s
CRLF Check / CRLF Check (pull_request) Successful in 56s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m14s
RSI Validator / Validate RSIs (pull_request) Successful in 1m13s
Map file schema validator / YAML map schema validator (pull_request) Successful in 8m51s
YAML Linter / YAML Linter (pull_request) Successful in 9m26s
Test Packaging / Test Packaging (pull_request) Successful in 18m44s
31ccc91183
Added custom stained glasses icons
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 3s
Labels: PR / labeler (pull_request_target) Successful in 5s
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
RSI Validator / Validate RSIs (pull_request) Has been cancelled
RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled
Test Packaging / Test Packaging (pull_request) Has been cancelled
CRLF Check / CRLF Check (pull_request) Has been cancelled
9034627589
Removed debug log from stain remover
All checks were successful
Labels: PR / labeler (pull_request_target) Successful in 11s
Labels: Size / size-label (pull_request_target) Successful in 5s
CRLF Check / CRLF Check (pull_request) Successful in 41s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m16s
RSI Validator / Validate RSIs (pull_request) Successful in 1m1s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m52s
YAML Linter / YAML Linter (pull_request) Successful in 7m33s
Test Packaging / Test Packaging (pull_request) Successful in 16m3s
3ccb44c677
Adjusted beret stain icons and fixed some berets using hat stains
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 5s
Labels: PR / labeler (pull_request_target) Successful in 7s
CRLF Check / CRLF Check (pull_request) Successful in 47s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m4s
RSI Validator / Validate RSIs (pull_request) Successful in 1m16s
Map file schema validator / YAML map schema validator (pull_request) Successful in 8m10s
YAML Linter / YAML Linter (pull_request) Successful in 8m13s
Test Packaging / Test Packaging (pull_request) Has been cancelled
7afe546997
Added a hat stain icon
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 14s
Labels: PR / labeler (pull_request_target) Successful in 16s
CRLF Check / CRLF Check (pull_request) Successful in 6m25s
RSI Validator / Validate RSIs (pull_request) Successful in 8m29s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 8m39s
Test Packaging / Test Packaging (pull_request) Has been cancelled
Map file schema validator / YAML map schema validator (pull_request) Has been cancelled
YAML Linter / YAML Linter (pull_request) Has been cancelled
5df03d8a5d
Added captain hardhat stains
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 5s
Labels: PR / labeler (pull_request_target) Successful in 13s
CRLF Check / CRLF Check (pull_request) Successful in 41s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 58s
RSI Validator / Validate RSIs (pull_request) Failing after 1m4s
YAML Linter / YAML Linter (pull_request) Successful in 7m38s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m58s
Test Packaging / Test Packaging (pull_request) Successful in 16m24s
501413b8c6
@ -247,0 +283,4 @@
return;
var stainRemover = (stainRemoverEntity, stainRemoverComponent);
if (!_absorbentStainRemover.ValidateStainRemoval(args.User, stainRemover, args.Target, false, out _, out _, out _, out _, out _, out _, out _))
Owner

It no longer yells at you for just right clicking and that's good, but I think the button should appear even if the all the conditions are not met as long as targeted clothing item is dirty. It can just yell at you when you try to clean it. Currently it's basically impossible to get the popups and figure out what's wrong because the button never appears when something is wrong and it only yells if you press the button.

It no longer yells at you for just right clicking and that's good, but I think the button should appear even if the all the conditions are not met as long as targeted clothing item is dirty. It can just yell at you when you try to clean it. Currently it's basically impossible to get the popups and figure out what's wrong because the button never appears when something is wrong and it only yells if you press the button.
QuillTheCreature marked this conversation as resolved
Removed stainable check so towels always show the wash clothes verb and only error when clicking on it
Some checks failed
Labels: Size / size-label (pull_request_target) Successful in 11s
Labels: PR / labeler (pull_request_target) Successful in 11s
CRLF Check / CRLF Check (pull_request) Successful in 1m2s
RSI Validator / Validate RSIs (pull_request) Failing after 1m10s
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m58s
Map file schema validator / YAML map schema validator (pull_request) Successful in 7m35s
YAML Linter / YAML Linter (pull_request) Successful in 14m1s
Test Packaging / Test Packaging (pull_request) Successful in 23m27s
PR Changelogs / changelog (pull_request_target) Successful in 1m25s
8016a9af97
EchoOfNothing left a comment

I didn't check everything, but this doesn't seem to cause any major issues so LGTM. Thank you for your great contribution!

I didn't check everything, but this doesn't seem to cause any major issues so LGTM. Thank you for your great contribution!
EchoOfNothing referenced this pull request from a commit 2026-10-02 07:45:04 +00:00
byrdbot referenced this pull request from a commit 2026-10-02 07:46:27 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Byrd-Station/Byrd!922
No description provided.