Stainable improvements #922
No reviewers
Labels
No labels
Area/Accessibility
Area/Admin Tooling
Area/Art
Area/Atmospherics
Area/Cargo
Area/Character / Species
Area/Chat
Area/Combat
Area/Command
Area/Database
Area/Engineering
Area/Graphics
Area/Guidebook
Area/Mapping
Area/Medical
Area/Preferences / Options
Area/Roleplay / Lore
Area/Roundflow / Antag
Area/Rules
Area/Salvage
Area/Science
Area/Security
Area/Service
Area/Silicons
bug
Changes: Audio
Changes: Map
Changes: No C#
Changes: Sprites
Changes: UI
documentation
DON'T MERGE
duplicate
good first issue
help wanted
holding to vote
Note/Port
Note/Upstream
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
size/L
size/M
size/S
size/XL
size/XS
State/Approved
State/invalid
State/Merge Conflict
State/Needs Changes
State/Needs Discussion
State/Untriaged
Type/Balance Change
Type/Bugfix
Type/Documentation
Type/Enhancement
Type/Feature
Type/Question
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Byrd-Station/Byrd!922
Loading…
Reference in a new issue
No description provided.
Delete branch ":features/stains/togglesandmorestates"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Short description
Why we need to add this
Age old complaints about the stainable system and new sprites which fit better.
Additionally, the new towel feature is there so plasmamans don't need to die when they want to be clean.
Media (Video/Screenshots)
Shoe footprints
Stain severity system
Towel stain removal system
Towel stain removal on other players via the strip menu
Facemask
Facemask pulled down
Hats
Glasses
Bandanas
Mantles
Cloaks
Berets
Boxer
Gas Mask
Jumpsuit folded
Checklist
Ingame Changelog
🆑 Quill
1ad554811fdffb640be1we have a separate pants type for boxer?
@Duuckie wrote in #922 (comment):
Discord request 🤷♂️
@ -63,3 +77,3 @@return;foreach (var (key, layer) in UpdateVisuals(ent, layers, args.Location))foreach (var (key, layer) in UpdateVisuals(ent, layers, args.Location)) // ByrdByrd comments are supposed to mark changes that we made, but the only change here is the comment being added.
Seems to have been leftover comments from refactoring, thanks.
@ -247,0 +283,4 @@return;var stainRemover = (stainRemoverEntity, stainRemoverComponent);if (!_absorbentStainRemover.ValidateStainRemoval(args.User, stainRemover, args.Target, out _, out _, out _, out _, out _, out _, out _))I feel like it shouldn't scream at you just because you right click on a clothing item while holding a towel.
This verb should only appear when the clothing item is dirty just like wring verb and scream at you after you try to clean without all the requirements passing.
Agree yeah
@ -0,0 +82,4 @@if (TryGetNetEntity(target, out var netTarget) && _net.IsServer){Logger.Info($"Updating: {MetaData(target).EntityName}");Not really important enough to be logged.
@ -24,0 +54,4 @@iconVisuals:- percent: 0layers:- sprite: _Byrd/Effects/blood/edits/helmetbloodicon.rsi_Byrd/Effects/blood/edits/helmetbloodicon.rsilooks really weird on glasses.@ -0,0 +30,4 @@iconVisuals:- percent: 0layers:- sprite: _Byrd/Effects/blood/edits/helmetbloodicon.rsi_Byrd/Effects/blood/edits/helmetbloodicon.rsilooks a little weird on berets, but much better than glasses.@ -0,0 +1,50 @@- type: entityparent: ClothingHeadBaseid: ClothingHeadHatStainableClothingHeadHatBeretWardenhasClothingHeadHatStainableinstead ofClothingHeadBeretStainablebecause of inheritance.@ -0,0 +9,4 @@head:- percent: 0layers:- sprite: _Byrd/Effects/blood/hat.rsi_Byrd/Effects/blood/hat.rsilooks slightly weird onClothingHeadHatCaptain.@ -0,0 +30,4 @@iconVisuals:- percent: 0layers:- sprite: _Byrd/Effects/blood/edits/helmetbloodicon.rsi_Byrd/Effects/blood/edits/helmetbloodicon.rsilooks weird on most hats.Also
tweak: Clothing stains do no longer appears on your face when a gas mask is pulled down.should probably be a fix, there is a typo (no need for do) and it can probably be merged withfix: Stains now display correctly on face masks when pulled down.as face wear or something similar.@ -247,0 +283,4 @@return;var stainRemover = (stainRemoverEntity, stainRemoverComponent);if (!_absorbentStainRemover.ValidateStainRemoval(args.User, stainRemover, args.Target, false, out _, out _, out _, out _, out _, out _, out _))It no longer yells at you for just right clicking and that's good, but I think the button should appear even if the all the conditions are not met as long as targeted clothing item is dirty. It can just yell at you when you try to clean it. Currently it's basically impossible to get the popups and figure out what's wrong because the button never appears when something is wrong and it only yells if you press the button.
I didn't check everything, but this doesn't seem to cause any major issues so LGTM. Thank you for your great contribution!